From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajesh Bhagat Date: Wed, 1 Jun 2016 07:07:52 +0000 Subject: [U-Boot] [PATCH 2/3] armv8/fsl-layerscape: add dwc3 gadget driver support In-Reply-To: <87r3chl8j1.fsf@linux.intel.com> References: <1464694370-15853-1-git-send-email-rajat.srivastava@nxp.com> <1464694370-15853-3-git-send-email-rajat.srivastava@nxp.com> <574D7DB0.5080702@denx.de> <8760tumns7.fsf@linux.intel.com> <87r3chl8j1.fsf@linux.intel.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > -----Original Message----- > From: Felipe Balbi [mailto:felipe.balbi at linux.intel.com] > Sent: Wednesday, June 01, 2016 12:07 PM > To: Rajesh Bhagat ; Marek Vasut ; > Rajat Srivastava ; u-boot at lists.denx.de > Cc: l.majewski at samsung.com; sjg at chromium.org; albert.u.boot at aribaud.net; > prabhakar at freescale.com; york sun ; Mingkai Hu > ; michal.simek at xilinx.com > Subject: RE: [PATCH 2/3] armv8/fsl-layerscape: add dwc3 gadget driver support > > > Hi, > > Rajesh Bhagat writes: > >> Marek Vasut writes: > >> >> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > >> >> index 85cc96a..5eeb71d 100644 > >> >> --- a/drivers/usb/dwc3/core.c > >> >> +++ b/drivers/usb/dwc3/core.c > >> >> @@ -690,6 +690,18 @@ int dwc3_uboot_init(struct dwc3_device *dwc3_dev) > >> >> return -ENOMEM; > >> >> } > >> >> > >> >> +#if defined(CONFIG_LS1043A) > >> > > >> > How was this added in Linux ? I doubt such horrid ifdef was allowed. > >> > I presume it went through either DT or struct dwc3_device, right ? > >> > So fix this here the same way. > >> > >> dwc3 doesn't have any of that. I wouldn't take it :-p > >> > > > > Hello Felipe/Marek, > > > > It is not currently added in Linux, These registers setting is > > required for Setting the burst beat transactions and enabling the snooping for DWC3 > USB IP. > > that's fine, but you don't need to ifdef around that. Pass these values from your > platform code. > > > Can it be added using dwc3 uboot glue layer e.g. dwc3-fsl.c ? > > keep in core, but pass them from plat code instead of hardcoding under ifdef. > > Also, get rid of the magic constant ;-) > Ok, thanks. Will take care in v2. > -- > balbi