From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752765AbcGOI2J (ORCPT ); Fri, 15 Jul 2016 04:28:09 -0400 Received: from mail-db5eur01on0083.outbound.protection.outlook.com ([104.47.2.83]:40208 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751394AbcGOI2C convert rfc822-to-8bit (ORCPT ); Fri, 15 Jul 2016 04:28:02 -0400 From: Rajesh Bhagat To: Peter Chen CC: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Peter Chen , "gregkh@linuxfoundation.org" , "kishon@ti.com" , "robh+dt@kernel.org" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller Thread-Topic: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller Thread-Index: AQHR2Zq0gi8SERF3kEC812m/gTKsgKASzVSAgAFYwpCABPf6AIAAAk2w Date: Fri, 15 Jul 2016 08:13:40 +0000 Message-ID: References: <1468038656-10345-1-git-send-email-rajesh.bhagat@nxp.com> <1468038656-10345-3-git-send-email-rajesh.bhagat@nxp.com> <20160711064845.GH31647@shlinux2> <20160715071516.GG817@shlinux2> In-Reply-To: <20160715071516.GG817@shlinux2> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rajesh.bhagat@nxp.com; x-originating-ip: [192.88.169.1] x-ms-office365-filtering-correlation-id: 2c0a8155-77a8-4153-c0c2-08d3ac87ee65 x-microsoft-exchange-diagnostics: 1;HE1PR04MB1452;6:tvjOW4ONecLo6179tTZOYVVdRTt4sEAizy3ZwyLPJew+s+FmuhK8aiBxYEfbK0nRNx0nM0Yxxb9JFOvbBH1RNDSa5ogruXaZVRMLWdWuBMEE9MKYiRBI24TGuHszxh/Yzz2uZ+QU7wa5d5F/obAMfL6fxb66JGm2wC8TDz2XaErKQsSt/Qdd5OYiF8W2GPcJTvf+YSM3HJx74G/9qaQHoSwzeJJhf87CwDQ7UX75tXbMvDezQ8dzNJuVf+B51K0h4TuVipI6g7Y0cmmRve7EQ/xcxekb/ERZkja8VtqKbK2qyZpsPEYpK8rAhpROZpN0XpbYUhKPoadVY4asbKd+Lg==;5:vOuG/uueDr/B9JDXGOCr6V13b30He/zz+hpq5YunBX2eWsBaMMTGQi6ZRhhtvzVeMlxy17p1T9dL/kXMWgu/GTqfdzQeV0XI+mEn7qtiBA5jfp/qt2PbNrHx8XT4aniM92F2DEFicfHUkhYSmwm9Lg==;24:eY02ArM5rOVDZMvuwa/XKD7+gMwZ9eW7RLrWnOFkiSZXGzfjwfcxVQK2FI8eXwCLEB1cbTt3f3BRXI7dl8MyqyUyQtcK+XUxmxz1/LeIhqA=;7:09PMPOUAxgQXoL0jUoEzgWnVtDgreflM89DYUVba4EsTcYO8nOArZ/S43H+cLRFCRZj9OruWAH9jhsA981uuFedso7NqQu22Irbtkq7oxEiHL0lst7s7LNv1dHlMI7SfkZahKOGhJlqJjCT64b+qN0VRu9oSE+xounbgkfJ6Q6HtRXx5R0xi19XWuR40tigBcDBoREVmnL4I0IuDGAh5xpGTAZy1eBb9SHHdC5KPA02X3V+EB+QLZxMR9F6nd5Ja x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR04MB1452; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(31051911155226)(9452136761055)(185117386973197)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:HE1PR04MB1452;BCL:0;PCL:0;RULEID:;SRVR:HE1PR04MB1452; x-forefront-prvs: 00046D390F x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(189002)(24454002)(13464003)(199003)(377454003)(1411001)(33656002)(586003)(86362001)(10400500002)(97736004)(5002640100001)(93886004)(19580395003)(101416001)(19580405001)(74316002)(54356999)(66066001)(77096005)(50986999)(68736007)(8676002)(87936001)(81156014)(76176999)(189998001)(106116001)(8936002)(6116002)(81166006)(3280700002)(305945005)(105586002)(7846002)(2906002)(122556002)(3846002)(11100500001)(102836003)(110136002)(4326007)(7696003)(92566002)(76576001)(3660700001)(5003600100003)(2900100001)(7736002)(9686002)(2950100001)(106356001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR04MB1452;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2016 08:13:40.8279 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB1452 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Peter Chen [mailto:hzpeterchen@gmail.com] > Sent: Friday, July 15, 2016 12:45 PM > To: Rajesh Bhagat > Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; Peter Chen ; > gregkh@linuxfoundation.org; kishon@ti.com; robh+dt@kernel.org; > shawnguo@kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 > controller > > On Tue, Jul 12, 2016 at 03:59:14AM +0000, Rajesh Bhagat wrote: > > > > > > > -----Original Message----- > > > From: Peter Chen [mailto:hzpeterchen@gmail.com] > > > Sent: Monday, July 11, 2016 12:19 PM > > > To: Rajesh Bhagat > > > Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; > > > devicetree@vger.kernel.org; Peter Chen ; > > > gregkh@linuxfoundation.org; kishon@ti.com; robh+dt@kernel.org; > > > shawnguo@kernel.org; linux-arm-kernel@lists.infradead.org > > > Subject: Re: [PATCH v2 2/5] usb: DT binding documentation for qoriq > > > usb 2.0 controller > > > > > > On Sat, Jul 09, 2016 at 10:00:53AM +0530, Rajesh Bhagat wrote: > > > > Describes the qoriq usb 2.0 controller driver binding, currently > > > > used for LS1021A and LS1012A platform. > > > > > > > > Signed-off-by: Rajesh Bhagat > > > > --- > > > > Changes in v2: > > > > - Adds DT binding documentation for qoriq usb 2.0 controller > > > > - Changed the compatible string to fsl,ci-qoriq-usb2 > > > > > > > > .../devicetree/bindings/usb/ci-hdrc-qoriq.txt | 34 > > > ++++++++++++++++++++++ > > > > 1 file changed, 34 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > > > b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > > > new file mode 100644 > > > > index 0000000..8ad7306 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > > > @@ -0,0 +1,34 @@ > > > > +* Freescale QorIQ SoC USB 2.0 Controllers > > > > + > > > > +Required properties: > > > > +- compatible: Should be "fsl,ci-qoriq-usb2" > > > > + Wherever applicable, the IP version of the USB controller > > > > +should > > > > + also be mentioned (for eg. fsl,ci-qoriq-usb2-vX.Y). > > > > + where, X.Y is IP version of USB controller. > > > > Hello Peter, > > > > > > > > Why you need to add IP version at compatible string? > > > Does it can't be read out from ID register of Identification Registers. > > > > > > > I agree. Will drop this controller version thing in DTS in v3. > > > > > > +- reg: Should contain registers location and length > > > > +- interrupts: Should contain controller interrupt > > > > +- phy-names: from the *Generic PHY* bindings > > > > +- phys: from the *Generic PHY* bindings > > > > +- clocks: clock provider specifier > > > > +- clock-names: shall be "usb2-clock" > > > > +Refer to clk/clock-bindings.txt for generic clock consumer > > > > +properties > > > > + > > > > +Recommended properties: > > > > +- dr_mode: One of "host" or "peripheral". > > > > > > Do you support dual-role? > > > > > > > Yes. We do support both host/peripheral mode. > > > Hello Peter, > I mean dual-role switch. If you support that, the dr_mode should be "otg". > For now, we don't support otg mode. Best Regards, Rajesh Bhagat > -- > > Best Regards, > Peter Chen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajesh Bhagat Subject: RE: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller Date: Fri, 15 Jul 2016 08:13:40 +0000 Message-ID: References: <1468038656-10345-1-git-send-email-rajesh.bhagat@nxp.com> <1468038656-10345-3-git-send-email-rajesh.bhagat@nxp.com> <20160711064845.GH31647@shlinux2> <20160715071516.GG817@shlinux2> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160715071516.GG817@shlinux2> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Peter Chen Cc: "devicetree@vger.kernel.org" , Peter Chen , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kishon@ti.com" , "robh+dt@kernel.org" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org > -----Original Message----- > From: Peter Chen [mailto:hzpeterchen@gmail.com] > Sent: Friday, July 15, 2016 12:45 PM > To: Rajesh Bhagat > Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; Peter Chen ; > gregkh@linuxfoundation.org; kishon@ti.com; robh+dt@kernel.org; > shawnguo@kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 > controller > > On Tue, Jul 12, 2016 at 03:59:14AM +0000, Rajesh Bhagat wrote: > > > > > > > -----Original Message----- > > > From: Peter Chen [mailto:hzpeterchen@gmail.com] > > > Sent: Monday, July 11, 2016 12:19 PM > > > To: Rajesh Bhagat > > > Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; > > > devicetree@vger.kernel.org; Peter Chen ; > > > gregkh@linuxfoundation.org; kishon@ti.com; robh+dt@kernel.org; > > > shawnguo@kernel.org; linux-arm-kernel@lists.infradead.org > > > Subject: Re: [PATCH v2 2/5] usb: DT binding documentation for qoriq > > > usb 2.0 controller > > > > > > On Sat, Jul 09, 2016 at 10:00:53AM +0530, Rajesh Bhagat wrote: > > > > Describes the qoriq usb 2.0 controller driver binding, currently > > > > used for LS1021A and LS1012A platform. > > > > > > > > Signed-off-by: Rajesh Bhagat > > > > --- > > > > Changes in v2: > > > > - Adds DT binding documentation for qoriq usb 2.0 controller > > > > - Changed the compatible string to fsl,ci-qoriq-usb2 > > > > > > > > .../devicetree/bindings/usb/ci-hdrc-qoriq.txt | 34 > > > ++++++++++++++++++++++ > > > > 1 file changed, 34 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > > > b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > > > new file mode 100644 > > > > index 0000000..8ad7306 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > > > @@ -0,0 +1,34 @@ > > > > +* Freescale QorIQ SoC USB 2.0 Controllers > > > > + > > > > +Required properties: > > > > +- compatible: Should be "fsl,ci-qoriq-usb2" > > > > + Wherever applicable, the IP version of the USB controller > > > > +should > > > > + also be mentioned (for eg. fsl,ci-qoriq-usb2-vX.Y). > > > > + where, X.Y is IP version of USB controller. > > > > Hello Peter, > > > > > > > > Why you need to add IP version at compatible string? > > > Does it can't be read out from ID register of Identification Registers. > > > > > > > I agree. Will drop this controller version thing in DTS in v3. > > > > > > +- reg: Should contain registers location and length > > > > +- interrupts: Should contain controller interrupt > > > > +- phy-names: from the *Generic PHY* bindings > > > > +- phys: from the *Generic PHY* bindings > > > > +- clocks: clock provider specifier > > > > +- clock-names: shall be "usb2-clock" > > > > +Refer to clk/clock-bindings.txt for generic clock consumer > > > > +properties > > > > + > > > > +Recommended properties: > > > > +- dr_mode: One of "host" or "peripheral". > > > > > > Do you support dual-role? > > > > > > > Yes. We do support both host/peripheral mode. > > > Hello Peter, > I mean dual-role switch. If you support that, the dr_mode should be "otg". > For now, we don't support otg mode. Best Regards, Rajesh Bhagat > -- > > Best Regards, > Peter Chen From mboxrd@z Thu Jan 1 00:00:00 1970 From: rajesh.bhagat@nxp.com (Rajesh Bhagat) Date: Fri, 15 Jul 2016 08:13:40 +0000 Subject: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller In-Reply-To: <20160715071516.GG817@shlinux2> References: <1468038656-10345-1-git-send-email-rajesh.bhagat@nxp.com> <1468038656-10345-3-git-send-email-rajesh.bhagat@nxp.com> <20160711064845.GH31647@shlinux2> <20160715071516.GG817@shlinux2> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > -----Original Message----- > From: Peter Chen [mailto:hzpeterchen at gmail.com] > Sent: Friday, July 15, 2016 12:45 PM > To: Rajesh Bhagat > Cc: linux-usb at vger.kernel.org; linux-kernel at vger.kernel.org; > devicetree at vger.kernel.org; Peter Chen ; > gregkh at linuxfoundation.org; kishon at ti.com; robh+dt at kernel.org; > shawnguo at kernel.org; linux-arm-kernel at lists.infradead.org > Subject: Re: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 > controller > > On Tue, Jul 12, 2016 at 03:59:14AM +0000, Rajesh Bhagat wrote: > > > > > > > -----Original Message----- > > > From: Peter Chen [mailto:hzpeterchen at gmail.com] > > > Sent: Monday, July 11, 2016 12:19 PM > > > To: Rajesh Bhagat > > > Cc: linux-usb at vger.kernel.org; linux-kernel at vger.kernel.org; > > > devicetree at vger.kernel.org; Peter Chen ; > > > gregkh at linuxfoundation.org; kishon at ti.com; robh+dt at kernel.org; > > > shawnguo at kernel.org; linux-arm-kernel at lists.infradead.org > > > Subject: Re: [PATCH v2 2/5] usb: DT binding documentation for qoriq > > > usb 2.0 controller > > > > > > On Sat, Jul 09, 2016 at 10:00:53AM +0530, Rajesh Bhagat wrote: > > > > Describes the qoriq usb 2.0 controller driver binding, currently > > > > used for LS1021A and LS1012A platform. > > > > > > > > Signed-off-by: Rajesh Bhagat > > > > --- > > > > Changes in v2: > > > > - Adds DT binding documentation for qoriq usb 2.0 controller > > > > - Changed the compatible string to fsl,ci-qoriq-usb2 > > > > > > > > .../devicetree/bindings/usb/ci-hdrc-qoriq.txt | 34 > > > ++++++++++++++++++++++ > > > > 1 file changed, 34 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > > > b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > > > new file mode 100644 > > > > index 0000000..8ad7306 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > > > @@ -0,0 +1,34 @@ > > > > +* Freescale QorIQ SoC USB 2.0 Controllers > > > > + > > > > +Required properties: > > > > +- compatible: Should be "fsl,ci-qoriq-usb2" > > > > + Wherever applicable, the IP version of the USB controller > > > > +should > > > > + also be mentioned (for eg. fsl,ci-qoriq-usb2-vX.Y). > > > > + where, X.Y is IP version of USB controller. > > > > Hello Peter, > > > > > > > > Why you need to add IP version at compatible string? > > > Does it can't be read out from ID register of Identification Registers. > > > > > > > I agree. Will drop this controller version thing in DTS in v3. > > > > > > +- reg: Should contain registers location and length > > > > +- interrupts: Should contain controller interrupt > > > > +- phy-names: from the *Generic PHY* bindings > > > > +- phys: from the *Generic PHY* bindings > > > > +- clocks: clock provider specifier > > > > +- clock-names: shall be "usb2-clock" > > > > +Refer to clk/clock-bindings.txt for generic clock consumer > > > > +properties > > > > + > > > > +Recommended properties: > > > > +- dr_mode: One of "host" or "peripheral". > > > > > > Do you support dual-role? > > > > > > > Yes. We do support both host/peripheral mode. > > > Hello Peter, > I mean dual-role switch. If you support that, the dr_mode should be "otg". > For now, we don't support otg mode. Best Regards, Rajesh Bhagat > -- > > Best Regards, > Peter Chen