From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751337AbcGLEPZ (ORCPT ); Tue, 12 Jul 2016 00:15:25 -0400 Received: from mail-db5eur01on0051.outbound.protection.outlook.com ([104.47.2.51]:43280 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750743AbcGLEPX convert rfc822-to-8bit (ORCPT ); Tue, 12 Jul 2016 00:15:23 -0400 From: Rajesh Bhagat To: Peter Chen CC: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Peter Chen , "gregkh@linuxfoundation.org" , "kishon@ti.com" , "robh+dt@kernel.org" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller Thread-Topic: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller Thread-Index: AQHR2Zq0gi8SERF3kEC812m/gTKsgKASzVSAgAFYwpA= Date: Tue, 12 Jul 2016 03:59:14 +0000 Message-ID: References: <1468038656-10345-1-git-send-email-rajesh.bhagat@nxp.com> <1468038656-10345-3-git-send-email-rajesh.bhagat@nxp.com> <20160711064845.GH31647@shlinux2> In-Reply-To: <20160711064845.GH31647@shlinux2> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rajesh.bhagat@nxp.com; x-originating-ip: [192.88.169.1] x-ms-office365-filtering-correlation-id: d57af16a-7994-4817-6c2e-08d3aa08e381 x-microsoft-exchange-diagnostics: 1;VI1PR04MB1453;6:xXwiKHE57oybIsi3Jg7wvnKhNaDhYmhvIL8N8z5tpBkU5FPi0IizREmS0vJsp54Mv1iDyRXEveYwa2mbBmOTKMZpdrJPkhmcb/OboGb7D1uQIcbW3SfITW88S2f6DZAqa4LzI5gAyI0kepAk5FdY5KU5Iea7r7t14zhysCAz32eIQdQdhPzSEwpLj50u37smN2BUjzYU2mkHh77u8r8K8blU3DRQhJGDelal+Q8/ZcSMpow+/VowvdSkRecXXscyDrSnIgqdyMws8WUu0LOm14S5IuI6vSwOtNGBJaTm2hi2ISpanmVAoIx1bdKdr6zPBuUg8WRklWr62pktwGr8vA==;5:Fl0UxsOMdyh785cBFFbR1EZgiLePJZ3dNw6sNxhaQ+fGaJXQoylHAGi+lOq9VhP+NJIMpUmBO7jKXcTWeU6lbM1oPlfROcHN6ERGK2dnMUTxWlZRbRygdpZninlSd+ie5LgkA+jVS/f7jBDVHn5Atw==;24:uk6J+dBSSRuVPrgvKWvYYLClG0HUcsDIs2K8myeFJuMFNKeEV71EL/1KY3TGPnCyOOpmMNn940S7dv8xjXR4E1K8GKPhoV9VsWxZ6hyS8JY=;7:oeHxDnh7gGS63tCs+Wb9k9uuwI2WUq5r4L8m/ssxpN0niP57m4DceFvj9/5+FzX+rxJptVYmPpnNTHTdaO1kXKVngRLF/Ojh8Dze977ASpBbD8CCHNrwVXZ97aOG/o8E1pNhOPEn9Ie91472lqhuDANMwbmFpQ2MHkcWJmtKKc/15K1+VtknZDoxUre5krGwQJ+rjb3VLTzt++ghHlVB61ZgIuV+WK5+vduHwhFqwc35vzGVXK2Wj4GnPiFPu7iD x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR04MB1453; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(31051911155226)(9452136761055)(185117386973197)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:VI1PR04MB1453;BCL:0;PCL:0;RULEID:;SRVR:VI1PR04MB1453; x-forefront-prvs: 0001227049 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(13464003)(189002)(199003)(24454002)(377454003)(189998001)(5002640100001)(76576001)(110136002)(19580395003)(19580405001)(97736004)(15975445007)(4326007)(7846002)(101416001)(105586002)(106356001)(3660700001)(3280700002)(106116001)(81156014)(122556002)(92566002)(8936002)(77096005)(9686002)(8676002)(10400500002)(81166006)(2900100001)(305945005)(68736007)(7696003)(102836003)(74316002)(11100500001)(5003600100003)(6116002)(1411001)(33656002)(3846002)(7736002)(87936001)(586003)(2950100001)(2906002)(50986999)(86362001)(76176999)(54356999)(66066001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB1453;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2016 03:59:14.0500 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1453 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Peter Chen [mailto:hzpeterchen@gmail.com] > Sent: Monday, July 11, 2016 12:19 PM > To: Rajesh Bhagat > Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; Peter Chen ; > gregkh@linuxfoundation.org; kishon@ti.com; robh+dt@kernel.org; > shawnguo@kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 > controller > > On Sat, Jul 09, 2016 at 10:00:53AM +0530, Rajesh Bhagat wrote: > > Describes the qoriq usb 2.0 controller driver binding, currently used > > for LS1021A and LS1012A platform. > > > > Signed-off-by: Rajesh Bhagat > > --- > > Changes in v2: > > - Adds DT binding documentation for qoriq usb 2.0 controller > > - Changed the compatible string to fsl,ci-qoriq-usb2 > > > > .../devicetree/bindings/usb/ci-hdrc-qoriq.txt | 34 > ++++++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > new file mode 100644 > > index 0000000..8ad7306 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > @@ -0,0 +1,34 @@ > > +* Freescale QorIQ SoC USB 2.0 Controllers > > + > > +Required properties: > > +- compatible: Should be "fsl,ci-qoriq-usb2" > > + Wherever applicable, the IP version of the USB controller should > > + also be mentioned (for eg. fsl,ci-qoriq-usb2-vX.Y). > > + where, X.Y is IP version of USB controller. Hello Peter, > > Why you need to add IP version at compatible string? > Does it can't be read out from ID register of Identification Registers. > I agree. Will drop this controller version thing in DTS in v3. > > +- reg: Should contain registers location and length > > +- interrupts: Should contain controller interrupt > > +- phy-names: from the *Generic PHY* bindings > > +- phys: from the *Generic PHY* bindings > > +- clocks: clock provider specifier > > +- clock-names: shall be "usb2-clock" > > +Refer to clk/clock-bindings.txt for generic clock consumer properties > > + > > +Recommended properties: > > +- dr_mode: One of "host" or "peripheral". > > Do you support dual-role? > Yes. We do support both host/peripheral mode. Best Regards, Rajesh Bhagat > > +- phy_type: the type of the phy connected to the core. Should be one > > + of "utmi", "utmi_wide", "ulpi", "serial" or "hsic". Without this > > + property the PORTSC register won't be touched > > + > > +Examples: > > +usb@8600000 { > > + compatible = "fsl,ci-qoriq-usb2", > > + "fsl,ci-qoriq-usb2-v2.5"; > > + reg = <0x0 0x8600000 0x0 0x1000>; > > + interrupts = <0 139 0x4>; > > + phy-names = "usb2-phy"; > > + phys = <&usbphy0>; > > + clock-names = "usb2-clock"; > > + clocks = <&clockgen 4 3>; > > + dr_mode = "host"; > > + phy_type = "ulpi"; > > +}; > > -- > > 2.6.2.198.g614a2ac > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-usb" > > in the body of a message to majordomo@vger.kernel.org More majordomo > > info at http://vger.kernel.org/majordomo-info.html > > -- > > Best Regards, > Peter Chen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajesh Bhagat Subject: RE: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller Date: Tue, 12 Jul 2016 03:59:14 +0000 Message-ID: References: <1468038656-10345-1-git-send-email-rajesh.bhagat@nxp.com> <1468038656-10345-3-git-send-email-rajesh.bhagat@nxp.com> <20160711064845.GH31647@shlinux2> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160711064845.GH31647@shlinux2> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Peter Chen Cc: "devicetree@vger.kernel.org" , Peter Chen , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kishon@ti.com" , "robh+dt@kernel.org" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org > -----Original Message----- > From: Peter Chen [mailto:hzpeterchen@gmail.com] > Sent: Monday, July 11, 2016 12:19 PM > To: Rajesh Bhagat > Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; Peter Chen ; > gregkh@linuxfoundation.org; kishon@ti.com; robh+dt@kernel.org; > shawnguo@kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 > controller > > On Sat, Jul 09, 2016 at 10:00:53AM +0530, Rajesh Bhagat wrote: > > Describes the qoriq usb 2.0 controller driver binding, currently used > > for LS1021A and LS1012A platform. > > > > Signed-off-by: Rajesh Bhagat > > --- > > Changes in v2: > > - Adds DT binding documentation for qoriq usb 2.0 controller > > - Changed the compatible string to fsl,ci-qoriq-usb2 > > > > .../devicetree/bindings/usb/ci-hdrc-qoriq.txt | 34 > ++++++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > new file mode 100644 > > index 0000000..8ad7306 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > @@ -0,0 +1,34 @@ > > +* Freescale QorIQ SoC USB 2.0 Controllers > > + > > +Required properties: > > +- compatible: Should be "fsl,ci-qoriq-usb2" > > + Wherever applicable, the IP version of the USB controller should > > + also be mentioned (for eg. fsl,ci-qoriq-usb2-vX.Y). > > + where, X.Y is IP version of USB controller. Hello Peter, > > Why you need to add IP version at compatible string? > Does it can't be read out from ID register of Identification Registers. > I agree. Will drop this controller version thing in DTS in v3. > > +- reg: Should contain registers location and length > > +- interrupts: Should contain controller interrupt > > +- phy-names: from the *Generic PHY* bindings > > +- phys: from the *Generic PHY* bindings > > +- clocks: clock provider specifier > > +- clock-names: shall be "usb2-clock" > > +Refer to clk/clock-bindings.txt for generic clock consumer properties > > + > > +Recommended properties: > > +- dr_mode: One of "host" or "peripheral". > > Do you support dual-role? > Yes. We do support both host/peripheral mode. Best Regards, Rajesh Bhagat > > +- phy_type: the type of the phy connected to the core. Should be one > > + of "utmi", "utmi_wide", "ulpi", "serial" or "hsic". Without this > > + property the PORTSC register won't be touched > > + > > +Examples: > > +usb@8600000 { > > + compatible = "fsl,ci-qoriq-usb2", > > + "fsl,ci-qoriq-usb2-v2.5"; > > + reg = <0x0 0x8600000 0x0 0x1000>; > > + interrupts = <0 139 0x4>; > > + phy-names = "usb2-phy"; > > + phys = <&usbphy0>; > > + clock-names = "usb2-clock"; > > + clocks = <&clockgen 4 3>; > > + dr_mode = "host"; > > + phy_type = "ulpi"; > > +}; > > -- > > 2.6.2.198.g614a2ac > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-usb" > > in the body of a message to majordomo@vger.kernel.org More majordomo > > info at http://vger.kernel.org/majordomo-info.html > > -- > > Best Regards, > Peter Chen From mboxrd@z Thu Jan 1 00:00:00 1970 From: rajesh.bhagat@nxp.com (Rajesh Bhagat) Date: Tue, 12 Jul 2016 03:59:14 +0000 Subject: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller In-Reply-To: <20160711064845.GH31647@shlinux2> References: <1468038656-10345-1-git-send-email-rajesh.bhagat@nxp.com> <1468038656-10345-3-git-send-email-rajesh.bhagat@nxp.com> <20160711064845.GH31647@shlinux2> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > -----Original Message----- > From: Peter Chen [mailto:hzpeterchen at gmail.com] > Sent: Monday, July 11, 2016 12:19 PM > To: Rajesh Bhagat > Cc: linux-usb at vger.kernel.org; linux-kernel at vger.kernel.org; > devicetree at vger.kernel.org; Peter Chen ; > gregkh at linuxfoundation.org; kishon at ti.com; robh+dt at kernel.org; > shawnguo at kernel.org; linux-arm-kernel at lists.infradead.org > Subject: Re: [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 > controller > > On Sat, Jul 09, 2016 at 10:00:53AM +0530, Rajesh Bhagat wrote: > > Describes the qoriq usb 2.0 controller driver binding, currently used > > for LS1021A and LS1012A platform. > > > > Signed-off-by: Rajesh Bhagat > > --- > > Changes in v2: > > - Adds DT binding documentation for qoriq usb 2.0 controller > > - Changed the compatible string to fsl,ci-qoriq-usb2 > > > > .../devicetree/bindings/usb/ci-hdrc-qoriq.txt | 34 > ++++++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > new file mode 100644 > > index 0000000..8ad7306 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-qoriq.txt > > @@ -0,0 +1,34 @@ > > +* Freescale QorIQ SoC USB 2.0 Controllers > > + > > +Required properties: > > +- compatible: Should be "fsl,ci-qoriq-usb2" > > + Wherever applicable, the IP version of the USB controller should > > + also be mentioned (for eg. fsl,ci-qoriq-usb2-vX.Y). > > + where, X.Y is IP version of USB controller. Hello Peter, > > Why you need to add IP version at compatible string? > Does it can't be read out from ID register of Identification Registers. > I agree. Will drop this controller version thing in DTS in v3. > > +- reg: Should contain registers location and length > > +- interrupts: Should contain controller interrupt > > +- phy-names: from the *Generic PHY* bindings > > +- phys: from the *Generic PHY* bindings > > +- clocks: clock provider specifier > > +- clock-names: shall be "usb2-clock" > > +Refer to clk/clock-bindings.txt for generic clock consumer properties > > + > > +Recommended properties: > > +- dr_mode: One of "host" or "peripheral". > > Do you support dual-role? > Yes. We do support both host/peripheral mode. Best Regards, Rajesh Bhagat > > +- phy_type: the type of the phy connected to the core. Should be one > > + of "utmi", "utmi_wide", "ulpi", "serial" or "hsic". Without this > > + property the PORTSC register won't be touched > > + > > +Examples: > > +usb at 8600000 { > > + compatible = "fsl,ci-qoriq-usb2", > > + "fsl,ci-qoriq-usb2-v2.5"; > > + reg = <0x0 0x8600000 0x0 0x1000>; > > + interrupts = <0 139 0x4>; > > + phy-names = "usb2-phy"; > > + phys = <&usbphy0>; > > + clock-names = "usb2-clock"; > > + clocks = <&clockgen 4 3>; > > + dr_mode = "host"; > > + phy_type = "ulpi"; > > +}; > > -- > > 2.6.2.198.g614a2ac > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-usb" > > in the body of a message to majordomo at vger.kernel.org More majordomo > > info at http://vger.kernel.org/majordomo-info.html > > -- > > Best Regards, > Peter Chen