From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932772AbcGOLrd (ORCPT ); Fri, 15 Jul 2016 07:47:33 -0400 Received: from mail-db5eur01on0040.outbound.protection.outlook.com ([104.47.2.40]:46823 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932627AbcGOLra convert rfc822-to-8bit (ORCPT ); Fri, 15 Jul 2016 07:47:30 -0400 From: Rajesh Bhagat To: Peter Chen CC: "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Peter Chen , "gregkh@linuxfoundation.org" , "kishon@ti.com" , "robh+dt@kernel.org" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver Thread-Topic: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver Thread-Index: AQHR2Zq1MDrZgQu1fEO30WQbkQFdrqASy/4AgAFX6ECABPmSgIAAAlyg Date: Fri, 15 Jul 2016 08:13:26 +0000 Message-ID: References: <1468038656-10345-1-git-send-email-rajesh.bhagat@nxp.com> <1468038656-10345-2-git-send-email-rajesh.bhagat@nxp.com> <20160711064358.GG31647@shlinux2> <20160715071309.GF817@shlinux2> In-Reply-To: <20160715071309.GF817@shlinux2> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rajesh.bhagat@nxp.com; x-originating-ip: [192.88.169.1] x-ms-office365-filtering-correlation-id: 1aae49e4-1bb5-4bfb-8df4-08d3ac87e604 x-microsoft-exchange-diagnostics: 1;DB5PR04MB1448;6:9nS72JYYUxS7vk3oa4A69kBrGFQMqgjtgizT/KQ/ekpf/z7BO1xNgdqhvV+S8eYtum9eyTq4AwvL9U63WlPqjn35jqz9shSgloEWPghl0QpGNC2rrjIsL6Q0LOaTqCOQuCb0IzqXJEeWSpImfHhIF6uJKwlZTTx8cVpWmzboO3ol7YEMIXfYd9VBvM1cPglk2/rkLBZJdSRxXqngwKE0tlRFWu4OJvOiD4EZaPfArXLZEl9/zcu7MSqoBSH1cNqBWPDdoQt9rxga9uXvhQ3QCSBwI+pSkMkicA3JNOOLOv2FRJK/RL0iKm5MHMyTovNQXclR0wkdAw32jiUkM3al+g==;5:zRDsTcyI786jZoZjmXUWqQIUFNFx5cEYtj/1QXY8IkO2SaQCAOAMDAfUIPQmBs1LSAnwsgUeJNf/a5fd5IGB7w6PqdA8hI4XGIPhAuFesI9Fr087mW5/s4COc6ED4/N3ham3uoybS9XRILBfzZBoaw==;24:w1WiItHzagBRL8QqdrsGIPNyL0lcDzo8pBztldNz9Fq79UHwwOLsLFeHHTZC4YZTaTKrGu79piFC656JXtvG7VJkF1VOBCVWifW9iqsVDK0=;7:ogFbRCtvsOCPFSW27DS84jm7Cnu8BS9O47B95EaYh/3DujzgAZwYWkyAMQMIarFvxBMHPBg/wZDESa2y5wqvUYXEYL5+F95+8aMucSRp7Omb1wE0WOTy+GXPRL6v17KkeKhXi2A5Aavgf/xhHAy4u/jFQzusDxLeU3oZMQ7ZKD8CaQH17E96yxJvtT5mCgm89iVWhEbumwbn92RF3luQ68A9PvotZqm+earJywRInjul4w8VXYyCC3YKEpA/SZUx x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR04MB1448; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(31051911155226)(9452136761055)(185117386973197)(258649278758335); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:DB5PR04MB1448;BCL:0;PCL:0;RULEID:;SRVR:DB5PR04MB1448; x-forefront-prvs: 00046D390F x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(43544003)(24454002)(189002)(13464003)(199003)(377454003)(97736004)(5003600100003)(110136002)(189998001)(7846002)(74316002)(81156014)(81166006)(7696003)(8676002)(93886004)(50986999)(305945005)(2950100001)(105586002)(54356999)(76176999)(8936002)(7736002)(87936001)(92566002)(9686002)(86362001)(5002640100001)(68736007)(19580405001)(101416001)(106116001)(19580395003)(3280700002)(2906002)(586003)(6116002)(102836003)(3846002)(1411001)(66066001)(10400500002)(76576001)(33656002)(3660700001)(4326007)(122556002)(106356001)(77096005)(2900100001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR04MB1448;H:HE1PR0401MB2331.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2016 08:13:26.6910 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB1448 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Peter Chen [mailto:hzpeterchen@gmail.com] > Sent: Friday, July 15, 2016 12:43 PM > To: Rajesh Bhagat > Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; Peter Chen ; > gregkh@linuxfoundation.org; kishon@ti.com; robh+dt@kernel.org; > shawnguo@kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver > > On Tue, Jul 12, 2016 at 03:59:07AM +0000, Rajesh Bhagat wrote: > > > > + > > > > +err_clks: > > > > + ci_hdrc_qoriq_disable_unprepare_clks(pdev); > > > > > > If you have only one clock, it is unnecessary to use dedicated APIs for clock > operation. > > > > > > > We do have multiple clocks, but currently one is integrated in code. > > Hence created the APIs for future use. Hello Peter, > > If you could not integrate one more clocks, I suggest not creating dedicated API until > you need in future. > Okay, Will take care in v3. Best Regards, Rajesh Bhagat > -- > > Best Regards, > Peter Chen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rajesh Bhagat Subject: RE: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver Date: Fri, 15 Jul 2016 08:13:26 +0000 Message-ID: References: <1468038656-10345-1-git-send-email-rajesh.bhagat@nxp.com> <1468038656-10345-2-git-send-email-rajesh.bhagat@nxp.com> <20160711064358.GG31647@shlinux2> <20160715071309.GF817@shlinux2> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160715071309.GF817@shlinux2> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Peter Chen Cc: "devicetree@vger.kernel.org" , Peter Chen , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kishon@ti.com" , "robh+dt@kernel.org" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org > -----Original Message----- > From: Peter Chen [mailto:hzpeterchen@gmail.com] > Sent: Friday, July 15, 2016 12:43 PM > To: Rajesh Bhagat > Cc: linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; Peter Chen ; > gregkh@linuxfoundation.org; kishon@ti.com; robh+dt@kernel.org; > shawnguo@kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver > > On Tue, Jul 12, 2016 at 03:59:07AM +0000, Rajesh Bhagat wrote: > > > > + > > > > +err_clks: > > > > + ci_hdrc_qoriq_disable_unprepare_clks(pdev); > > > > > > If you have only one clock, it is unnecessary to use dedicated APIs for clock > operation. > > > > > > > We do have multiple clocks, but currently one is integrated in code. > > Hence created the APIs for future use. Hello Peter, > > If you could not integrate one more clocks, I suggest not creating dedicated API until > you need in future. > Okay, Will take care in v3. Best Regards, Rajesh Bhagat > -- > > Best Regards, > Peter Chen From mboxrd@z Thu Jan 1 00:00:00 1970 From: rajesh.bhagat@nxp.com (Rajesh Bhagat) Date: Fri, 15 Jul 2016 08:13:26 +0000 Subject: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver In-Reply-To: <20160715071309.GF817@shlinux2> References: <1468038656-10345-1-git-send-email-rajesh.bhagat@nxp.com> <1468038656-10345-2-git-send-email-rajesh.bhagat@nxp.com> <20160711064358.GG31647@shlinux2> <20160715071309.GF817@shlinux2> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > -----Original Message----- > From: Peter Chen [mailto:hzpeterchen at gmail.com] > Sent: Friday, July 15, 2016 12:43 PM > To: Rajesh Bhagat > Cc: linux-usb at vger.kernel.org; linux-kernel at vger.kernel.org; > devicetree at vger.kernel.org; Peter Chen ; > gregkh at linuxfoundation.org; kishon at ti.com; robh+dt at kernel.org; > shawnguo at kernel.org; linux-arm-kernel at lists.infradead.org > Subject: Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver > > On Tue, Jul 12, 2016 at 03:59:07AM +0000, Rajesh Bhagat wrote: > > > > + > > > > +err_clks: > > > > + ci_hdrc_qoriq_disable_unprepare_clks(pdev); > > > > > > If you have only one clock, it is unnecessary to use dedicated APIs for clock > operation. > > > > > > > We do have multiple clocks, but currently one is integrated in code. > > Hence created the APIs for future use. Hello Peter, > > If you could not integrate one more clocks, I suggest not creating dedicated API until > you need in future. > Okay, Will take care in v3. Best Regards, Rajesh Bhagat > -- > > Best Regards, > Peter Chen