From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nipun Gupta Subject: Re: [PATCH v3 3/4] event/dpaa2: support event eth adapter Date: Tue, 17 Oct 2017 10:28:28 +0000 Message-ID: References: <1507657887-11366-1-git-send-email-nipun.gupta@nxp.com> <1508190275-32305-1-git-send-email-nipun.gupta@nxp.com> <1508190275-32305-3-git-send-email-nipun.gupta@nxp.com> <20171017050037.GA4009@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Hemant Agrawal , "nikhil.rao@intel.com" To: Jerin Jacob Return-path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0088.outbound.protection.outlook.com [104.47.0.88]) by dpdk.org (Postfix) with ESMTP id 4CAD11B7DE for ; Tue, 17 Oct 2017 12:28:32 +0200 (CEST) In-Reply-To: <20171017050037.GA4009@jerin> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Tuesday, October 17, 2017 10:31 > To: Nipun Gupta > Cc: dev@dpdk.org; Hemant Agrawal ; > nikhil.rao@intel.com > Subject: Re: [PATCH v3 3/4] event/dpaa2: support event eth adapter >=20 > -----Original Message----- > > Date: Tue, 17 Oct 2017 03:14:34 +0530 > > From: Nipun Gupta > > To: dev@dpdk.org > > CC: hemant.agrawal@nxp.com, jerin.jacob@caviumnetworks.com, > > nikhil.rao@intel.com, Nipun Gupta > > Subject: [PATCH v3 3/4] event/dpaa2: support event eth adapter > > X-Mailer: git-send-email 1.9.1 > > > > Signed-off-by: Nipun Gupta > > Reviewed-by: Nikhil Rao > > Acked-by: Hemant Agrawal > > --- > > Changes in v3: > > Fix shared library build > > Changes in v2: > > Support rx_queue_id =3D -1 in eth adapter queue and and del (Nikhil) > > Remove duplicate returns (Nikhil) > > > > drivers/Makefile | 2 +- > > drivers/event/Makefile | 4 +- > > drivers/event/dpaa2/Makefile | 2 + > > drivers/event/dpaa2/dpaa2_eventdev.c | 151 > ++++++++++++++++++++++++++++++++++- > > drivers/event/dpaa2/dpaa2_eventdev.h | 8 ++ > > 5 files changed, 163 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/Makefile b/drivers/Makefile > > index 0467250..db0cd76 100644 > > --- a/drivers/Makefile > > +++ b/drivers/Makefile > > @@ -39,6 +39,6 @@ DEPDIRS-net :=3D bus mempool > > DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) +=3D crypto > > DEPDIRS-crypto :=3D bus mempool > > DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) +=3D event > > -DEPDIRS-event :=3D bus mempool > > +DEPDIRS-event :=3D bus mempool net > > > > include $(RTE_SDK)/mk/rte.subdir.mk > > diff --git a/drivers/event/Makefile b/drivers/event/Makefile > > index d09be74..e119d60 100644 > > --- a/drivers/event/Makefile > > +++ b/drivers/event/Makefile > > @@ -31,7 +31,7 @@ > > > > include $(RTE_SDK)/mk/rte.vars.mk > > > > -core-libs :=3D librte_eal librte_eventdev > > +core-libs :=3D librte_eal librte_ether librte_eventdev >=20 > The above two changes makes sense to me as eventdev-ethdev Rx adapter is > depended on ethdev and there could be an Rx adapter implementation in > event area that may use ethdev driver exported API. >=20 > Can you split driver/event and driver/Makefile change to different > patch? I have sent the v4 for this series. >=20 > Other than that, This patch set looks good to me and it is ready to merge= . >=20 > But, There is a compilation error[1] in event-next tree be case of > Hemant reported problem[2].I can apply this patch set once the solution f= or > the reported problem[3] is applied to master branch(so that I pull those > changes to next-eventdev to avoid build issue) I understand this :) Thanks, Nipun >=20 > [1] > Applying: event/dpaa2: support event eth adapter > /export/dpdk-next-eventdev/mk/rte.subdir.mk:62: target 'event' given > more than once in the same rule > make[2]: Circular mempool <- event dependency dropped. >=20 > [2] > http://dpdk.org/ml/archives/dev/2017-October/079249.html >=20 > [3] > http://dpdk.org/ml/archives/dev/2017-October/079324.html