From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nipun Gupta Subject: Re: [PATCH 08/12 v3] event/dpaa: add dequeue timeout conversion support Date: Tue, 16 Jan 2018 13:35:52 +0000 Message-ID: References: <20171215130828.14218-1-sunil.kori@nxp.com> <1516125485-28919-1-git-send-email-nipun.gupta@nxp.com> <1516125485-28919-9-git-send-email-nipun.gupta@nxp.com> <20180116115043.GB18928@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Sunil Kumar Kori , Hemant Agrawal To: Jerin Jacob Return-path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0081.outbound.protection.outlook.com [104.47.2.81]) by dpdk.org (Postfix) with ESMTP id B45322BBE for ; Tue, 16 Jan 2018 14:35:54 +0100 (CET) In-Reply-To: <20180116115043.GB18928@jerin> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Tuesday, January 16, 2018 17:21 > To: Nipun Gupta > Cc: dev@dpdk.org; Sunil Kumar Kori ; Hemant Agrawal > > Subject: Re: [PATCH 08/12 v3] event/dpaa: add dequeue timeout conversion > support >=20 > -----Original Message----- > > Date: Tue, 16 Jan 2018 23:28:01 +0530 > > From: Nipun Gupta > > To: jerin.jacob@caviumnetworks.com > > CC: dev@dpdk.org, sunil.kori@nxp.com, hemant.agrawal@nxp.com > > Subject: [PATCH 08/12 v3] event/dpaa: add dequeue timeout conversion > support > > X-Mailer: git-send-email 1.9.1 > > > > From: Sunil Kumar Kori > > > > Signed-off-by: Sunil Kumar Kori > > Acked-by: Hemant Agrawal > > --- > > drivers/event/dpaa/dpaa_eventdev.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/event/dpaa/dpaa_eventdev.c > b/drivers/event/dpaa/dpaa_eventdev.c > > index 82362d5..b4b7aed 100644 > > --- a/drivers/event/dpaa/dpaa_eventdev.c > > +++ b/drivers/event/dpaa/dpaa_eventdev.c > > @@ -361,6 +361,7 @@ > > .port_release =3D dpaa_event_port_release, > > .port_link =3D dpaa_event_port_link, > > .port_unlink =3D dpaa_event_port_unlink, > > + .timeout_ticks =3D dpaa_event_dequeue_timeout_ticks, >=20 > This patch is almost empty. Please define dpaa_event_dequeue_timeout_tick= s() > in this patch Hi Jerin, As dpaa_event_dequeue_timeout_ticks() is used in patch 5/12 (in function dpaa_event_dev_configure), I would prefer squashing this in the same patch. Is this okay with you? Regards, Nipun >=20 > > }; > > > > static int > > -- > > 1.9.1 > >