From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752641AbeEPItH (ORCPT ); Wed, 16 May 2018 04:49:07 -0400 Received: from mail-ve1eur01on0067.outbound.protection.outlook.com ([104.47.1.67]:12608 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752575AbeEPItC (ORCPT ); Wed, 16 May 2018 04:49:02 -0400 From: Nipun Gupta To: Laurentiu Tudor , "robin.murphy@arm.com" , "will.deacon@arm.com" , "mark.rutland@arm.com" , "catalin.marinas@arm.com" CC: "hch@lst.de" , "gregkh@linuxfoundation.org" , "joro@8bytes.org" , "robh+dt@kernel.org" , "m.szyprowski@samsung.com" , "shawnguo@kernel.org" , "frowand.list@gmail.com" , "bhelgaas@google.com" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-pci@vger.kernel.org" , Bharat Bhushan , "stuyoder@gmail.com" , Leo Li Subject: RE: [PATCH 5/6 v3] bus: fsl-mc: supoprt dma configure for devices on fsl-mc bus Thread-Topic: [PATCH 5/6 v3] bus: fsl-mc: supoprt dma configure for devices on fsl-mc bus Thread-Index: AQHT3hJvd38tyRQBaUCUdR33NexPgaQvVeoAgALRLeA= Date: Wed, 16 May 2018 08:48:57 +0000 Message-ID: References: <1524824826-29473-1-git-send-email-nipun.gupta@nxp.com> <1524824826-29473-6-git-send-email-nipun.gupta@nxp.com> <5AF9916E.8000504@nxp.com> In-Reply-To: <5AF9916E.8000504@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=nipun.gupta@nxp.com; x-originating-ip: [14.142.187.166] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;HE1PR0401MB2315;7:YHoK4+P//9CmI0Rrb8CpR1LDaA5r4qv2Qp+Gca8S1MWEmnA/tEwboBzOewKU/aLoWdyPI3MUb/u7TE4d+ILHNrsR5tyDBlmqCEqyBNsnE36wthgBMYFYwPqgK5OVXpNPYWcLaRHtxzNzfSgB5e3aijzYNo+GsUuUBIIbQe9/9zli36v5imKfT7o6Uvx5tIdBJ9MPCoJ6OBSADCB/37vE3rz2PoZ+fjAN873nkdH/ryWoJOZufdM0r74yOtLTsLmN x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(48565401081)(2017052603328)(7153060)(7193020);SRVR:HE1PR0401MB2315; x-ms-traffictypediagnostic: HE1PR0401MB2315: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(9452136761055)(65623756079841)(185117386973197)(85827821059158)(258649278758335)(211936372134217)(7411616537696); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011);SRVR:HE1PR0401MB2315;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0401MB2315; x-forefront-prvs: 0674DC6DD3 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(39380400002)(346002)(376002)(396003)(39860400002)(54094003)(199004)(189003)(54534003)(13464003)(6506007)(53546011)(6436002)(446003)(102836004)(305945005)(74316002)(6246003)(2501003)(5250100002)(11346002)(229853002)(25786009)(33656002)(6116002)(3846002)(97736004)(76176011)(7696005)(99286004)(478600001)(105586002)(2900100001)(9686003)(53936002)(106356001)(316002)(26005)(55016002)(8936002)(44832011)(486006)(8676002)(86362001)(2906002)(7416002)(5660300001)(110136005)(3660700001)(68736007)(3280700002)(66066001)(14454004)(476003)(4326008)(2201001)(54906003)(39060400002)(7736002)(81166006)(81156014);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0401MB2315;H:HE1PR0401MB2425.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-microsoft-antispam-message-info: nuh3ndufV6N2YVEL25ZbdaPne38g1nRXDQfz+smUM6ZLtCOP84XlCSQLQwlWzveMDxgg8zET1ozs+FlZ6lrSInbxTrniwmjqWypVQfkmsNVoQtH1anXNCvt7UcRPiwZ0Es1CavJy7NbIYLB4ZnXD9mTwWT+2Gbr31reJF/YsO5bHBgyiNbKI/EoO35ZLub4B spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 74650504-199c-447c-a812-08d5bb09dcda X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74650504-199c-447c-a812-08d5bb09dcda X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2018 08:48:57.5022 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2315 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w4G8nEom021426 > -----Original Message----- > From: Laurentiu Tudor > Sent: Monday, May 14, 2018 7:10 PM > To: Nipun Gupta ; robin.murphy@arm.com; > will.deacon@arm.com; mark.rutland@arm.com; catalin.marinas@arm.com > Cc: hch@lst.de; gregkh@linuxfoundation.org; joro@8bytes.org; > robh+dt@kernel.org; m.szyprowski@samsung.com; shawnguo@kernel.org; > frowand.list@gmail.com; bhelgaas@google.com; iommu@lists.linux- > foundation.org; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linuxppc-dev@lists.ozlabs.org; linux- > pci@vger.kernel.org; Bharat Bhushan ; > stuyoder@gmail.com; Leo Li > Subject: Re: [PATCH 5/6 v3] bus: fsl-mc: supoprt dma configure for devices > on fsl-mc bus > > Hi Nipun, > > On 04/27/2018 01:27 PM, Nipun Gupta wrote: > > Signed-off-by: Nipun Gupta > > --- > > drivers/bus/fsl-mc/fsl-mc-bus.c | 16 ++++++++++++---- > > 1 file changed, 12 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc- > bus.c > > index 5d8266c..624828b 100644 > > --- a/drivers/bus/fsl-mc/fsl-mc-bus.c > > +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c > > @@ -127,6 +127,16 @@ static int fsl_mc_bus_uevent(struct device *dev, > struct kobj_uevent_env *env) > > return 0; > > } > > > > +static int fsl_mc_dma_configure(struct device *dev) > > +{ > > + struct device *dma_dev = dev; > > + > > + while (dev_is_fsl_mc(dma_dev)) > > + dma_dev = dma_dev->parent; > > + > > + return of_dma_configure(dev, dma_dev->of_node, 0); > > +} > > + > > static ssize_t modalias_show(struct device *dev, struct device_attribute > *attr, > > char *buf) > > { > > @@ -148,6 +158,7 @@ struct bus_type fsl_mc_bus_type = { > > .name = "fsl-mc", > > .match = fsl_mc_bus_match, > > .uevent = fsl_mc_bus_uevent, > > + .dma_configure = fsl_mc_dma_configure, > > .dev_groups = fsl_mc_dev_groups, > > }; > > EXPORT_SYMBOL_GPL(fsl_mc_bus_type); > > @@ -616,6 +627,7 @@ int fsl_mc_device_add(struct fsl_mc_obj_desc > *obj_desc, > > mc_dev->icid = parent_mc_dev->icid; > > mc_dev->dma_mask = FSL_MC_DEFAULT_DMA_MASK; > > mc_dev->dev.dma_mask = &mc_dev->dma_mask; > > + mc_dev->dev.coherent_dma_mask = mc_dev->dma_mask; > > This change seems a bit unrelated to the patch subject. I wonder if it > makes sense to split it it in a distinct patch. Okay. I will spin a v5 after splitting this patch and adding changelog (Greg's comment), fixing typo (Bjorn's comment). Regards, Nipun > > --- > Best Regards, Laurentiu From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nipun Gupta Subject: RE: [PATCH 5/6 v3] bus: fsl-mc: supoprt dma configure for devices on fsl-mc bus Date: Wed, 16 May 2018 08:48:57 +0000 Message-ID: References: <1524824826-29473-1-git-send-email-nipun.gupta@nxp.com> <1524824826-29473-6-git-send-email-nipun.gupta@nxp.com> <5AF9916E.8000504@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5AF9916E.8000504-3arQi8VN3Tc@public.gmane.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Laurentiu Tudor , "robin.murphy-5wv7dgnIgG8@public.gmane.org" , "will.deacon-5wv7dgnIgG8@public.gmane.org" , "mark.rutland-5wv7dgnIgG8@public.gmane.org" , "catalin.marinas-5wv7dgnIgG8@public.gmane.org" Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "stuyoder-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org" , "linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Leo Li , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org" , "shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "hch-jcswGhMUV9g@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org > -----Original Message----- > From: Laurentiu Tudor > Sent: Monday, May 14, 2018 7:10 PM > To: Nipun Gupta ; robin.murphy-5wv7dgnIgG8@public.gmane.org; > will.deacon-5wv7dgnIgG8@public.gmane.org; mark.rutland-5wv7dgnIgG8@public.gmane.org; catalin.marinas-5wv7dgnIgG8@public.gmane.org > Cc: hch-jcswGhMUV9g@public.gmane.org; gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org; joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org; > robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org; shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; > frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org; iommu-cunTk1MwBs/ROKNJybVBZg@public.gmane.org > foundation.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; linux- > pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Bharat Bhushan ; > stuyoder-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; Leo Li > Subject: Re: [PATCH 5/6 v3] bus: fsl-mc: supoprt dma configure for devices > on fsl-mc bus > > Hi Nipun, > > On 04/27/2018 01:27 PM, Nipun Gupta wrote: > > Signed-off-by: Nipun Gupta > > --- > > drivers/bus/fsl-mc/fsl-mc-bus.c | 16 ++++++++++++---- > > 1 file changed, 12 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc- > bus.c > > index 5d8266c..624828b 100644 > > --- a/drivers/bus/fsl-mc/fsl-mc-bus.c > > +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c > > @@ -127,6 +127,16 @@ static int fsl_mc_bus_uevent(struct device *dev, > struct kobj_uevent_env *env) > > return 0; > > } > > > > +static int fsl_mc_dma_configure(struct device *dev) > > +{ > > + struct device *dma_dev = dev; > > + > > + while (dev_is_fsl_mc(dma_dev)) > > + dma_dev = dma_dev->parent; > > + > > + return of_dma_configure(dev, dma_dev->of_node, 0); > > +} > > + > > static ssize_t modalias_show(struct device *dev, struct device_attribute > *attr, > > char *buf) > > { > > @@ -148,6 +158,7 @@ struct bus_type fsl_mc_bus_type = { > > .name = "fsl-mc", > > .match = fsl_mc_bus_match, > > .uevent = fsl_mc_bus_uevent, > > + .dma_configure = fsl_mc_dma_configure, > > .dev_groups = fsl_mc_dev_groups, > > }; > > EXPORT_SYMBOL_GPL(fsl_mc_bus_type); > > @@ -616,6 +627,7 @@ int fsl_mc_device_add(struct fsl_mc_obj_desc > *obj_desc, > > mc_dev->icid = parent_mc_dev->icid; > > mc_dev->dma_mask = FSL_MC_DEFAULT_DMA_MASK; > > mc_dev->dev.dma_mask = &mc_dev->dma_mask; > > + mc_dev->dev.coherent_dma_mask = mc_dev->dma_mask; > > This change seems a bit unrelated to the patch subject. I wonder if it > makes sense to split it it in a distinct patch. Okay. I will spin a v5 after splitting this patch and adding changelog (Greg's comment), fixing typo (Bjorn's comment). Regards, Nipun > > --- > Best Regards, Laurentiu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: Nipun Gupta To: Laurentiu Tudor , "robin.murphy@arm.com" , "will.deacon@arm.com" , "mark.rutland@arm.com" , "catalin.marinas@arm.com" Subject: RE: [PATCH 5/6 v3] bus: fsl-mc: supoprt dma configure for devices on fsl-mc bus Date: Wed, 16 May 2018 08:48:57 +0000 Message-ID: References: <1524824826-29473-1-git-send-email-nipun.gupta@nxp.com> <1524824826-29473-6-git-send-email-nipun.gupta@nxp.com> <5AF9916E.8000504@nxp.com> In-Reply-To: <5AF9916E.8000504@nxp.com> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Bharat Bhushan , "stuyoder@gmail.com" , "frowand.list@gmail.com" , "gregkh@linuxfoundation.org" , "joro@8bytes.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Leo Li , "iommu@lists.linux-foundation.org" , "robh+dt@kernel.org" , "linux-pci@vger.kernel.org" , "bhelgaas@google.com" , "shawnguo@kernel.org" , "hch@lst.de" , "linux-arm-kernel@lists.infradead.org" , "m.szyprowski@samsung.com" Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: > -----Original Message----- > From: Laurentiu Tudor > Sent: Monday, May 14, 2018 7:10 PM > To: Nipun Gupta ; robin.murphy@arm.com; > will.deacon@arm.com; mark.rutland@arm.com; catalin.marinas@arm.com > Cc: hch@lst.de; gregkh@linuxfoundation.org; joro@8bytes.org; > robh+dt@kernel.org; m.szyprowski@samsung.com; shawnguo@kernel.org; > frowand.list@gmail.com; bhelgaas@google.com; iommu@lists.linux- > foundation.org; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linuxppc-dev@lists.ozlabs.org; linux- > pci@vger.kernel.org; Bharat Bhushan ; > stuyoder@gmail.com; Leo Li > Subject: Re: [PATCH 5/6 v3] bus: fsl-mc: supoprt dma configure for devices > on fsl-mc bus > > Hi Nipun, > > On 04/27/2018 01:27 PM, Nipun Gupta wrote: > > Signed-off-by: Nipun Gupta > > --- > > drivers/bus/fsl-mc/fsl-mc-bus.c | 16 ++++++++++++---- > > 1 file changed, 12 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc- > bus.c > > index 5d8266c..624828b 100644 > > --- a/drivers/bus/fsl-mc/fsl-mc-bus.c > > +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c > > @@ -127,6 +127,16 @@ static int fsl_mc_bus_uevent(struct device *dev, > struct kobj_uevent_env *env) > > return 0; > > } > > > > +static int fsl_mc_dma_configure(struct device *dev) > > +{ > > + struct device *dma_dev = dev; > > + > > + while (dev_is_fsl_mc(dma_dev)) > > + dma_dev = dma_dev->parent; > > + > > + return of_dma_configure(dev, dma_dev->of_node, 0); > > +} > > + > > static ssize_t modalias_show(struct device *dev, struct device_attribute > *attr, > > char *buf) > > { > > @@ -148,6 +158,7 @@ struct bus_type fsl_mc_bus_type = { > > .name = "fsl-mc", > > .match = fsl_mc_bus_match, > > .uevent = fsl_mc_bus_uevent, > > + .dma_configure = fsl_mc_dma_configure, > > .dev_groups = fsl_mc_dev_groups, > > }; > > EXPORT_SYMBOL_GPL(fsl_mc_bus_type); > > @@ -616,6 +627,7 @@ int fsl_mc_device_add(struct fsl_mc_obj_desc > *obj_desc, > > mc_dev->icid = parent_mc_dev->icid; > > mc_dev->dma_mask = FSL_MC_DEFAULT_DMA_MASK; > > mc_dev->dev.dma_mask = &mc_dev->dma_mask; > > + mc_dev->dev.coherent_dma_mask = mc_dev->dma_mask; > > This change seems a bit unrelated to the patch subject. I wonder if it > makes sense to split it it in a distinct patch. Okay. I will spin a v5 after splitting this patch and adding changelog (Greg's comment), fixing typo (Bjorn's comment). Regards, Nipun > > --- > Best Regards, Laurentiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0089.outbound.protection.outlook.com [104.47.1.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40m7QX1pSbzF14s for ; Wed, 16 May 2018 18:49:05 +1000 (AEST) From: Nipun Gupta To: Laurentiu Tudor , "robin.murphy@arm.com" , "will.deacon@arm.com" , "mark.rutland@arm.com" , "catalin.marinas@arm.com" CC: "hch@lst.de" , "gregkh@linuxfoundation.org" , "joro@8bytes.org" , "robh+dt@kernel.org" , "m.szyprowski@samsung.com" , "shawnguo@kernel.org" , "frowand.list@gmail.com" , "bhelgaas@google.com" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-pci@vger.kernel.org" , Bharat Bhushan , "stuyoder@gmail.com" , Leo Li Subject: RE: [PATCH 5/6 v3] bus: fsl-mc: supoprt dma configure for devices on fsl-mc bus Date: Wed, 16 May 2018 08:48:57 +0000 Message-ID: References: <1524824826-29473-1-git-send-email-nipun.gupta@nxp.com> <1524824826-29473-6-git-send-email-nipun.gupta@nxp.com> <5AF9916E.8000504@nxp.com> In-Reply-To: <5AF9916E.8000504@nxp.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > -----Original Message----- > From: Laurentiu Tudor > Sent: Monday, May 14, 2018 7:10 PM > To: Nipun Gupta ; robin.murphy@arm.com; > will.deacon@arm.com; mark.rutland@arm.com; catalin.marinas@arm.com > Cc: hch@lst.de; gregkh@linuxfoundation.org; joro@8bytes.org; > robh+dt@kernel.org; m.szyprowski@samsung.com; shawnguo@kernel.org; > frowand.list@gmail.com; bhelgaas@google.com; iommu@lists.linux- > foundation.org; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linuxppc-dev@lists.ozlabs.org; linu= x- > pci@vger.kernel.org; Bharat Bhushan ; > stuyoder@gmail.com; Leo Li > Subject: Re: [PATCH 5/6 v3] bus: fsl-mc: supoprt dma configure for device= s > on fsl-mc bus >=20 > Hi Nipun, >=20 > On 04/27/2018 01:27 PM, Nipun Gupta wrote: > > Signed-off-by: Nipun Gupta > > --- > > drivers/bus/fsl-mc/fsl-mc-bus.c | 16 ++++++++++++---- > > 1 file changed, 12 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-m= c- > bus.c > > index 5d8266c..624828b 100644 > > --- a/drivers/bus/fsl-mc/fsl-mc-bus.c > > +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c > > @@ -127,6 +127,16 @@ static int fsl_mc_bus_uevent(struct device *dev, > struct kobj_uevent_env *env) > > return 0; > > } > > > > +static int fsl_mc_dma_configure(struct device *dev) > > +{ > > + struct device *dma_dev =3D dev; > > + > > + while (dev_is_fsl_mc(dma_dev)) > > + dma_dev =3D dma_dev->parent; > > + > > + return of_dma_configure(dev, dma_dev->of_node, 0); > > +} > > + > > static ssize_t modalias_show(struct device *dev, struct device_attrib= ute > *attr, > > char *buf) > > { > > @@ -148,6 +158,7 @@ struct bus_type fsl_mc_bus_type =3D { > > .name =3D "fsl-mc", > > .match =3D fsl_mc_bus_match, > > .uevent =3D fsl_mc_bus_uevent, > > + .dma_configure =3D fsl_mc_dma_configure, > > .dev_groups =3D fsl_mc_dev_groups, > > }; > > EXPORT_SYMBOL_GPL(fsl_mc_bus_type); > > @@ -616,6 +627,7 @@ int fsl_mc_device_add(struct fsl_mc_obj_desc > *obj_desc, > > mc_dev->icid =3D parent_mc_dev->icid; > > mc_dev->dma_mask =3D FSL_MC_DEFAULT_DMA_MASK; > > mc_dev->dev.dma_mask =3D &mc_dev->dma_mask; > > + mc_dev->dev.coherent_dma_mask =3D mc_dev->dma_mask; >=20 > This change seems a bit unrelated to the patch subject. I wonder if it > makes sense to split it it in a distinct patch. Okay. I will spin a v5 after splitting this patch and adding changelog (Gre= g's comment), fixing typo (Bjorn's comment). Regards, Nipun >=20 > --- > Best Regards, Laurentiu From mboxrd@z Thu Jan 1 00:00:00 1970 From: nipun.gupta@nxp.com (Nipun Gupta) Date: Wed, 16 May 2018 08:48:57 +0000 Subject: [PATCH 5/6 v3] bus: fsl-mc: supoprt dma configure for devices on fsl-mc bus In-Reply-To: <5AF9916E.8000504@nxp.com> References: <1524824826-29473-1-git-send-email-nipun.gupta@nxp.com> <1524824826-29473-6-git-send-email-nipun.gupta@nxp.com> <5AF9916E.8000504@nxp.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > -----Original Message----- > From: Laurentiu Tudor > Sent: Monday, May 14, 2018 7:10 PM > To: Nipun Gupta ; robin.murphy at arm.com; > will.deacon at arm.com; mark.rutland at arm.com; catalin.marinas at arm.com > Cc: hch at lst.de; gregkh at linuxfoundation.org; joro at 8bytes.org; > robh+dt at kernel.org; m.szyprowski at samsung.com; shawnguo at kernel.org; > frowand.list at gmail.com; bhelgaas at google.com; iommu at lists.linux- > foundation.org; linux-kernel at vger.kernel.org; devicetree at vger.kernel.org; > linux-arm-kernel at lists.infradead.org; linuxppc-dev at lists.ozlabs.org; linux- > pci at vger.kernel.org; Bharat Bhushan ; > stuyoder at gmail.com; Leo Li > Subject: Re: [PATCH 5/6 v3] bus: fsl-mc: supoprt dma configure for devices > on fsl-mc bus > > Hi Nipun, > > On 04/27/2018 01:27 PM, Nipun Gupta wrote: > > Signed-off-by: Nipun Gupta > > --- > > drivers/bus/fsl-mc/fsl-mc-bus.c | 16 ++++++++++++---- > > 1 file changed, 12 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c b/drivers/bus/fsl-mc/fsl-mc- > bus.c > > index 5d8266c..624828b 100644 > > --- a/drivers/bus/fsl-mc/fsl-mc-bus.c > > +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c > > @@ -127,6 +127,16 @@ static int fsl_mc_bus_uevent(struct device *dev, > struct kobj_uevent_env *env) > > return 0; > > } > > > > +static int fsl_mc_dma_configure(struct device *dev) > > +{ > > + struct device *dma_dev = dev; > > + > > + while (dev_is_fsl_mc(dma_dev)) > > + dma_dev = dma_dev->parent; > > + > > + return of_dma_configure(dev, dma_dev->of_node, 0); > > +} > > + > > static ssize_t modalias_show(struct device *dev, struct device_attribute > *attr, > > char *buf) > > { > > @@ -148,6 +158,7 @@ struct bus_type fsl_mc_bus_type = { > > .name = "fsl-mc", > > .match = fsl_mc_bus_match, > > .uevent = fsl_mc_bus_uevent, > > + .dma_configure = fsl_mc_dma_configure, > > .dev_groups = fsl_mc_dev_groups, > > }; > > EXPORT_SYMBOL_GPL(fsl_mc_bus_type); > > @@ -616,6 +627,7 @@ int fsl_mc_device_add(struct fsl_mc_obj_desc > *obj_desc, > > mc_dev->icid = parent_mc_dev->icid; > > mc_dev->dma_mask = FSL_MC_DEFAULT_DMA_MASK; > > mc_dev->dev.dma_mask = &mc_dev->dma_mask; > > + mc_dev->dev.coherent_dma_mask = mc_dev->dma_mask; > > This change seems a bit unrelated to the patch subject. I wonder if it > makes sense to split it it in a distinct patch. Okay. I will spin a v5 after splitting this patch and adding changelog (Greg's comment), fixing typo (Bjorn's comment). Regards, Nipun > > --- > Best Regards, Laurentiu