From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v2 5/9] raw/dpaa2_cmdif: introduce DPAA2
 command interface driver
Date: Wed, 25 Apr 2018 04:18:00 +0000
Message-ID: <HE1PR0402MB27808882391FEF2E5613C4F3908F0@HE1PR0402MB2780.eurprd04.prod.outlook.com>
References: <1519292089-13851-1-git-send-email-nipun.gupta@nxp.com>
 <1523111645-8076-1-git-send-email-nipun.gupta@nxp.com>
 <1523111645-8076-6-git-send-email-nipun.gupta@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "thomas@monjalon.net"
 <thomas@monjalon.net>, Hemant Agrawal <hemant.agrawal@nxp.com>
To: Nipun Gupta <nipun.gupta@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR03-AM5-obe.outbound.protection.outlook.com
 (mail-eopbgr30054.outbound.protection.outlook.com [40.107.3.54])
 by dpdk.org (Postfix) with ESMTP id D685B374
 for <dev@dpdk.org>; Wed, 25 Apr 2018 06:18:22 +0200 (CEST)
In-Reply-To: <1523111645-8076-6-git-send-email-nipun.gupta@nxp.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Nipun Gupta
> Sent: Saturday, April 7, 2018 8:04 PM
> To: thomas@monjalon.net; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Shreyansh Jain <shreyansh.jain@nxp.com>
> Cc: dev@dpdk.org; Nipun Gupta <nipun.gupta@nxp.com>
> Subject: [PATCH v2 5/9] raw/dpaa2_cmdif: introduce DPAA2 command
> interface driver
>=20
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> ---
>  MAINTAINERS                                        |   8 ++
>  config/common_base                                 |   1 +
>  config/common_linuxapp                             |   1 +
>  drivers/raw/Makefile                               |   3 +
>  drivers/raw/dpaa2_cmdif/Makefile                   |  33 +++++
>  drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c              | 139
> +++++++++++++++++++++
>  drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h         |  35 ++++++
>  .../dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map    |   4 +
>  mk/rte.app.mk                                      |   1 +
>  9 files changed, 225 insertions(+)
>  create mode 100644 drivers/raw/dpaa2_cmdif/Makefile
>  create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c
>  create mode 100644 drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h
>  create mode 100644
> drivers/raw/dpaa2_cmdif/rte_pmd_dpaa2_cmdif_version.map
>=20

[...]

> diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h
> b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h
> new file mode 100644
> index 0000000..5eb0885
> --- /dev/null
> +++ b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif_logs.h
> @@ -0,0 +1,35 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright 2018 NXP
> + */
> +
> +#ifndef __DPAA2_CMDIF_LOGS_H__
> +#define __DPAA2_CMDIF_LOGS_H__
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +#include <rte_rawdev.h>
> +
> +extern int dpaa2_cmdif_logtype;
> +
> +#define DPAA2_CMDIF_LOG(level, fmt, args...) \
> +	rte_log(RTE_LOG_ ## level, dpaa2_cmdif_logtype, "%s(): " fmt "\n",
> \
> +		__func__, ##args)

Trivial comment: Would it be better to have two variants - one which prints=
 the function names and which doesn't. ERR/WARNING with function name shoul=
d be avoided.

> +
> +#define DPAA2_CMDIF_FUNC_TRACE() DPAA2_CMDIF_LOG(DEBUG, ">>")
> +
> +#define DPAA2_CMDIF_DEBUG(fmt, args...) \
> +	DPAA2_CMDIF_LOG(DEBUG, fmt, ## args)
> +#define DPAA2_CMDIF_INFO(fmt, args...) \
> +	DPAA2_CMDIF_LOG(INFO, fmt, ## args)
> +#define DPAA2_CMDIF_ERR(fmt, args...) \
> +	DPAA2_CMDIF_LOG(ERR, fmt, ## args)
> +#define DPAA2_CMDIF_WARN(fmt, args...) \
> +	DPAA2_CMDIF_LOG(WARNING, fmt, ## args)
> +
> +#ifdef __cplusplus
> +}
> +#endif
> +
> +#endif /* __DPAA2_CMDIF_LOGS_H__ */

[...]