All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen@nxp.com>
To: Mark Brown <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/1] regulator: fixed: add suspend pm routines for pinctrl
Date: Fri, 20 Jan 2017 08:11:01 +0000	[thread overview]
Message-ID: <HE1PR04MB14501D8DEB385F018D48E5E38B710@HE1PR04MB1450.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 20170103111459.ezab3iavnbvzh2hc@sirena.org.uk

 
>
>>>On Tue, Jan 03, 2017 at 05:02:47PM +0800, Peter Chen wrote:
>>>> At some systems, the pinctrl setting will be lost or needs to set as
>>>> "sleep" state to save power consumption. So, we need to configure
>>>> pinctrl as "sleep" state when system enters suspend, and as "default"
>>>> state after system resumes. In this way, the pinctrl value can be
>>>> recovered as "default" state after resuming.
>>>
>>>I thought this was supposed to be done automatically by the driver core?
>>>If not it should be, every single driver is likely to end up with that.
>>
>>Good idea, I will send a patch for that.
>>
>
>After checking more, it is not suitable for driver core do it since different driver has
>different usage for "sleep" pinctrl. Below are some examples:
>
>- Some drivers set "idle" for pinctrl when system goes to suspend
>- Some drivers has some conditions for setting "sleep" for pinctrl
>eg: drivers/net/ethernet/freescale/fec_main.c
>- Some drivers may set "sleep" for pinctrl as ->close interface, but not system
>suspend interface
>- Some drivers can be woken up for "sleep" pinctrl, some may not.
>

Hi Mark,

Any more comment for this patch?
Thanks.

Peter

  parent reply	other threads:[~2017-01-20  8:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-03  9:02 [PATCH 1/1] regulator: fixed: add suspend pm routines for pinctrl Peter Chen
2017-01-03 11:14 ` Mark Brown
2017-01-04  6:51   ` Peter Chen
2017-01-04  7:05   ` Peter Chen
2017-01-20  8:11   ` Peter Chen [this message]
2017-01-03 14:34 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=HE1PR04MB14501D8DEB385F018D48E5E38B710@HE1PR04MB1450.eurprd04.prod.outlook.com \
    --to=peter.chen@nxp.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.