From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933157AbcBDIBM (ORCPT ); Thu, 4 Feb 2016 03:01:12 -0500 Received: from mail-db3on0077.outbound.protection.outlook.com ([157.55.234.77]:21789 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753152AbcBDIBK convert rfc822-to-8bit (ORCPT ); Thu, 4 Feb 2016 03:01:10 -0500 X-Greylist: delayed 5548 seconds by postgrey-1.27 at vger.kernel.org; Thu, 04 Feb 2016 03:01:09 EST From: Peter Chen To: Olivier Blin , Lubomir Rintel CC: "linux-rpi-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Arnd Bergmann , "linux-kernel@vger.kernel.org" , Peter Chen Subject: RE: [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree Thread-Topic: [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree Thread-Index: AQHRXpQEhp2zv40E80mVosfK7IHW1p8a+8PqgABuwNA= Date: Thu, 4 Feb 2016 06:28:38 +0000 Message-ID: References: <1454511759-24827-1-git-send-email-lkundrak@v3.sk> <1454511759-24827-3-git-send-email-lkundrak@v3.sk> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: blino.org; dkim=none (message not signed) header.d=none;blino.org; dmarc=none action=none header.from=nxp.com; x-originating-ip: [123.151.195.52] x-microsoft-exchange-diagnostics: 1;HE1PR04MB1451;5:ekoJGd5MRCboQm/FxyTO/4MV5T1yabeApAy/TeEYqkynD2fEcSwAqRc4SBe51v4EZXdvIiVC0zkHju4/RP5GoU3u3dOQd38yxpcHVLkvkGQsQqHiXPFOLflgc4rB902VsvLiDK8Ne/oo+Rl5iJnphA==;24:+NAkL6rYQbj/UbAnHAb/lflLOnWJiukcjaxdhFiOv2XMUSywJCFFDm5c7JbtKHCrehpvhidZn4M5fA2CCVpD+4vhhtbO4+fKF1A3SRvWDXE= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR04MB1451; x-ms-office365-filtering-correlation-id: 19f8a635-d80e-436c-8555-08d32d2c6b2a x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:HE1PR04MB1451;BCL:0;PCL:0;RULEID:;SRVR:HE1PR04MB1451; x-forefront-prvs: 084285FC5C x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(5001770100001)(4326007)(66066001)(2906002)(5004730100002)(92566002)(54356999)(106116001)(87936001)(76576001)(19580395003)(19580405001)(50986999)(189998001)(122556002)(1220700001)(2900100001)(86362001)(1096002)(76176999)(5001960100002)(33656002)(3846002)(5003600100002)(2950100001)(586003)(10400500002)(102836003)(6116002)(77096005)(74316001)(5008740100001)(5002640100001)(40100003)(3660700001)(3280700002)(11100500001)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR04MB1451;H:HE1PR04MB1450.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2016 06:28:38.6944 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB1451 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Lubomir Rintel writes: > > > diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > index ef54050..32bbd2a 100644 > > --- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > +++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > Hi, > > Shouldn't this be common to all RPi1 B and RPi2 models, instead of being > specific to just RPi B+? > > > +&usb { > > + usb1@01 { > > + compatible = "usb1d6b,0002"; > > + reg = <01>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + ethernet: usbether@01 { > > + compatible = "usb0424,9514"; > > + reg = <01>; > > + }; > > + }; > > +}; > > For reference, on RPi2: Using "lsusb -t" you may get bus topology. > Bus 001 Device 003: ID 0424:ec00 Standard Microsystems Corp. SMSC9512/9514 Fast Ethernet Adapter It is the ethernet device, you may need to change vid/pid in dts. > Bus 001 Device 002: ID 0424:9514 Standard Microsystems Corp. SMC9514 Hub It is the hub device, you may need to change vid/pid in dts. > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub > It is root hub, it doesn't need to be described at dts. Best regards, Peter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: RE: [PATCH 2/2] ARM: bcm2835: dt: Add the ethernet to the device tree Date: Thu, 4 Feb 2016 06:28:38 +0000 Message-ID: References: <1454511759-24827-1-git-send-email-lkundrak@v3.sk> <1454511759-24827-3-git-send-email-lkundrak@v3.sk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Olivier Blin , Lubomir Rintel Cc: "linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Arnd Bergmann , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Peter Chen List-Id: devicetree@vger.kernel.org > Lubomir Rintel writes: > > > diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > index ef54050..32bbd2a 100644 > > --- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > +++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts > > Hi, > > Shouldn't this be common to all RPi1 B and RPi2 models, instead of being > specific to just RPi B+? > > > +&usb { > > + usb1@01 { > > + compatible = "usb1d6b,0002"; > > + reg = <01>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + ethernet: usbether@01 { > > + compatible = "usb0424,9514"; > > + reg = <01>; > > + }; > > + }; > > +}; > > For reference, on RPi2: Using "lsusb -t" you may get bus topology. > Bus 001 Device 003: ID 0424:ec00 Standard Microsystems Corp. SMSC9512/9514 Fast Ethernet Adapter It is the ethernet device, you may need to change vid/pid in dts. > Bus 001 Device 002: ID 0424:9514 Standard Microsystems Corp. SMC9514 Hub It is the hub device, you may need to change vid/pid in dts. > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub > It is root hub, it doesn't need to be described at dts. Best regards, Peter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html