From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756164AbdADGvf (ORCPT ); Wed, 4 Jan 2017 01:51:35 -0500 Received: from mail-ve1eur01on0082.outbound.protection.outlook.com ([104.47.1.82]:28281 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755838AbdADGvd (ORCPT ); Wed, 4 Jan 2017 01:51:33 -0500 From: Peter Chen To: Mark Brown CC: "lgirdwood@gmail.com" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 1/1] regulator: fixed: add suspend pm routines for pinctrl Thread-Topic: [PATCH 1/1] regulator: fixed: add suspend pm routines for pinctrl Thread-Index: AQHSZaAON5ZY9J00OEeloVrcIiUgCKEmmf2AgAFG8MA= Date: Wed, 4 Jan 2017 06:51:30 +0000 Message-ID: References: <1483434167-10778-1-git-send-email-peter.chen@nxp.com> <20170103111459.ezab3iavnbvzh2hc@sirena.org.uk> In-Reply-To: <20170103111459.ezab3iavnbvzh2hc@sirena.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=peter.chen@nxp.com; x-originating-ip: [199.59.226.141] x-ms-office365-filtering-correlation-id: 53437e28-c305-42e6-443e-08d4346e1cec x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:HE1PR04MB1452; x-microsoft-exchange-diagnostics: 1;HE1PR04MB1452;7:C/cPOkF4NDi4kwIxmjVQo7cMHKm1h1h7oVQchwuvuoXpbZOp6SvDgEZydGXi35XC8ohoJowsYW8haHOBNcohq947q2xqo3l5GfQ2WsUYgaZAlXxd3W7Jc7LepCh4rWWfJnCvErfn6CrrNW8n+TG6kr8aKv2nAzIIIH++vt5fcT/gDaBUi3QglA6w0mjLwRXbv89C/FQRxnJlnxXsKlTbs7Q3kmDi7QU4/auSrY8cjmudGelD5JddO8KJt9ixpgen1+Idmoya0kXLZdqNhYV9mFuKYWogsb59e7fg1Hey4t4eSVI2HlvHWIK2k7QeolNDvmuuJ4DFNuIL1rlkfEDIMyP2AxyjdrDR6MMRQl8cSKmYH71TNMg1flKihzoOdID6OrksjyFyYURFvZD2LAMcdWH0VeUDfZHKwx41Aa5/SWRKBt2P/RmfJRsG1GdcW3D67sTvkfLuY49mrha/+eOR3Q== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123560025)(20161123564025)(20161123555025)(6047074)(6072148);SRVR:HE1PR04MB1452;BCL:0;PCL:0;RULEID:;SRVR:HE1PR04MB1452; x-forefront-prvs: 0177904E6B x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7916002)(39410400002)(39450400003)(39850400002)(39840400002)(39860400002)(199003)(189002)(24454002)(15650500001)(2900100001)(38730400001)(8676002)(86362001)(76176999)(54356999)(97736004)(2950100002)(122556002)(50986999)(5660300001)(8936002)(7696004)(110136003)(101416001)(6916009)(25786008)(92566002)(54906002)(55016002)(6436002)(7736002)(68736007)(77096006)(105586002)(106116001)(33656002)(99286003)(9686002)(66066001)(106356001)(81166006)(81156014)(3846002)(305945005)(102836003)(3660700001)(189998001)(39060400001)(2906002)(3280700002)(74316002)(6116002)(4326007)(6506006)(229853002)(129583001);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR04MB1452;H:HE1PR04MB1450.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2017 06:51:30.1324 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB1452 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v046pee1004008 >On Tue, Jan 03, 2017 at 05:02:47PM +0800, Peter Chen wrote: >> At some systems, the pinctrl setting will be lost or needs to set as >> "sleep" state to save power consumption. So, we need to configure >> pinctrl as "sleep" state when system enters suspend, and as "default" >> state after system resumes. In this way, the pinctrl value can be >> recovered as "default" state after resuming. > >I thought this was supposed to be done automatically by the driver core? >If not it should be, every single driver is likely to end up with that. Good idea, I will send a patch for that. Peter