From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ophir Munk <ophirmu@mellanox.com>
Subject: Re: [PATCH v1] gso: fix marking TCP checksum flag in TCP
	segments
Date: Tue, 24 Apr 2018 13:53:22 +0000
Message-ID: <HE1PR0501MB23148CC8B520D185BF5749B1D1880@HE1PR0501MB2314.eurprd05.prod.outlook.com>
References: <1524406859-29585-1-git-send-email-ophirmu@mellanox.com>
 <ED946F0BEFE0A141B63BABBD629A2A9B388B3D55@shsmsx102.ccr.corp.intel.com>
 <HE1PR0501MB23140AD5F8652DA56AD1F8BAD1880@HE1PR0501MB2314.eurprd05.prod.outlook.com>
 <2601191342CEEE43887BDE71AB977258AEA5081C@IRSMSX102.ger.corp.intel.com>
 <HE1PR0501MB231427BE92F6DB100738D098D1880@HE1PR0501MB2314.eurprd05.prod.outlook.com>
 <2601191342CEEE43887BDE71AB977258AEA5221E@IRSMSX102.ger.corp.intel.com>
 <ED946F0BEFE0A141B63BABBD629A2A9B388B5640@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: Thomas Monjalon <thomas@monjalon.net>, Olga Shern <olgas@mellanox.com>,
 Pascal Mazon <pascal.mazon@6wind.com>, "stable@dpdk.org" <stable@dpdk.org>
To: "Hu, Jiayu" <jiayu.hu@intel.com>, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <ED946F0BEFE0A141B63BABBD629A2A9B388B5640@shsmsx102.ccr.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Jiayu,

> -----Original Message-----
> From: Hu, Jiayu [mailto:jiayu.hu@intel.com]
> Sent: Tuesday, April 24, 2018 3:56 PM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Ophir Munk
> <ophirmu@mellanox.com>; dev@dpdk.org
> Cc: Thomas Monjalon <thomas@monjalon.net>; Olga Shern
> <olgas@mellanox.com>; Pascal Mazon <pascal.mazon@6wind.com>;
> stable@dpdk.org
> Subject: RE: [PATCH v1] gso: fix marking TCP checksum flag in TCP segment=
s
>=20
> Hi Konstantin and Ophir,
>=20
...=20
> > Another possibility - might be make chages in librte_gso to allow user
> > to specify what flags to set for the output packets (probably via
> > rte_gso_ctx.flag)
>=20
> It would be a solution. We can add flags to rte_gso_ctx.flag and the GSO
> library can do some extra work (like checksum) according to the flags.
>=20

I think that calculating TCP checksums by GSO library should be optional (i=
f at all).=20
In my case I prefer TAP PMD to do the work which is TAP-specific. =20
My original intention in this patch was only to mark PKT_TX_TCP_CKSUM flag.

> Thanks,
> Jiayu
> >
> > Konstantin
> >
...