From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E468AC10F14 for ; Tue, 8 Oct 2019 06:32:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C448F218AC for ; Tue, 8 Oct 2019 06:32:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730057AbfJHGcV (ORCPT ); Tue, 8 Oct 2019 02:32:21 -0400 Received: from mail-oln040092065019.outbound.protection.outlook.com ([40.92.65.19]:47141 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729693AbfJHGcU (ORCPT ); Tue, 8 Oct 2019 02:32:20 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pe9w1z2MReSrkD3k+eVAbiVsRmD5RmFQmLVqxu9rug0JdxwJa9dMD+4BvpMBA9n5fSyDIQv7RdeNtZWQa+dJJtm9+WNJwxH1NoUQ6AeDcSJOFu3GXaKvH3YtkCDHpNXW6F/mkxKp1gIc77KV4ZelV6IedVEgDqrwE+/1w0MlE6unbk28vWO4OE5c+lV6pJYy2ON/CkDRoeNpnDVNZrRxkj2fF/+2vvJHcIHM6WaZ3BEY3sHbig28fsP9Cmevj4dmH4s+9v9WOl7Wxo/JysfyspJRRN6D+2pABvwXG6a3Z+qFFLAH5HIswWzEPf6LUMWS0FJQdj4537eBeiZtaMCjQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6gqdEB80K9SoY3kDFPxpeKqjNS4mjj8KPbgJPb7lotU=; b=m9bejfKdpqUegC7XqcBZfLrs+rp7jGDzirjd2TZpOCcwIw+UYAYqe0uJdb4n3cWzGgDwYkvBb+6P/O9CofG1YiOBn6fXmmNsL5LGbQS4+TH1K1KakZOfrgG+uX/ClNmH+tBYHvZy36PgN0lgBwkWkWHcBLTX/Dnjzj9bgDEVwOk5IZpz7ISMBee+q2u3bN1X8aAD2xkPCxSojOj5PSx9ERMAf6jZo9pK7rQVXd4lKLfseX/2vRaAiAWQ7QzQ4suUz6nolcKzT/y1PpVqHvDtDdtLjrJExM06iq8L14rQc7Z1UB6l53XDC48L8LqEA/ZQv13OigloielH+GlwulQ/Jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from VE1EUR01FT008.eop-EUR01.prod.protection.outlook.com (10.152.2.54) by VE1EUR01HT037.eop-EUR01.prod.protection.outlook.com (10.152.3.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2327.20; Tue, 8 Oct 2019 06:31:34 +0000 Received: from HE1PR06MB4011.eurprd06.prod.outlook.com (10.152.2.51) by VE1EUR01FT008.mail.protection.outlook.com (10.152.2.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2327.20 via Frontend Transport; Tue, 8 Oct 2019 06:31:34 +0000 Received: from HE1PR06MB4011.eurprd06.prod.outlook.com ([fe80::5c5a:1160:a2e0:43d8]) by HE1PR06MB4011.eurprd06.prod.outlook.com ([fe80::5c5a:1160:a2e0:43d8%4]) with mapi id 15.20.2305.023; Tue, 8 Oct 2019 06:31:34 +0000 From: Jonas Karlman To: Tomasz Figa , Ezequiel Garcia CC: Linux Media Mailing List , "kernel@collabora.com" , Nicolas Dufresne , "open list:ARM/Rockchip SoC..." , Heiko Stuebner , Philipp Zabel , Boris Brezillon , Alexandre Courbot , "fbuergisser@chromium.org" , Linux Kernel Mailing List , Douglas Anderson Subject: Re: [PATCH v2 for 5.4 2/4] media: hantro: Fix H264 max frmsize supported on RK3288 Thread-Topic: [PATCH v2 for 5.4 2/4] media: hantro: Fix H264 max frmsize supported on RK3288 Thread-Index: AQHVfTc2RvTWvQQ6Z06gn22kTgvMXqdQN9WAgAARyQA= Date: Tue, 8 Oct 2019 06:31:34 +0000 Message-ID: References: <20191007174505.10681-1-ezequiel@collabora.com> <20191007174505.10681-3-ezequiel@collabora.com> In-Reply-To: Accept-Language: sv-SE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1PR0102CA0059.eurprd01.prod.exchangelabs.com (2603:10a6:7:7d::36) To HE1PR06MB4011.eurprd06.prod.outlook.com (2603:10a6:7:9c::32) x-incomingtopheadermarker: OriginalChecksum:281F0C36E430B8F36F04439000A3DBC16333D9CC187911F94A78B18B22AD256B;UpperCasedChecksum:C1A417F2D729E2DCD15B2C0D6BA3B5B330B226231AFD8AD3B0733E810954AA92;SizeAsReceived:8242;Count:50 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [lvFo+0uTl8sYwypXXBa2TCKeqijFnHGw] x-microsoft-original-message-id: <1489a28d-66d8-7ef5-538a-578f47991801@kwiboo.se> x-ms-publictraffictype: Email x-incomingheadercount: 50 x-eopattributedmessage: 0 x-ms-traffictypediagnostic: VE1EUR01HT037: x-ms-exchange-purlcount: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Vx6jkpNRG82vqj8k7nXsxg9kNuWK2eNTRoXBV5gVT7SP8OJ1vSLgnmZVs+gbYNeDJUo0DnFLYNcQy97Z4FfteR48lE+vCW3pFRRjq4QUTAG5Y/VlP9r2bHqOR/LQKDYFXM7kA2/XpoIQGe0keP3YvRopCWhpkFa0hDKDhyC6FtdD/0F53ur8w38q+V91yxocDgkjxZKunetW+hPfx0DGdLRoYxBDiOsc/YIFoPi0eoA= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="utf-8" Content-ID: <10B199680F83BE4F8A7AF0D78CC0BF51@eurprd06.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: a4c415ce-de24-44a9-8a39-08d74bb929e3 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2019 06:31:34.2993 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR01HT037 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gMjAxOS0xMC0wOCAwNzoyNywgVG9tYXN6IEZpZ2Egd3JvdGU6DQo+IEhpIEV6ZXF1aWVsLCBK b25hcywNCj4NCj4gT24gVHVlLCBPY3QgOCwgMjAxOSBhdCAyOjQ2IEFNIEV6ZXF1aWVsIEdhcmNp YSA8ZXplcXVpZWxAY29sbGFib3JhLmNvbT4gd3JvdGU6DQo+PiBGcm9tOiBKb25hcyBLYXJsbWFu IDxqb25hc0Brd2lib28uc2U+DQo+Pg0KPj4gVFJNIHNwZWNpZnkgc3VwcG9ydGVkIGltYWdlIHNp emUgNDh4NDggdG8gNDA5NngyMzA0IGF0IHN0ZXAgc2l6ZSAxNiBwaXhlbHMsDQo+PiBjaGFuZ2Ug ZnJtc2l6ZSBtYXhfd2lkdGgvbWF4X2hlaWdodCB0byBtYXRjaCBUUk0uDQo+Pg0KPj4gRml4ZXM6 IDc2MDMyNzkzMGUxMCAoIm1lZGlhOiBoYW50cm86IEVuYWJsZSBIMjY0IGRlY29kaW5nIG9uIHJr MzI4OCIpDQo+PiBTaWduZWQtb2ZmLWJ5OiBKb25hcyBLYXJsbWFuIDxqb25hc0Brd2lib28uc2U+ DQo+PiAtLS0NCj4+IHYyOg0KPj4gKiBObyBjaGFuZ2VzLg0KPj4NCj4+ICBkcml2ZXJzL3N0YWdp bmcvbWVkaWEvaGFudHJvL3JrMzI4OF92cHVfaHcuYyB8IDQgKystLQ0KPj4gIDEgZmlsZSBjaGFu Z2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+Pg0KPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9oYW50cm8vcmszMjg4X3ZwdV9ody5jIGIvZHJpdmVycy9z dGFnaW5nL21lZGlhL2hhbnRyby9yazMyODhfdnB1X2h3LmMNCj4+IGluZGV4IDZiZmNjNDdkMWU1 OC4uZWJiMDE3YjhhMzM0IDEwMDY0NA0KPj4gLS0tIGEvZHJpdmVycy9zdGFnaW5nL21lZGlhL2hh bnRyby9yazMyODhfdnB1X2h3LmMNCj4+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9oYW50 cm8vcmszMjg4X3ZwdV9ody5jDQo+PiBAQCAtNjcsMTAgKzY3LDEwIEBAIHN0YXRpYyBjb25zdCBz dHJ1Y3QgaGFudHJvX2ZtdCByazMyODhfdnB1X2RlY19mbXRzW10gPSB7DQo+PiAgICAgICAgICAg ICAgICAgLm1heF9kZXB0aCA9IDIsDQo+PiAgICAgICAgICAgICAgICAgLmZybXNpemUgPSB7DQo+ PiAgICAgICAgICAgICAgICAgICAgICAgICAubWluX3dpZHRoID0gNDgsDQo+PiAtICAgICAgICAg ICAgICAgICAgICAgICAubWF4X3dpZHRoID0gMzg0MCwNCj4+ICsgICAgICAgICAgICAgICAgICAg ICAgIC5tYXhfd2lkdGggPSA0MDk2LA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgLnN0ZXBf d2lkdGggPSBIMjY0X01CX0RJTSwNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgIC5taW5faGVp Z2h0ID0gNDgsDQo+PiAtICAgICAgICAgICAgICAgICAgICAgICAubWF4X2hlaWdodCA9IDIxNjAs DQo+PiArICAgICAgICAgICAgICAgICAgICAgICAubWF4X2hlaWdodCA9IDIzMDQsDQo+IFRoaXMg ZG9lc24ndCBtYXRjaCB0aGUgZGF0YXNoZWV0IEkgaGF2ZSwgd2hpY2ggaXMgUkszMjg4IERhdGFz aGVldCBSZXYNCj4gMS40IGFuZCB3aGljaCBoYXMgdGhlIHZhbHVlcyBhcyBpbiBjdXJyZW50IGNv ZGUuIFdoYXQncyB0aGUgb25lIHlvdQ0KPiBnb3QgdGhlIHZhbHVlcyBmcm9tPw0KDQpUaGUgUksz Mjg4IFRSTSB2Y29kZWMgY2hhcHRlciBmcm9tIFsxXSwgdW5rbm93biByZXZpc2lvbiBhbmQgZGF0 ZSwgbGlzdHMgNDh4NDggdG8gNDA5NngyMzA0IHN0ZXAgc2l6ZSAxNiBwaXhlbHMgdW5kZXIgMjUu NS4xIEguMjY0IGRlY29kZXIuDQoNCkkgY2FuIGFsc28gY29uZmlybSB0aGF0IG9uZSBvZiBteSB0 ZXN0IHNhbXBsZXMgKFBVUFBJRVMgQkFUSCBJTiA0SykgaXMgNDA5NngyMzA0IGFuZCBjYW4gYmUg ZGVjb2RlZCBhZnRlciB0aGlzIHBhdGNoLg0KSG93ZXZlciB0aGUgZGVjb2Rpbmcgc3BlZWQgaXMg bm90IG9wdGltYWwgYXQgNDAwTWh6LCBpZiBJIHJlY2FsbCBjb3JyZWN0bHkgeW91IG5lZWQgdG8g c2V0IHRoZSBWUFUxIGNsb2NrIHRvIDYwME1oeiBmb3IgNEsgZGVjb2Rpbmcgb24gUkszMjg4Lg0K DQpJIGFtIG5vdCBzdXJlIGlmIEkgc2hvdWxkIGluY2x1ZGUgYSB2MiBvZiB0aGlzIHBhdGNoIGlu IG15IHYyIHNlcmllcywgYXMtaXMgdGhpcyBwYXRjaCBkbyBub3QgYXBwbHkgb24gbWFzdGVyIChI MjY0X01CX0RJTSBoYXMgY2hhbmdlZCB0byBNQl9ESU0gaW4gbWFzdGVyKS4NCg0KWzFdIGh0dHA6 Ly93d3cudC1maXJlZmx5LmNvbS9kb3dubG9hZC9maXJlZmx5LXJrMzI4OC9kb2NzL1RSTS9yazMy ODgtY2hhcHRlci0yNS12aWRlby1lbmNvZGVyLWRlY29kZXItdW5pdC0odmNvZGVjKS5wZGYNCg0K UmVnYXJkcywNCkpvbmFzDQoNCj4NCj4gQmVzdCByZWdhcmRzLA0KPiBUb21hc3oNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonas Karlman Subject: Re: [PATCH v2 for 5.4 2/4] media: hantro: Fix H264 max frmsize supported on RK3288 Date: Tue, 8 Oct 2019 06:31:34 +0000 Message-ID: References: <20191007174505.10681-1-ezequiel@collabora.com> <20191007174505.10681-3-ezequiel@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Content-ID: <10B199680F83BE4F8A7AF0D78CC0BF51-NhzUejbdEhGcE4WynfumptQqCkab/8FMAL8bYrjMMd8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Tomasz Figa , Ezequiel Garcia Cc: "fbuergisser-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org" , "kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org" , Heiko Stuebner , Alexandre Courbot , Linux Kernel Mailing List , Douglas Anderson , "open list:ARM/Rockchip SoC..." , Boris Brezillon , Philipp Zabel , Nicolas Dufresne , Linux Media Mailing List List-Id: linux-rockchip.vger.kernel.org On 2019-10-08 07:27, Tomasz Figa wrote: > Hi Ezequiel, Jonas, > > On Tue, Oct 8, 2019 at 2:46 AM Ezequiel Garcia wrote: >> From: Jonas Karlman >> >> TRM specify supported image size 48x48 to 4096x2304 at step size 16 pixels, >> change frmsize max_width/max_height to match TRM. >> >> Fixes: 760327930e10 ("media: hantro: Enable H264 decoding on rk3288") >> Signed-off-by: Jonas Karlman >> --- >> v2: >> * No changes. >> >> drivers/staging/media/hantro/rk3288_vpu_hw.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/media/hantro/rk3288_vpu_hw.c b/drivers/staging/media/hantro/rk3288_vpu_hw.c >> index 6bfcc47d1e58..ebb017b8a334 100644 >> --- a/drivers/staging/media/hantro/rk3288_vpu_hw.c >> +++ b/drivers/staging/media/hantro/rk3288_vpu_hw.c >> @@ -67,10 +67,10 @@ static const struct hantro_fmt rk3288_vpu_dec_fmts[] = { >> .max_depth = 2, >> .frmsize = { >> .min_width = 48, >> - .max_width = 3840, >> + .max_width = 4096, >> .step_width = H264_MB_DIM, >> .min_height = 48, >> - .max_height = 2160, >> + .max_height = 2304, > This doesn't match the datasheet I have, which is RK3288 Datasheet Rev > 1.4 and which has the values as in current code. What's the one you > got the values from? The RK3288 TRM vcodec chapter from [1], unknown revision and date, lists 48x48 to 4096x2304 step size 16 pixels under 25.5.1 H.264 decoder. I can also confirm that one of my test samples (PUPPIES BATH IN 4K) is 4096x2304 and can be decoded after this patch. However the decoding speed is not optimal at 400Mhz, if I recall correctly you need to set the VPU1 clock to 600Mhz for 4K decoding on RK3288. I am not sure if I should include a v2 of this patch in my v2 series, as-is this patch do not apply on master (H264_MB_DIM has changed to MB_DIM in master). [1] http://www.t-firefly.com/download/firefly-rk3288/docs/TRM/rk3288-chapter-25-video-encoder-decoder-unit-(vcodec).pdf Regards, Jonas > > Best regards, > Tomasz