All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Spencer Ku (古世瑜)" <Spencer.Ku@quantatw.com>
To: "Bills, Jason M" <jason.m.bills@linux.intel.com>,
	"sunnsr25@in.ibm.com" <sunnsr25@in.ibm.com>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Cc: "Litzung Chen (陳利琮)" <Litzung.Chen@quantatw.com>,
	"Nan Zhou" <nanzhou@google.com>
Subject: Implement PCIeType Property
Date: Thu, 27 May 2021 07:09:02 +0000	[thread overview]
Message-ID: <HK0PR04MB329955B4A773802B019E1477E4239@HK0PR04MB3299.apcprd04.prod.outlook.com> (raw)

Hi All,
  We would like to implement PCIeInterface "PCIeType" property on both peci-pcie and bmcweb, then I find the PR which implement inventory properties like SparePartNumber, Model, PartNumber, SerialNumber for PCIe devices in bmcweb: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40051

I think we modify similar part of bmcweb, but I am not sure does it will implement "PCIeType" property in the future. So could we implement "PCIeType" property first since the PR status is WIP? 

About the implement method, for peci-pcie part, first we use peci command to get the pointer of capability in PCI configure space. Then go through capability structure to find capability ID in 3rd capability structure. If the ID is PCI Express, then get the link speed in link status register. Finally, set the PCIeType property to D-Bus after translating (under /xyz/openbmc_project/PCIe/<str>) .

And for bmcweb part, we will create PCIeInterface {"PCIeType"} level (under /redfish/v1/Systems/system/PCIeDevices/<str>/ ) and fill the info from D-bus. 

On the other hand, we also interested about how to get PartNumber and SerialNumber information? I already try to get from FRU over I2C but I cannot mapping the info between FRU and peci-pcie, or is it can easily get by peci-pcie? Any comments and suggestions are welcome!

Please let us know if there's any issue, thank you!

Sincerely,
Spencer Ku

             reply	other threads:[~2021-05-27  7:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27  7:09 Spencer Ku (古世瑜) [this message]
2021-05-27 15:27 ` Implement PCIeType Property Bills, Jason M
2021-05-28  8:38   ` Spencer Ku (古世瑜)
2021-05-31  7:01   ` Spencer Ku (古世瑜)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=HK0PR04MB329955B4A773802B019E1477E4239@HK0PR04MB3299.apcprd04.prod.outlook.com \
    --to=spencer.ku@quantatw.com \
    --cc=Litzung.Chen@quantatw.com \
    --cc=jason.m.bills@linux.intel.com \
    --cc=nanzhou@google.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=sunnsr25@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.