From: "Jun-Lin Chen (陳俊霖)" <Jun-Lin.Chen@quantatw.com>
To: Ed Tanous <edtanous@google.com>, Nan Zhou <nanzhou@google.com>
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"bradleyb@fuzziesquirrel.com" <bradleyb@fuzziesquirrel.com>
Subject: RE: SimpleStorage proposals
Date: Fri, 21 May 2021 01:51:45 +0000 [thread overview]
Message-ID: <HK0PR04MB33460B421AC36D12C1BA9567B1299@HK0PR04MB3346.apcprd04.prod.outlook.com> (raw)
In-Reply-To: <CAH2-KxCEV-vJr0kM9DVa3n+V3nayh_Pq0WkGPahqDimqa6ghnA@mail.gmail.com>
-----Original Message-----
From: Ed Tanous <edtanous@google.com>
Sent: Thursday, May 20, 2021 5:41 AM
To: Nan Zhou <nanzhou@google.com>
Cc: openbmc@lists.ozlabs.org; Jun-Lin Chen (陳俊霖) <Jun-Lin.Chen@quantatw.com>; bradleyb@fuzziesquirrel.com
Subject: Re: SimpleStorage proposals
On Wed, May 19, 2021 at 2:27 PM Nan Zhou <nanzhou@google.com> wrote:
>
> Thanks for your reply, Ed!
>
>>
>> You've also omitted what properties you're trying to target. Could
>> you walk through a little bit about what you're trying to accomplish
>> with this? (beyond just "implement the redfish schemas). Are you
>> trying to get smart data? just inventory information? Do you plan
>> to represent connections?
>
>
> As a first step, we are only going to implement three properties, Name, Presence, and PowerStatus. We don't plan to represent connections at the moment.
I'm assuming these will be the dbus properties names, as redfish doesn't really have a presence property or a powerstatus property.
With that said, that seems reasonable to me to want to do, but we need to make sure we're clear on how this differs from the existing Drive interfaces.
After question in redfish forum, https://redfishforum.com/thread/483/different-storage-simplestorage
We got SimpleStorage was the early model in Redfish for showing storage devices, and "Devices" in this resource do equate to drives.
We would use xyz.openbmc_project.Inventory.Drive instead xyz.openbmc_project.Inventory.SimpleStorage to represent our storage device.
>
> On Wed, May 19, 2021 at 1:43 PM Ed Tanous <ed@tanous.net> wrote:
>>
>> On Wed, May 19, 2021 at 12:57 AM Jun-Lin Chen (陳俊霖)
>> <Jun-Lin.Chen@quantatw.com> wrote:
>> >
>> > Hi all,
>> >
>> >
>> >
>> > In order to implement the feature to view simple storage device status, such SATA HDD presence status.
>> >
>> > We propose to implement it on the Redfish SimpleStorage URI.
>> >
>> >
>> >
>> > As our proposal for Redfish SimpleStorage,
>> > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
>> > errit.openbmc-project.xyz%2Fc%2Fopenbmc%2Fdocs%2F%2B%2F43352&da
>> > ta=04%7C01%7CJun-Lin.Chen%40quantatw.com%7Cd419ece6a8d344d93bbb08d9
>> > 1b0ec5c4%7C179b032707fc4973ac738de7313561b2%7C1%7C0%7C6375705731225
>> > 16364%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL
>> > CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=BvHa13JAozhhau6qxQqs
>> > 8XMe1BX1jMi057h%2BFZ67lJk%3D&reserved=0
>> >
>> > And an new daemon,
>> > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
>> > errit.openbmc-project.xyz%2Fc%2Fopenbmc%2Fdocs%2F%2B%2F43351&da
>> > ta=04%7C01%7CJun-Lin.Chen%40quantatw.com%7Cd419ece6a8d344d93bbb08d9
>> > 1b0ec5c4%7C179b032707fc4973ac738de7313561b2%7C1%7C0%7C6375705731225
>> > 26352%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL
>> > CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=c7TSGNJC5BlMxWwmFBQH
>> > X3gHH8xbPEu53hsNHun04Jo%3D&reserved=0
>> >
>> >
>> >
>> > There are two new dbus-interfaces to be proposed,
>> >
>> > xyz.openbmc_project.Inventory.Item.StorageDevice: here is an empty interface just mark the dbus path that SimpleStorage Manager should collect.
>> >
>> > xyz.openbmc_project.Inventory.Item.SimpleStorage: it should have the properties redfish needs, and can be parser by bmcweb.
>>
>>
>> How does this differ from xyz.openbmc_project.Inventory.Item.Drive?
>> They look fairly similar; We generally don't name dbus interfaces
>> after Redfish directly. We should reuse what already exists where
>> possible, and only invent new things where needed.
>>
>> You've also omitted what properties you're trying to target. Could
>> you walk through a little bit about what you're trying to accomplish
>> with this? (beyond just "implement the redfish schemas). Are you
>> trying to get smart data? just inventory information? Do you plan
>> to represent connections?
>>
>> >
>> >
>> >
>> > The details are in the proposal.
>> >
>> >
>> >
>> > Welcome and thank you for comments and suggestions
>> >
>> >
>> >
>> > Best regards,
>> >
>> > Jun-Lin Chen
>> >
>> >
prev parent reply other threads:[~2021-05-24 1:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 7:57 SimpleStorage proposals Jun-Lin Chen (陳俊霖)
2021-05-19 20:43 ` Ed Tanous
2021-05-19 21:26 ` Nan Zhou
2021-05-19 21:40 ` Ed Tanous
2021-05-19 22:14 ` Nan Zhou
2021-05-21 1:51 ` Jun-Lin Chen (陳俊霖) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HK0PR04MB33460B421AC36D12C1BA9567B1299@HK0PR04MB3346.apcprd04.prod.outlook.com \
--to=jun-lin.chen@quantatw.com \
--cc=bradleyb@fuzziesquirrel.com \
--cc=edtanous@google.com \
--cc=nanzhou@google.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.