From: "Johnson CH Chen (陳昭勳)" <JohnsonCH.Chen@moxa.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Randy Dunlap <rdunlap@infradead.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Scott Wood <scottwood@freescale.com>
Subject: RE: linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o)
Date: Mon, 20 Jul 2020 03:46:15 +0000 [thread overview]
Message-ID: <HK2PR01MB32812019FB4521DC22313B10FA7B0@HK2PR01MB3281.apcprd01.prod.exchangelabs.com> (raw)
In-Reply-To: <20200718113853.6bd63897@canb.auug.org.au>
Hi Stephen,
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: Saturday, July 18, 2020 9:39 AM
> To: Randy Dunlap <rdunlap@infradead.org>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel Mailing
> List <linux-kernel@vger.kernel.org>; linux-rtc@vger.kernel.org; Alessandro
> Zummo <a.zummo@towertech.it>; Alexandre Belloni
> <alexandre.belloni@bootlin.com>; Scott Wood <scottwood@freescale.com>;
> Johnson CH Chen (陳昭勳) <JohnsonCH.Chen@moxa.com>
> Subject: Re: linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o)
>
> Hi Randy,
>
> [Please trim your emails a bit more, thanks]
>
> On Fri, 17 Jul 2020 09:49:05 -0700 Randy Dunlap <rdunlap@infradead.org>
> wrote:
> > on x86_64:
> > # CONFIG_WATCHDOG is not set
> >
Thanks for your information.
It seems RTC_DRV_DS1374_WDT should be depended on RTC_DRV_DS1374 && WATCHDOG_CORE. Otherwise error will happen if RTC_DRV_DS1374_WDT is enabled but WATCHDOG_CORE not. I'll put this into v5 if there are no other suggestions.
Should I add " Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>" into v5? So many thanks!
> > ld: drivers/rtc/rtc-ds1374.o: in function `ds1374_probe':
> > rtc-ds1374.c:(.text+0x736): undefined reference to
> `watchdog_init_timeout'
> > ld: rtc-ds1374.c:(.text+0x77e): undefined reference to
> `devm_watchdog_register_device'
>
> Caused by commit
>
> d3de4beb14a8 ("rtc: ds1374: wdt: Use watchdog core for watchdog
> part")
>
> from the rtc tree.
> --
> Cheers,
> Stephen Rothwell
Best regards,
Johnson
next prev parent reply other threads:[~2020-07-20 3:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 11:40 linux-next: Tree for Jul 17 Stephen Rothwell
2020-07-17 16:49 ` linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o) Randy Dunlap
2020-07-18 1:38 ` Stephen Rothwell
2020-07-20 3:46 ` Johnson CH Chen (陳昭勳) [this message]
2020-07-20 4:21 ` Stephen Rothwell
2020-07-20 8:12 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HK2PR01MB32812019FB4521DC22313B10FA7B0@HK2PR01MB3281.apcprd01.prod.exchangelabs.com \
--to=johnsonch.chen@moxa.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=scottwood@freescale.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.