From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16088C43334 for ; Thu, 7 Jul 2022 09:43:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235156AbiGGJnL (ORCPT ); Thu, 7 Jul 2022 05:43:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233783AbiGGJnH (ORCPT ); Thu, 7 Jul 2022 05:43:07 -0400 Received: from aposti.net (aposti.net [89.234.176.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9C2A45070; Thu, 7 Jul 2022 02:43:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1657186985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i8p03/aknxZm4ISCg5osm/QCfwD06OLWvg98PIGVA6k=; b=4SIGlYDYz6ZeZwMrdFwcHjdodvrTphUWQoqLzkb/6LkauADFI0vWu+8mpxaajfTFhrYj87 UHht/fC++I9qD2m9Mw2oNxWMBu2R3rOFRIB8frxKvS5vDhiJiRJAgBjkfneTYy4BzHYz+t BaW4ijYk24naRuCXPWWhsdjRcMj/ph4= Date: Thu, 07 Jul 2022 10:42:55 +0100 From: Paul Cercueil Subject: Re: [PATCH 08/11] ASoC: jz4740-i2s: Align macro values and sort includes To: Aidan MacDonald Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-mips@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <20220706211330.120198-9-aidanmacdonald.0x0@gmail.com> References: <20220706211330.120198-1-aidanmacdonald.0x0@gmail.com> <20220706211330.120198-9-aidanmacdonald.0x0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le mer., juil. 6 2022 at 22:13:27 +0100, Aidan MacDonald=20 a =E9crit : > Some purely cosmetic changes: line up all the macro values to > make things easier to read and sort the includes alphabetically. >=20 > Signed-off-by: Aidan MacDonald Acked-by: Paul Cercueil Cheers, -Paul > --- > sound/soc/jz4740/jz4740-i2s.c | 66=20 > +++++++++++++++++------------------ > 1 file changed, 32 insertions(+), 34 deletions(-) >=20 > diff --git a/sound/soc/jz4740/jz4740-i2s.c=20 > b/sound/soc/jz4740/jz4740-i2s.c > index b8d2723c5f90..3a21ee9d34d1 100644 > --- a/sound/soc/jz4740/jz4740-i2s.c > +++ b/sound/soc/jz4740/jz4740-i2s.c > @@ -4,6 +4,9 @@ > */ >=20 > #include > +#include > +#include > +#include > #include > #include > #include > @@ -13,11 +16,6 @@ > #include > #include >=20 > -#include > -#include > - > -#include > - > #include > #include > #include > @@ -35,36 +33,36 @@ > #define JZ_REG_AIC_CLK_DIV 0x30 > #define JZ_REG_AIC_FIFO 0x34 >=20 > -#define JZ_AIC_CONF_OVERFLOW_PLAY_LAST BIT(6) > -#define JZ_AIC_CONF_INTERNAL_CODEC BIT(5) > -#define JZ_AIC_CONF_I2S BIT(4) > -#define JZ_AIC_CONF_RESET BIT(3) > -#define JZ_AIC_CONF_BIT_CLK_MASTER BIT(2) > -#define JZ_AIC_CONF_SYNC_CLK_MASTER BIT(1) > -#define JZ_AIC_CONF_ENABLE BIT(0) > - > -#define JZ_AIC_CTRL_OUTPUT_SAMPLE_SIZE GENMASK(21, 19) > -#define JZ_AIC_CTRL_INPUT_SAMPLE_SIZE GENMASK(18, 16) > -#define JZ_AIC_CTRL_ENABLE_RX_DMA BIT(15) > -#define JZ_AIC_CTRL_ENABLE_TX_DMA BIT(14) > -#define JZ_AIC_CTRL_MONO_TO_STEREO BIT(11) > -#define JZ_AIC_CTRL_SWITCH_ENDIANNESS BIT(10) > -#define JZ_AIC_CTRL_SIGNED_TO_UNSIGNED BIT(9) > +#define JZ_AIC_CONF_OVERFLOW_PLAY_LAST BIT(6) > +#define JZ_AIC_CONF_INTERNAL_CODEC BIT(5) > +#define JZ_AIC_CONF_I2S BIT(4) > +#define JZ_AIC_CONF_RESET BIT(3) > +#define JZ_AIC_CONF_BIT_CLK_MASTER BIT(2) > +#define JZ_AIC_CONF_SYNC_CLK_MASTER BIT(1) > +#define JZ_AIC_CONF_ENABLE BIT(0) > + > +#define JZ_AIC_CTRL_OUTPUT_SAMPLE_SIZE GENMASK(21, 19) > +#define JZ_AIC_CTRL_INPUT_SAMPLE_SIZE GENMASK(18, 16) > +#define JZ_AIC_CTRL_ENABLE_RX_DMA BIT(15) > +#define JZ_AIC_CTRL_ENABLE_TX_DMA BIT(14) > +#define JZ_AIC_CTRL_MONO_TO_STEREO BIT(11) > +#define JZ_AIC_CTRL_SWITCH_ENDIANNESS BIT(10) > +#define JZ_AIC_CTRL_SIGNED_TO_UNSIGNED BIT(9) > #define JZ_AIC_CTRL_FLUSH BIT(8) > -#define JZ_AIC_CTRL_ENABLE_ROR_INT BIT(6) > -#define JZ_AIC_CTRL_ENABLE_TUR_INT BIT(5) > -#define JZ_AIC_CTRL_ENABLE_RFS_INT BIT(4) > -#define JZ_AIC_CTRL_ENABLE_TFS_INT BIT(3) > -#define JZ_AIC_CTRL_ENABLE_LOOPBACK BIT(2) > -#define JZ_AIC_CTRL_ENABLE_PLAYBACK BIT(1) > -#define JZ_AIC_CTRL_ENABLE_CAPTURE BIT(0) > - > -#define JZ_AIC_I2S_FMT_DISABLE_BIT_CLK BIT(12) > -#define JZ_AIC_I2S_FMT_DISABLE_BIT_ICLK BIT(13) > -#define JZ_AIC_I2S_FMT_ENABLE_SYS_CLK BIT(4) > -#define JZ_AIC_I2S_FMT_MSB BIT(0) > - > -#define JZ_AIC_I2S_STATUS_BUSY BIT(2) > +#define JZ_AIC_CTRL_ENABLE_ROR_INT BIT(6) > +#define JZ_AIC_CTRL_ENABLE_TUR_INT BIT(5) > +#define JZ_AIC_CTRL_ENABLE_RFS_INT BIT(4) > +#define JZ_AIC_CTRL_ENABLE_TFS_INT BIT(3) > +#define JZ_AIC_CTRL_ENABLE_LOOPBACK BIT(2) > +#define JZ_AIC_CTRL_ENABLE_PLAYBACK BIT(1) > +#define JZ_AIC_CTRL_ENABLE_CAPTURE BIT(0) > + > +#define JZ_AIC_I2S_FMT_DISABLE_BIT_CLK BIT(12) > +#define JZ_AIC_I2S_FMT_DISABLE_BIT_ICLK BIT(13) > +#define JZ_AIC_I2S_FMT_ENABLE_SYS_CLK BIT(4) > +#define JZ_AIC_I2S_FMT_MSB BIT(0) > + > +#define JZ_AIC_I2S_STATUS_BUSY BIT(2) >=20 > struct i2s_soc_info { > struct snd_soc_dai_driver *dai; > -- > 2.35.1 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED49CC43334 for ; Thu, 7 Jul 2022 09:44:08 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 03E38165D; Thu, 7 Jul 2022 11:43:17 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 03E38165D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657187047; bh=YpVDHgTn4irsxYuskX3QF9HTHfVWYWcpVcQD6F8bfpY=; h=Date:From:Subject:To:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nvJUOeVF/vc3nMKIFrUaX93t7wf9tAImzujYqI5xFz3Qmdg9mSu9BGeNCcRjskg4N 2+nwekbk/Qzr/1fU+GuShwhlEFt+y7aHcbdtm4unDyiSnJLW9Ust3yJ8/UoRMR/prS h/dhIh6oFlvUpzZKeDvileaL2YUUZMvXXptlsfM4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C7DA7F804FA; Thu, 7 Jul 2022 11:43:14 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 816B1F80537; Thu, 7 Jul 2022 11:43:13 +0200 (CEST) Received: from aposti.net (aposti.net [89.234.176.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 14CA0F800C5 for ; Thu, 7 Jul 2022 11:43:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 14CA0F800C5 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="4SIGlYDY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1657186985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i8p03/aknxZm4ISCg5osm/QCfwD06OLWvg98PIGVA6k=; b=4SIGlYDYz6ZeZwMrdFwcHjdodvrTphUWQoqLzkb/6LkauADFI0vWu+8mpxaajfTFhrYj87 UHht/fC++I9qD2m9Mw2oNxWMBu2R3rOFRIB8frxKvS5vDhiJiRJAgBjkfneTYy4BzHYz+t BaW4ijYk24naRuCXPWWhsdjRcMj/ph4= Date: Thu, 07 Jul 2022 10:42:55 +0100 From: Paul Cercueil Subject: Re: [PATCH 08/11] ASoC: jz4740-i2s: Align macro values and sort includes To: Aidan MacDonald Message-Id: In-Reply-To: <20220706211330.120198-9-aidanmacdonald.0x0@gmail.com> References: <20220706211330.120198-1-aidanmacdonald.0x0@gmail.com> <20220706211330.120198-9-aidanmacdonald.0x0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, tiwai@suse.com, broonie@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Le mer., juil. 6 2022 at 22:13:27 +0100, Aidan MacDonald=20 a =E9crit : > Some purely cosmetic changes: line up all the macro values to > make things easier to read and sort the includes alphabetically. >=20 > Signed-off-by: Aidan MacDonald Acked-by: Paul Cercueil Cheers, -Paul > --- > sound/soc/jz4740/jz4740-i2s.c | 66=20 > +++++++++++++++++------------------ > 1 file changed, 32 insertions(+), 34 deletions(-) >=20 > diff --git a/sound/soc/jz4740/jz4740-i2s.c=20 > b/sound/soc/jz4740/jz4740-i2s.c > index b8d2723c5f90..3a21ee9d34d1 100644 > --- a/sound/soc/jz4740/jz4740-i2s.c > +++ b/sound/soc/jz4740/jz4740-i2s.c > @@ -4,6 +4,9 @@ > */ >=20 > #include > +#include > +#include > +#include > #include > #include > #include > @@ -13,11 +16,6 @@ > #include > #include >=20 > -#include > -#include > - > -#include > - > #include > #include > #include > @@ -35,36 +33,36 @@ > #define JZ_REG_AIC_CLK_DIV 0x30 > #define JZ_REG_AIC_FIFO 0x34 >=20 > -#define JZ_AIC_CONF_OVERFLOW_PLAY_LAST BIT(6) > -#define JZ_AIC_CONF_INTERNAL_CODEC BIT(5) > -#define JZ_AIC_CONF_I2S BIT(4) > -#define JZ_AIC_CONF_RESET BIT(3) > -#define JZ_AIC_CONF_BIT_CLK_MASTER BIT(2) > -#define JZ_AIC_CONF_SYNC_CLK_MASTER BIT(1) > -#define JZ_AIC_CONF_ENABLE BIT(0) > - > -#define JZ_AIC_CTRL_OUTPUT_SAMPLE_SIZE GENMASK(21, 19) > -#define JZ_AIC_CTRL_INPUT_SAMPLE_SIZE GENMASK(18, 16) > -#define JZ_AIC_CTRL_ENABLE_RX_DMA BIT(15) > -#define JZ_AIC_CTRL_ENABLE_TX_DMA BIT(14) > -#define JZ_AIC_CTRL_MONO_TO_STEREO BIT(11) > -#define JZ_AIC_CTRL_SWITCH_ENDIANNESS BIT(10) > -#define JZ_AIC_CTRL_SIGNED_TO_UNSIGNED BIT(9) > +#define JZ_AIC_CONF_OVERFLOW_PLAY_LAST BIT(6) > +#define JZ_AIC_CONF_INTERNAL_CODEC BIT(5) > +#define JZ_AIC_CONF_I2S BIT(4) > +#define JZ_AIC_CONF_RESET BIT(3) > +#define JZ_AIC_CONF_BIT_CLK_MASTER BIT(2) > +#define JZ_AIC_CONF_SYNC_CLK_MASTER BIT(1) > +#define JZ_AIC_CONF_ENABLE BIT(0) > + > +#define JZ_AIC_CTRL_OUTPUT_SAMPLE_SIZE GENMASK(21, 19) > +#define JZ_AIC_CTRL_INPUT_SAMPLE_SIZE GENMASK(18, 16) > +#define JZ_AIC_CTRL_ENABLE_RX_DMA BIT(15) > +#define JZ_AIC_CTRL_ENABLE_TX_DMA BIT(14) > +#define JZ_AIC_CTRL_MONO_TO_STEREO BIT(11) > +#define JZ_AIC_CTRL_SWITCH_ENDIANNESS BIT(10) > +#define JZ_AIC_CTRL_SIGNED_TO_UNSIGNED BIT(9) > #define JZ_AIC_CTRL_FLUSH BIT(8) > -#define JZ_AIC_CTRL_ENABLE_ROR_INT BIT(6) > -#define JZ_AIC_CTRL_ENABLE_TUR_INT BIT(5) > -#define JZ_AIC_CTRL_ENABLE_RFS_INT BIT(4) > -#define JZ_AIC_CTRL_ENABLE_TFS_INT BIT(3) > -#define JZ_AIC_CTRL_ENABLE_LOOPBACK BIT(2) > -#define JZ_AIC_CTRL_ENABLE_PLAYBACK BIT(1) > -#define JZ_AIC_CTRL_ENABLE_CAPTURE BIT(0) > - > -#define JZ_AIC_I2S_FMT_DISABLE_BIT_CLK BIT(12) > -#define JZ_AIC_I2S_FMT_DISABLE_BIT_ICLK BIT(13) > -#define JZ_AIC_I2S_FMT_ENABLE_SYS_CLK BIT(4) > -#define JZ_AIC_I2S_FMT_MSB BIT(0) > - > -#define JZ_AIC_I2S_STATUS_BUSY BIT(2) > +#define JZ_AIC_CTRL_ENABLE_ROR_INT BIT(6) > +#define JZ_AIC_CTRL_ENABLE_TUR_INT BIT(5) > +#define JZ_AIC_CTRL_ENABLE_RFS_INT BIT(4) > +#define JZ_AIC_CTRL_ENABLE_TFS_INT BIT(3) > +#define JZ_AIC_CTRL_ENABLE_LOOPBACK BIT(2) > +#define JZ_AIC_CTRL_ENABLE_PLAYBACK BIT(1) > +#define JZ_AIC_CTRL_ENABLE_CAPTURE BIT(0) > + > +#define JZ_AIC_I2S_FMT_DISABLE_BIT_CLK BIT(12) > +#define JZ_AIC_I2S_FMT_DISABLE_BIT_ICLK BIT(13) > +#define JZ_AIC_I2S_FMT_ENABLE_SYS_CLK BIT(4) > +#define JZ_AIC_I2S_FMT_MSB BIT(0) > + > +#define JZ_AIC_I2S_STATUS_BUSY BIT(2) >=20 > struct i2s_soc_info { > struct snd_soc_dai_driver *dai; > -- > 2.35.1 >=20