From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bijosh Thykkoottathil To: "jic23@kernel.org" , "knaack.h@gmx.de" , "lars@metafoo.de" , "pmeerw@pmeerw.net" , "k.kozlowski@samsung.com" CC: "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH 1/1] drivers:iio:light:isl29125: added macros for sensing range Date: Fri, 24 Jun 2016 11:16:18 +0000 Message-ID: Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 List-ID: Added macros for sensing range as the corresponding magic numbers were used at multiple places. - SENSING_RANGE_0 for 375 lux full range - SENSING_RANGE_1 for 10k lux full range Signed-off-by: Bijosh Thykkoottathil --- drivers/iio/light/isl29125.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/isl29125.c b/drivers/iio/light/isl29125.c index e2945a2..83a5a7a 100644 --- a/drivers/iio/light/isl29125.c +++ b/drivers/iio/light/isl29125.c @@ -44,6 +44,9 @@ #define ISL29125_MODE_B 0x3 #define ISL29125_MODE_RGB 0x5 =20 +#define SENSING_RANGE_0 5722 /* 375 lux full range */ +#define SENSING_RANGE_1 152590 /* 10k lux full range */ + #define ISL29125_MODE_RANGE BIT(3) =20 #define ISL29125_STATUS_CONV BIT(1) @@ -140,9 +143,9 @@ static int isl29125_read_raw(struct iio_dev *indio_dev, case IIO_CHAN_INFO_SCALE: *val =3D 0; if (data->conf1 & ISL29125_MODE_RANGE) - *val2 =3D 152590; /* 10k lux full range */ + *val2 =3D SENSING_RANGE_1; /* 10k lux full range */ else - *val2 =3D 5722; /* 375 lux full range */ + *val2 =3D SENSING_RANGE_0; /* 375 lux full range */ return IIO_VAL_INT_PLUS_MICRO; } return -EINVAL; @@ -158,9 +161,9 @@ static int isl29125_write_raw(struct iio_dev *indio_dev= , case IIO_CHAN_INFO_SCALE: if (val !=3D 0) return -EINVAL; - if (val2 =3D=3D 152590) + if (val2 =3D=3D SENSING_RANGE_1) data->conf1 |=3D ISL29125_MODE_RANGE; - else if (val2 =3D=3D 5722) + else if (val2 =3D=3D SENSING_RANGE_0) data->conf1 &=3D ~ISL29125_MODE_RANGE; else return -EINVAL; --=20 2.1.4