From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1020C47082 for ; Sat, 5 Jun 2021 19:19:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A28361287 for ; Sat, 5 Jun 2021 19:19:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A28361287 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 16C6581660; Sat, 5 Jun 2021 21:19:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=protonmail.com header.i=@protonmail.com header.b="mYSqxlMJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5577D81CDE; Sat, 5 Jun 2021 21:19:16 +0200 (CEST) Received: from mail-40140.protonmail.ch (mail-40140.protonmail.ch [185.70.40.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A54C280C92 for ; Sat, 5 Jun 2021 21:19:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mattmerhar@protonmail.com Date: Sat, 05 Jun 2021 19:18:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1622920749; bh=qfJc0xRLWbJYqHvDeph+RsUZMc2ijZG9S5ltkhE4SCg=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=mYSqxlMJOAWg3mg/YzCMewJt3wQLAGYIOA8+jfwhw1viQbENqrUExItIabyNpS73Y cS2Tq9TxqRHXKhYus0ZFZoL3b3iY7TlLkJQIb2X2unuf8EhSN/DaoNSd5j67c/ugQP g9+9ROP+n+12TrbD/+pa+qRIKW7FCZaZvbroQnAo= To: Tom Rini From: Matt Merhar Cc: u-boot@lists.denx.de, Rasmus Villemoes Subject: Re: [PATCH 1/4] powerpc: Don't use relative include for config.h in global_data.h Message-ID: In-Reply-To: <20210603133902.4192-1-trini@konsulko.com> References: <20210518091947.63513-1-rasmus.villemoes@prevas.dk> <20210603133902.4192-1-trini@konsulko.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Matt Merhar Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean On Thu, 03 Jun 2021 09:38:59 -0400 "Tom Rini" wrote: > As there is an arch/powerpc/include/asm/config.h file using "" to get > config.h here can lead to using that rather than include/config.h. > This in turn can lead to a mismatch in the size of gd. >=20 > Cc: Matt Merhar > Signed-off-by: Tom Rini > --- > arch/powerpc/include/asm/global_data.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/powerpc/include/asm/global_data.h > b/arch/powerpc/include/asm/global_data.h index > 192a02d347e7..90bf5a2aea5d 100644 --- > a/arch/powerpc/include/asm/global_data.h +++ > b/arch/powerpc/include/asm/global_data.h @@ -8,7 +8,7 @@ > #ifndef=09__ASM_GBL_DATA_H > #define __ASM_GBL_DATA_H >=20 > -#include "config.h" > +#include > #include "asm/types.h" >=20 > /* Architecture-specific global data */ > -- > 2.17.1 >=20 I think this is a better solution, as it also appears to fix another global_data size mismatch caught by the RFC from Rasmus "global-data.h: add build-time sanity check of sizeof(struct global_data)". Tested-by: Matt Merhar