All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qiuhao Li <Qiuhao.Li@outlook.com>
To: alxndr@bu.edu, qemu-devel@nongnu.org
Cc: thuth@redhat.com, Qiuhao Li <Qiuhao.Li@outlook.com>,
	darren.kenny@oracle.com, bsd@redhat.com, stefanha@redhat.com,
	pbonzini@redhat.com
Subject: [PATCH v4 5/7] fuzz: set bits in operand of write/out to zero
Date: Tue, 29 Dec 2020 12:40:42 +0800	[thread overview]
Message-ID: <ME3P282MB17458E59681E482B73EDC9A6FCD80@ME3P282MB1745.AUSP282.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <ME3P282MB17456B93AE422008F433C50DFCD80@ME3P282MB1745.AUSP282.PROD.OUTLOOK.COM>

Simplifying the crash cases by opportunistically setting bits in operands of
out/write to zero may help to debug, since usually bit one means turn on or
trigger a function while zero is the default turn-off setting.

Tested Bug 1908062.

Signed-off-by: Qiuhao Li <Qiuhao.Li@outlook.com>
---
 scripts/oss-fuzz/minimize_qtest_trace.py | 39 ++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/scripts/oss-fuzz/minimize_qtest_trace.py b/scripts/oss-fuzz/minimize_qtest_trace.py
index 378a7ccec6..70ac0c5366 100755
--- a/scripts/oss-fuzz/minimize_qtest_trace.py
+++ b/scripts/oss-fuzz/minimize_qtest_trace.py
@@ -164,6 +164,42 @@ def remove_minimizer(newtrace, outpath):
         i += 1
 
 
+def set_zero_minimizer(newtrace, outpath):
+    # try setting bits in operands of out/write to zero
+    i = 0
+    while i < len(newtrace):
+        if (not newtrace[i].startswith("write ") and not
+           newtrace[i].startswith("out")):
+           i += 1
+           continue
+        # write ADDR SIZE DATA
+        # outx ADDR VALUE
+        print("\nzero setting bits: {}".format(newtrace[i]))
+
+        prefix = " ".join(newtrace[i].split()[:-1])
+        data = newtrace[i].split()[-1]
+        data_bin = bin(int(data, 16))
+        data_bin_list = list(data_bin)
+
+        for j in range(2, len(data_bin_list)):
+            prior = newtrace[i]
+            if (data_bin_list[j] == '1'):
+                data_bin_list[j] = '0'
+                data_try = hex(int("".join(data_bin_list), 2))
+                # It seems qtest only accepts padded hex-values.
+                if len(data_try) % 2 == 1:
+                    data_try = data_try[:2] + "0" + data_try[2:-1]
+
+                newtrace[i] = "{prefix} {data_try}\n".format(
+                        prefix=prefix,
+                        data_try=data_try)
+
+                if not check_if_trace_crashes(newtrace, outpath):
+                    data_bin_list[j] = '1'
+                    newtrace[i] = prior
+        i += 1
+
+
 def minimize_trace(inpath, outpath):
     global TIMEOUT
     with open(inpath) as f:
@@ -184,7 +220,10 @@ def minimize_trace(inpath, outpath):
         old_len = len(newtrace)
         remove_minimizer(newtrace, outpath)
         newtrace = list(filter(lambda s: s != "", newtrace))
+    assert(check_if_trace_crashes(newtrace, outpath))
 
+    # set zero minimizer
+    set_zero_minimizer(newtrace, outpath)
     assert(check_if_trace_crashes(newtrace, outpath))
 
 
-- 
2.25.1



  parent reply	other threads:[~2020-12-29  4:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-29  4:39 [PATCH v4 0/7] fuzz: improve crash case minimization Qiuhao Li
2020-12-29  4:40 ` [PATCH v4 1/7] fuzz: accelerate non-crash detection Qiuhao Li
2021-01-07  3:42   ` Alexander Bulekov
2021-01-07  4:18   ` Alexander Bulekov
2021-01-08  2:47     ` Qiuhao Li
2021-01-10 13:10     ` Qiuhao Li
2021-01-10 16:00       ` Alexander Bulekov
2021-01-11  2:19         ` Qiuhao Li
2020-12-29  4:40 ` [PATCH v4 2/7] fuzz: double the IOs to remove for every loop Qiuhao Li
2021-01-07  4:19   ` Alexander Bulekov
2020-12-29  4:40 ` [PATCH v4 3/7] fuzz: split write operand using binary approach Qiuhao Li
2021-01-07  4:28   ` Alexander Bulekov
2020-12-29  4:40 ` [PATCH v4 4/7] fuzz: loop the remove minimizer and refactoring Qiuhao Li
2021-01-07  4:53   ` Alexander Bulekov
2021-01-08  2:49     ` Qiuhao Li
2020-12-29  4:40 ` Qiuhao Li [this message]
2021-01-07  5:08   ` [PATCH v4 5/7] fuzz: set bits in operand of write/out to zero Alexander Bulekov
2020-12-29  4:40 ` [PATCH v4 6/7] fuzz: add minimization options Qiuhao Li
2021-01-07  5:54   ` Alexander Bulekov
2020-12-29  4:40 ` [PATCH v4 7/7] fuzz: heuristic split write based on past IOs Qiuhao Li
2021-01-08  4:30   ` Alexander Bulekov
2021-01-05  8:00 ` Ping: [PATCH v4 0/7] fuzz: improve crash case minimization Qiuhao Li
2021-01-08  4:32 ` Alexander Bulekov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ME3P282MB17458E59681E482B73EDC9A6FCD80@ME3P282MB1745.AUSP282.PROD.OUTLOOK.COM \
    --to=qiuhao.li@outlook.com \
    --cc=alxndr@bu.edu \
    --cc=bsd@redhat.com \
    --cc=darren.kenny@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.