From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sy3aus01on0054.outbound.protection.outlook.com ([104.47.117.54]:33373 "EHLO AUS01-SY3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030489AbdIZIla (ORCPT ); Tue, 26 Sep 2017 04:41:30 -0400 From: Paul Jones To: "dsterba@suse.cz" , Liu Bo CC: "linux-btrfs@vger.kernel.org" Subject: RE: [PATCH 1/2] Btrfs: fix kernel oops while reading compressed data Date: Tue, 26 Sep 2017 08:41:27 +0000 Message-ID: References: <20170920235019.10508-1-bo.li.liu@oracle.com> <20170924134539.GT29043@twin.jikos.cz> In-Reply-To: <20170924134539.GT29043@twin.jikos.cz> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-btrfs-owner@vger.kernel.org List-ID: > -----Original Message----- > From: linux-btrfs-owner@vger.kernel.org [mailto:linux-btrfs- > owner@vger.kernel.org] On Behalf Of David Sterba > Sent: Sunday, 24 September 2017 11:46 PM > To: Liu Bo > Cc: linux-btrfs@vger.kernel.org > Subject: Re: [PATCH 1/2] Btrfs: fix kernel oops while reading compressed > data > > On Wed, Sep 20, 2017 at 05:50:18PM -0600, Liu Bo wrote: > > The kernel oops happens at > > > > kernel BUG at fs/btrfs/extent_io.c:2104! > > ... > > RIP: clean_io_failure+0x263/0x2a0 [btrfs] > > > > It's showing that read-repair code is using an improper mirror index. > > This is due to the fact that compression read's endio hasn't recorded > > the failed mirror index in %cb->orig_bio. > > > > With this, btrfs's read-repair can work properly on reading compressed > > data. > > > > Signed-off-by: Liu Bo > > Reported-by: Paul Jones > > Reviewed-by: David Sterba Tested-by: For both patches. I caused the same thing to happen again, this time by unplugging the wrong hard drive. Applied the patches and problem (BUG_ON) is gone. Should this also go to stable? Seems like a rather glaring problem to me. Paul.