All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Limonciello, Mario" <Mario.Limonciello@amd.com>
To: Philipp Zabel <philipp.zabel@gmail.com>
Cc: "rafael@kernel.org" <rafael@kernel.org>,
	"catalin@antebit.com" <catalin@antebit.com>,
	"S-k, Shyam-sundar" <Shyam-sundar.S-k@amd.com>,
	Len Brown <lenb@kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 0/4] Fixups for s2idle on ASUS Rembrandt laptop
Date: Mon, 12 Sep 2022 14:58:51 +0000	[thread overview]
Message-ID: <MN0PR12MB610147F4362BB95B7B5397B4E2449@MN0PR12MB6101.namprd12.prod.outlook.com> (raw)
In-Reply-To: <Yx9ItlBjl6bxxu2H@rog>

[AMD Official Use Only - General]



> -----Original Message-----
> From: Philipp Zabel <philipp.zabel@gmail.com>
> Sent: Monday, September 12, 2022 09:57
> To: Limonciello, Mario <Mario.Limonciello@amd.com>
> Cc: rafael@kernel.org; catalin@antebit.com; S-k, Shyam-sundar <Shyam-
> sundar.S-k@amd.com>; Len Brown <lenb@kernel.org>; linux-
> acpi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 0/4] Fixups for s2idle on ASUS Rembrandt laptop
> 
> Hi Mario,
> 
> Am Fri, Sep 09, 2022 at 01:05:05PM -0500 schrieb Mario Limonciello:
> > It was reported that an ASUS Rembrandt laptop has problems with
> seemingly
> > unrelated ACPI events after resuming from s2idle. Debugging the issue
> > proved it's because ASUS has ASL that is only called when using the
> > Microsoft GUID, not the AMD GUID.
> >
> > This is a bug from ASUS firmware but this series reworks the s2idle
> > handling for AMD to allow accounting for this in a quirk.
> >
> > Additionally as this is a problem that may pop up again on other models
> > add a module parameter that can be used to try the Microsoft GUID on a
> > given system.
> 
> thank you, these also helped on an ASUS ROG Zephyrus G14 (2022) with
> BIOS version GA402RJ.313. Patches 1-3
> 
> Tested-by: Philipp Zabel <philipp.zabel@gmail.com> # GA402RJ

Did you use acpi.prefer_microsoft_guid=1 for your system then too?

If so, I should re-spin this series to add your system's quirk to patch 4.

> 
> regards
> Philipp

  reply	other threads:[~2022-09-12 14:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-09 18:05 [PATCH 0/4] Fixups for s2idle on ASUS Rembrandt laptop Mario Limonciello
2022-09-09 18:05 ` [PATCH 1/4] acpi/x86: s2idle: Move _HID handling for AMD systems into structures Mario Limonciello
2022-09-09 18:05 ` [PATCH 2/4] acpi/x86: s2idle: If a new AMD _HID is missing assume Rembrandt Mario Limonciello
2022-09-09 18:05 ` [PATCH 3/4] acpi/x86: s2idle: Add module parameter to prefer Microsoft GUID Mario Limonciello
2022-09-09 18:05 ` [PATCH 4/4] acpi/x86: s2idle: Add a quirk for ASUS TUF Gaming A17 FA707RE Mario Limonciello
2022-09-12 14:59   ` Philipp Zabel
2022-09-17  7:35   ` Luke Jones
2022-09-17 13:26     ` Mario Limonciello
2022-09-12 14:56 ` [PATCH 0/4] Fixups for s2idle on ASUS Rembrandt laptop Philipp Zabel
2022-09-12 14:58   ` Limonciello, Mario [this message]
2022-09-12 15:06     ` Philipp Zabel
2022-09-12 15:11       ` Limonciello, Mario
2022-09-18  8:37       ` Luke Jones
2022-09-18 19:46         ` Mario Limonciello
2022-09-18 22:17           ` Luke Jones
2022-09-19 13:00             ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN0PR12MB610147F4362BB95B7B5397B4E2449@MN0PR12MB6101.namprd12.prod.outlook.com \
    --to=mario.limonciello@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=catalin@antebit.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philipp.zabel@gmail.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.