RE: [PATCH v6 2/5] regulator: max77541: Add ADI MAX77541/MAX77540 Regulator Support

["Sahin, Okan" <Okan.Sahin@analog.com>]

>On Tue, Mar 07, 2023 at 02:28:12PM +0300, Okan Sahin wrote:
>> Regulator driver for both MAX77541 and MAX77540.
>> The MAX77541 is a high-efficiency step-down converter with two 3A
>> switching phases for single-cell Li+ battery and 5VDC systems.
>>
>> The MAX77540 is a high-efficiency step-down converter with two 3A
>> switching phases.
>
>Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
>But see below.
>
>> Signed-off-by: Okan Sahin <okan.sahin@analog.com>
>> ---
>>  drivers/regulator/Kconfig              |   9 ++
>>  drivers/regulator/Makefile             |   1 +
>>  drivers/regulator/max77541-regulator.c | 153
>> +++++++++++++++++++++++++
>>  3 files changed, 163 insertions(+)
>>  create mode 100644 drivers/regulator/max77541-regulator.c
>>
>> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
>> index aae28d0a489c..f0418274c083 100644
>> --- a/drivers/regulator/Kconfig
>> +++ b/drivers/regulator/Kconfig
>> @@ -556,6 +556,15 @@ config REGULATOR_MAX597X
>>  	  The MAX5970/5978 is a smart switch with no output regulation, but
>>  	  fault protection and voltage and current monitoring capabilities.
>>
>> +config REGULATOR_MAX77541
>> +	tristate "Analog Devices MAX77541/77540 Regulator"
>> +	depends on MFD_MAX77541
>> +	help
>> +	  This driver controls a Analog Devices MAX77541/77540 regulators
>> +	  via I2C bus. Both MAX77540 and MAX77541 are dual-phase
>> +	  high-efficiency buck converter. Say Y here to
>> +	  enable the regulator driver.
>
>Maybe adding what would be the module name if M is chosen?
>
>>  config REGULATOR_MAX77620
>>  	tristate "Maxim 77620/MAX20024 voltage regulator"
>>  	depends on MFD_MAX77620 || COMPILE_TEST diff --git
>> a/drivers/regulator/Makefile b/drivers/regulator/Makefile index
>> ee383d8fc835..1c852f3140a3 100644
>> --- a/drivers/regulator/Makefile
>> +++ b/drivers/regulator/Makefile
>> @@ -68,6 +68,7 @@ obj-$(CONFIG_REGULATOR_LTC3676) += ltc3676.o
>>  obj-$(CONFIG_REGULATOR_MAX14577) += max14577-regulator.o
>>  obj-$(CONFIG_REGULATOR_MAX1586) += max1586.o
>>  obj-$(CONFIG_REGULATOR_MAX597X) += max597x-regulator.o
>> +obj-$(CONFIG_REGULATOR_MAX77541) += max77541-regulator.o
>>  obj-$(CONFIG_REGULATOR_MAX77620) += max77620-regulator.o
>>  obj-$(CONFIG_REGULATOR_MAX77650) += max77650-regulator.o
>>  obj-$(CONFIG_REGULATOR_MAX8649)	+= max8649.o
>> diff --git a/drivers/regulator/max77541-regulator.c
>> b/drivers/regulator/max77541-regulator.c
>> new file mode 100644
>> index 000000000000..f99caf3f3990
>> --- /dev/null
>> +++ b/drivers/regulator/max77541-regulator.c
>> @@ -0,0 +1,153 @@
>> +// SPDX-License-Identifier: GPL-2.0-or-later
>> +/*
>> + * Copyright (c) 2022 Analog Devices, Inc.
>> + * ADI Regulator driver for the MAX77540 and MAX77541  */
>
>I believe Mark asked to have this C++ comment style as well.
>
>// Copyright (c) 2022 Analog Devices, Inc.
>// ADI Regulator driver for the MAX77540 and MAX77541
>
>> +#include <linux/mfd/max77541.h>
>> +#include <linux/mod_devicetable.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/regmap.h>
>> +#include <linux/regulator/driver.h>
>> +
>> +static const struct regulator_ops max77541_buck_ops = {
>> +	.enable			= regulator_enable_regmap,
>> +	.disable		= regulator_disable_regmap,
>> +	.is_enabled		= regulator_is_enabled_regmap,
>> +	.list_voltage		= regulator_list_voltage_pickable_linear_range,
>> +	.get_voltage_sel	= regulator_get_voltage_sel_pickable_regmap,
>> +	.set_voltage_sel	= regulator_set_voltage_sel_pickable_regmap,
>> +};
>> +
>> +static const struct linear_range max77540_buck_ranges[] = {
>> +	/* Ranges when VOLT_SEL bits are 0x00 */
>> +	REGULATOR_LINEAR_RANGE(500000, 0x00, 0x8B, 5000),
>> +	REGULATOR_LINEAR_RANGE(1200000, 0x8C, 0xFF, 0),
>> +	/* Ranges when VOLT_SEL bits are 0x40 */
>> +	REGULATOR_LINEAR_RANGE(1200000, 0x00, 0x8B, 10000),
>> +	REGULATOR_LINEAR_RANGE(2400000, 0x8C, 0xFF, 0),
>> +	/* Ranges when VOLT_SEL bits are  0x80 */
>> +	REGULATOR_LINEAR_RANGE(2000000, 0x00, 0x9F, 20000),
>> +	REGULATOR_LINEAR_RANGE(5200000, 0xA0, 0xFF, 0), };
>> +
>> +static const struct linear_range max77541_buck_ranges[] = {
>> +	/* Ranges when VOLT_SEL bits are 0x00 */
>> +	REGULATOR_LINEAR_RANGE(300000, 0x00, 0xB3, 5000),
>> +	REGULATOR_LINEAR_RANGE(1200000, 0xB4, 0xFF, 0),
>> +	/* Ranges when VOLT_SEL bits are 0x40 */
>> +	REGULATOR_LINEAR_RANGE(1200000, 0x00, 0x8B, 10000),
>> +	REGULATOR_LINEAR_RANGE(2400000, 0x8C, 0xFF, 0),
>> +	/* Ranges when VOLT_SEL bits are  0x80 */
>> +	REGULATOR_LINEAR_RANGE(2000000, 0x00, 0x9F, 20000),
>> +	REGULATOR_LINEAR_RANGE(5200000, 0xA0, 0xFF, 0), };
>> +
>> +static const unsigned int max77541_buck_volt_range_sel[] = {
>> +	0x00, 0x00, 0x40, 0x40, 0x80, 0x80,
>> +};
>> +
>> +enum max77541_regulators {
>> +	MAX77541_BUCK1 = 1,
>> +	MAX77541_BUCK2,
>> +};
>> +
>> +#define MAX77540_BUCK(_id, _ops)					\
>> +	{	.id = MAX77541_BUCK ## _id,				\
>> +		.name = "buck"#_id,					\
>> +		.of_match = "buck"#_id,					\
>> +		.regulators_node = "regulators",			\
>> +		.enable_reg = MAX77541_REG_EN_CTRL,			\
>> +		.enable_mask = MAX77541_BIT_M ## _id ## _EN,		\
>> +		.ops = &(_ops),						\
>> +		.type = REGULATOR_VOLTAGE,				\
>> +		.linear_ranges = max77540_buck_ranges,			\
>> +		.n_linear_ranges = ARRAY_SIZE(max77540_buck_ranges),	\
>> +		.vsel_reg = MAX77541_REG_M ## _id ## _VOUT,		\
>> +		.vsel_mask = MAX77541_BITS_MX_VOUT,			\
>> +		.vsel_range_reg = MAX77541_REG_M ## _id ## _CFG1,	\
>> +		.vsel_range_mask = MAX77541_BITS_MX_CFG1_RNG,		\
>> +		.linear_range_selectors = max77541_buck_volt_range_sel, \
>> +		.owner = THIS_MODULE,					\
>> +	}
>> +
>> +#define MAX77541_BUCK(_id, _ops)					\
>> +	{	.id = MAX77541_BUCK ## _id,				\
>> +		.name = "buck"#_id,					\
>> +		.of_match = "buck"#_id,					\
>> +		.regulators_node = "regulators",			\
>> +		.enable_reg = MAX77541_REG_EN_CTRL,			\
>> +		.enable_mask = MAX77541_BIT_M ## _id ## _EN,		\
>> +		.ops = &(_ops),						\
>> +		.type = REGULATOR_VOLTAGE,				\
>> +		.linear_ranges = max77541_buck_ranges,			\
>> +		.n_linear_ranges = ARRAY_SIZE(max77541_buck_ranges),	\
>> +		.vsel_reg = MAX77541_REG_M ## _id ## _VOUT,		\
>> +		.vsel_mask = MAX77541_BITS_MX_VOUT,			\
>> +		.vsel_range_reg = MAX77541_REG_M ## _id ## _CFG1,	\
>> +		.vsel_range_mask = MAX77541_BITS_MX_CFG1_RNG,		\
>> +		.linear_range_selectors = max77541_buck_volt_range_sel, \
>> +		.owner = THIS_MODULE,					\
>> +	}
>> +
>> +static const struct regulator_desc max77540_regulators_desc[] = {
>> +	MAX77540_BUCK(1, max77541_buck_ops),
>> +	MAX77540_BUCK(2, max77541_buck_ops), };
>> +
>> +static const struct regulator_desc max77541_regulators_desc[] = {
>> +	MAX77541_BUCK(1, max77541_buck_ops),
>> +	MAX77541_BUCK(2, max77541_buck_ops), };
>> +
>> +static int max77541_regulator_probe(struct platform_device *pdev) {
>> +	struct regulator_config config = {};
>> +	const struct regulator_desc *desc;
>> +	struct device *dev = &pdev->dev;
>> +	struct regulator_dev *rdev;
>> +	struct max77541 *max77541 = dev_get_drvdata(dev->parent);
>> +	unsigned int i;
>> +
>> +	config.dev = dev->parent;
>> +
>> +	switch (max77541->chip->id) {
>> +	case MAX77540:
>> +		desc = max77540_regulators_desc;
>> +		break;
>> +	case MAX77541:
>> +		desc = max77541_regulators_desc;
>> +		break;
>> +	default:
>> +		return -EINVAL;
>> +	}
>> +
>> +	for (i = 0; i < MAX77541_MAX_REGULATORS; i++) {
>> +		rdev = devm_regulator_register(dev, &desc[i], &config);
>> +		if (IS_ERR(rdev))
>> +			return dev_err_probe(dev, PTR_ERR(rdev),
>> +					     "Failed to register regulator\n");
>> +	}
>> +
>> +	return 0;
>> +}
>> +
>> +static const struct platform_device_id max77541_regulator_platform_id[] = {
>> +	{ "max77540-regulator" },
>> +	{ "max77541-regulator" },
>> +	{ }
>> +};
>> +MODULE_DEVICE_TABLE(platform, max77541_regulator_platform_id);
>> +
>> +static struct platform_driver max77541_regulator_driver = {
>> +	.driver = {
>> +		.name = "max77541-regulator",
>> +	},
>> +	.probe = max77541_regulator_probe,
>> +	.id_table = max77541_regulator_platform_id, };
>> +module_platform_driver(max77541_regulator_driver);
>> +
>> +MODULE_AUTHOR("Okan Sahin <Okan.Sahin@analog.com>");
>> +MODULE_DESCRIPTION("MAX77540/MAX77541 regulator driver");
>> +MODULE_LICENSE("GPL");
>> --
>> 2.30.2
>>
>
>--
>With Best Regards,
>Andy Shevchenko
>

Hi Andy,

Should I change comment style to C++ comment style for whole patchset?

Regards,
Okan