From: Dmitry Fomichev <Dmitry.Fomichev@wdc.com>
To: Klaus Jensen <its@irrelevant.dk>
Cc: "fam@euphon.net" <fam@euphon.net>,
"kwolf@redhat.com" <kwolf@redhat.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"k.jensen@samsung.com" <k.jensen@samsung.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"mreitz@redhat.com" <mreitz@redhat.com>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"javier.gonz@samsung.com" <javier.gonz@samsung.com>,
"mlevitsk@redhat.com" <mlevitsk@redhat.com>,
"philmd@redhat.com" <philmd@redhat.com>
Subject: RE: [PATCH v3 01/18] hw/block/nvme: bump spec data structures to v1.3
Date: Wed, 8 Jul 2020 21:47:12 +0000 [thread overview]
Message-ID: <MN2PR04MB59518B3ACCDC857E87D0417DE1670@MN2PR04MB5951.namprd04.prod.outlook.com> (raw)
In-Reply-To: <20200708212404.GA1018121@apples.localdomain>
> -----Original Message-----
> From: Klaus Jensen <its@irrelevant.dk>
> Sent: Wednesday, July 8, 2020 5:24 PM
> To: Dmitry Fomichev <Dmitry.Fomichev@wdc.com>
> Cc: qemu-block@nongnu.org; qemu-devel@nongnu.org; fam@euphon.net;
> javier.gonz@samsung.com; kwolf@redhat.com; mreitz@redhat.com;
> mlevitsk@redhat.com; philmd@redhat.com; kbusch@kernel.org;
> k.jensen@samsung.com
> Subject: Re: [PATCH v3 01/18] hw/block/nvme: bump spec data structures to
> v1.3
>
> On Jul 8 19:19, Dmitry Fomichev wrote:
> > Looks good with a small nit (see below),
> >
> > Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
> >
> > >
> > On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote:
> > > +#define NVME_TEMP_TMPTH(temp) ((temp >> 0) & 0xffff)
> >
> > There is an extra space after temp >>
> >
>
> Good catch! I won't repost for this ;) - but I'll fix it and add it in
> the qemu-nvme tree.
Yes, no need to repost :) Thanks for reviewing our ZNS series! I am working
on addressing your comments and I am also starting to review your
"AIO and address mapping refactoring" patchset.
Cheers,
Dmitry
next prev parent reply other threads:[~2020-07-08 22:22 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 6:12 [PATCH v3 00/18] hw/block/nvme: bump to v1.3 Klaus Jensen
2020-07-06 6:12 ` [PATCH v3 01/18] hw/block/nvme: bump spec data structures " Klaus Jensen
2020-07-08 19:19 ` Dmitry Fomichev
2020-07-08 21:24 ` Klaus Jensen
2020-07-08 21:47 ` Dmitry Fomichev [this message]
2020-07-09 6:17 ` Klaus Jensen
2020-07-06 6:12 ` [PATCH v3 02/18] hw/block/nvme: fix missing endian conversion Klaus Jensen
2020-07-06 9:50 ` Philippe Mathieu-Daudé
2020-07-08 19:20 ` Dmitry Fomichev
2020-07-29 8:49 ` Maxim Levitsky
2020-07-06 6:12 ` [PATCH v3 03/18] hw/block/nvme: additional tracing Klaus Jensen
2020-07-06 9:50 ` Philippe Mathieu-Daudé
2020-07-08 19:21 ` Dmitry Fomichev
2020-07-29 8:52 ` Maxim Levitsky
2020-07-06 6:12 ` [PATCH v3 04/18] hw/block/nvme: add support for the abort command Klaus Jensen
2020-07-06 6:12 ` [PATCH v3 05/18] hw/block/nvme: add temperature threshold feature Klaus Jensen
2020-07-08 19:24 ` Dmitry Fomichev
2020-07-06 6:12 ` [PATCH v3 06/18] hw/block/nvme: mark fw slot 1 as read-only Klaus Jensen
2020-07-29 9:14 ` Maxim Levitsky
2020-07-06 6:12 ` [PATCH v3 07/18] hw/block/nvme: add support for the get log page command Klaus Jensen
2020-07-08 19:22 ` Dmitry Fomichev
2020-07-29 10:24 ` Maxim Levitsky
2020-07-29 11:44 ` Klaus Jensen
2020-07-29 18:35 ` Maxim Levitsky
2020-09-29 13:11 ` Peter Maydell
2020-09-29 21:46 ` Klaus Jensen
2020-09-29 22:34 ` Keith Busch
2020-09-29 22:42 ` Klaus Jensen
2020-09-29 22:57 ` Keith Busch
2020-07-06 6:12 ` [PATCH v3 08/18] hw/block/nvme: add support for the asynchronous event request command Klaus Jensen
2020-07-29 10:43 ` Maxim Levitsky
2020-07-29 13:37 ` Klaus Jensen
2020-07-29 18:45 ` Maxim Levitsky
2020-07-29 20:08 ` Klaus Jensen
2020-07-30 8:50 ` Maxim Levitsky
2020-07-06 6:12 ` [PATCH v3 09/18] hw/block/nvme: move NvmeFeatureVal into hw/block/nvme.h Klaus Jensen
2020-07-29 10:46 ` Maxim Levitsky
2020-07-06 6:12 ` [PATCH v3 10/18] hw/block/nvme: flush write cache when disabled Klaus Jensen
2020-07-29 11:03 ` Maxim Levitsky
2020-07-06 6:12 ` [PATCH v3 11/18] hw/block/nvme: add remaining mandatory controller parameters Klaus Jensen
2020-07-29 11:31 ` Maxim Levitsky
2020-07-06 6:12 ` [PATCH v3 12/18] hw/block/nvme: support the get/set features select and save fields Klaus Jensen
2020-07-08 19:25 ` Dmitry Fomichev
2020-07-29 13:17 ` Maxim Levitsky
2020-07-29 13:48 ` Klaus Jensen
2020-07-29 18:47 ` Maxim Levitsky
2020-07-06 6:12 ` [PATCH v3 13/18] hw/block/nvme: make sure ncqr and nsqr is valid Klaus Jensen
2020-07-06 6:12 ` [PATCH v3 14/18] hw/block/nvme: support identify namespace descriptor list Klaus Jensen
2020-07-29 13:25 ` Maxim Levitsky
2020-07-06 6:13 ` [PATCH v3 15/18] hw/block/nvme: reject invalid nsid values in active namespace id list Klaus Jensen
2020-07-06 9:47 ` Philippe Mathieu-Daudé
2020-07-08 19:26 ` Dmitry Fomichev
2020-07-29 13:27 ` Maxim Levitsky
2020-07-06 6:13 ` [PATCH v3 16/18] hw/block/nvme: enforce valid queue creation sequence Klaus Jensen
2020-07-06 6:13 ` [PATCH v3 17/18] hw/block/nvme: provide the mandatory subnqn field Klaus Jensen
2020-07-06 9:47 ` Philippe Mathieu-Daudé
2020-07-08 19:26 ` Dmitry Fomichev
2020-07-29 13:34 ` Maxim Levitsky
2020-07-06 6:13 ` [PATCH v3 18/18] hw/block/nvme: bump supported version to v1.3 Klaus Jensen
2020-07-20 9:13 ` [PATCH v3 00/18] hw/block/nvme: bump " Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR04MB59518B3ACCDC857E87D0417DE1670@MN2PR04MB5951.namprd04.prod.outlook.com \
--to=dmitry.fomichev@wdc.com \
--cc=fam@euphon.net \
--cc=its@irrelevant.dk \
--cc=javier.gonz@samsung.com \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.