All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avri Altman <Avri.Altman@wdc.com>
To: Can Guo <cang@codeaurora.org>,
	"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
	"nguyenb@codeaurora.org" <nguyenb@codeaurora.org>,
	"hongwus@codeaurora.org" <hongwus@codeaurora.org>,
	"rnayak@codeaurora.org" <rnayak@codeaurora.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"kernel-team@android.com" <kernel-team@android.com>,
	"saravanak@google.com" <saravanak@google.com>,
	"salyzyn@google.com" <salyzyn@google.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Bean Huo <beanhuo@micron.com>,
	Stanley Chu <stanley.chu@mediatek.com>,
	Bart Van Assche <bvanassche@acm.org>,
	Venkat Gopalakrishnan <venkatg@codeaurora.org>,
	Tomas Winkler <tomas.winkler@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Pedro Sousa <sousa@synopsys.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v7 8/8] scsi: ufs: Select INITIAL adapt for HS Gear4
Date: Thu, 6 Feb 2020 13:20:07 +0000	[thread overview]
Message-ID: <MN2PR04MB6991EA027BB31FA58EEBDA81FC1D0@MN2PR04MB6991.namprd04.prod.outlook.com> (raw)
In-Reply-To: <1580978008-9327-9-git-send-email-cang@codeaurora.org>

Hi Can,

 
> ADAPT is added specifically for HS Gear4 mode only, select INITIAL adapt
> before do power mode change to G4 and select no adapt before switch to
> non-G4 modes.

UFSHCI 3.0 says:
7.4.1 Adapt
The use of Adapt isn't mandatory but the specification provides some guidelines on its use.
The HCI should perform an Initial Adapt in the following cases if the link is running at HS-G4
speed:
 - If DME_RESET is initiated.
 - If an unused line is activated for HS-G4.
 - If UECDME.EC is triggered with bit 3 set to '1'.
 - If a change between Rate A and Rate B in HS-G4 is performed.

If it's not mandatory - why are we setting this for all vendors on all platforms?
Or am I miss-reading the spec?

Thanks,
Avri

  reply	other threads:[~2020-02-06 13:20 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-06  8:33 [PATCH v7 0/8] UFS driver general fixes bundle 4 Can Guo
2020-02-06  8:33 ` [PATCH v7 1/8] scsi: ufs: Flush exception event before suspend Can Guo
2020-02-06  8:33 ` [PATCH v7 2/8] scsi: ufs: set load before setting voltage in regulators Can Guo
2020-02-06  8:33   ` Can Guo
2020-02-06  8:33   ` Can Guo
2020-02-06  8:33 ` [PATCH v7 3/8] scsi: ufs: Remove the check before call setup clock notify vops Can Guo
2020-02-06  8:33   ` Can Guo
2020-02-06  8:33   ` Can Guo
2020-02-06  8:33 ` [PATCH v7 4/8] scsi: ufs-qcom: Adjust bus bandwidth voting and unvoting Can Guo
2020-02-06  8:33 ` [PATCH v7 5/8] scsi: ufs: Fix ufshcd_hold() caused scheduling while atomic Can Guo
2020-02-06  8:33   ` Can Guo
2020-02-06  8:33   ` Can Guo
2020-02-06 10:28   ` Avri Altman
2020-02-06 10:28     ` Avri Altman
2020-02-06 10:28     ` Avri Altman
2020-02-10  1:28     ` Can Guo
2020-02-10  1:28       ` Can Guo
2020-02-10  1:28       ` Can Guo
2020-02-10  1:59       ` Can Guo
2020-02-10  1:59         ` Can Guo
2020-02-10  1:59         ` Can Guo
2020-02-10  8:23         ` Avri Altman
2020-02-10  8:23           ` Avri Altman
2020-02-10  8:23           ` Avri Altman
2020-02-06  8:33 ` [PATCH v7 6/8] scsi: ufs: Add dev ref clock gating wait time support Can Guo
2020-02-06  8:33   ` Can Guo
2020-02-06  8:33   ` Can Guo
2020-02-06  8:33 ` [PATCH v7 7/8] scsi: ufs-qcom: Delay specific time before gate ref clk Can Guo
2020-02-06 20:33   ` Bjorn Andersson
2020-02-07  1:09     ` Can Guo
2020-02-07  2:10       ` Bjorn Andersson
2020-02-08  0:10         ` Can Guo
2020-02-06  8:33 ` [PATCH v7 8/8] scsi: ufs: Select INITIAL adapt for HS Gear4 Can Guo
2020-02-06 13:20   ` Avri Altman [this message]
2020-02-07  2:56     ` Can Guo
2020-02-07  5:10       ` Can Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR04MB6991EA027BB31FA58EEBDA81FC1D0@MN2PR04MB6991.namprd04.prod.outlook.com \
    --to=avri.altman@wdc.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=hongwus@codeaurora.org \
    --cc=jejb@linux.ibm.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nguyenb@codeaurora.org \
    --cc=rnayak@codeaurora.org \
    --cc=salyzyn@google.com \
    --cc=saravanak@google.com \
    --cc=sousa@synopsys.com \
    --cc=stanley.chu@mediatek.com \
    --cc=tglx@linutronix.de \
    --cc=tomas.winkler@intel.com \
    --cc=venkatg@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.