From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7727DC433FE for ; Wed, 6 Oct 2021 15:46:14 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 06BC3610A5 for ; Wed, 6 Oct 2021 15:46:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 06BC3610A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20A4641175; Wed, 6 Oct 2021 17:46:13 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 3380141164 for ; Wed, 6 Oct 2021 17:46:11 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10129"; a="225972414" X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="225972414" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 08:45:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="560223125" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by FMSMGA003.fm.intel.com with ESMTP; 06 Oct 2021 08:45:48 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 6 Oct 2021 08:45:47 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 6 Oct 2021 08:45:47 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.46) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 6 Oct 2021 08:45:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UYPz6k8uCo0bCZTs6p8UCr3Ba1kKhoezGmtjFWojopZJlRzDjQchTYWQD0vHhQXt9O1cI+lTtDqQmQCTBzVZV+d5L+wJ+w4K0ru0xLjBnd+dOezknDVe1wjnUf7yIBmqlbZW0t+TV0v2YHhEgn4CJEV6eJKDgkuYWmj0iT4o0kDqSeDX1NhdnP6NnsAvNNyBQzTvykWLGGTgFmO7zm0pMaQQGat9VKuPDLUZlNBVuGENKD4k93xfalkHzTBTalq5jKeI6LsQie9BOu1AagUXrtiq5iDIiVBzUXFr5qp+xblh66LB4dejtThdt4jadAvsOjypYd/j/pmVtu/EdtYM3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X8gBqlPtcAVEykADY+l8t9OkZ0Mksmb9reaVOrf9bpU=; b=myH4biPAD1b93uN1wJ76qllcHHl9KyyYU/uoirjqf10EmvKtBAWwpIrlGDJWST2gy4g9WFLUS28lwyylHuUWw4PQu2u3JvCWVVxJPeqivgjnFITPyRI7L2wlAgUvCrUdh2yHD2jUiUE4DQiujENPg2kvJf7n4ZMYw+XN+mb+Blza/x6MQ/2/olOVTRfYvM+rx9ktXIjv+BBnnHYq/qbdT3UqZ8BrWzuwsboYmfgeVXA9nJYw3CEwXj2rPfNLQtUhVyeAfj2IsrqVV4eLIbBcg5QtZZE05H8/PrU3rc+qcCU9M2sAB8lZTJj1B672BR5JGXAXSDsT1HAx6Pf9z2xb7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X8gBqlPtcAVEykADY+l8t9OkZ0Mksmb9reaVOrf9bpU=; b=DHpazd9ahF5fxFKJ3DelGU+mF05+oD/ZMmVCp+nPsWKlyQGl86goaG7VXDNqgf3g6wJ+QIX+yY6eMiqKirvq8IZTu1QyNI8BQd/uq6SkhrISK2GlB3EzARBpt8d5a+236dHM+kkIPXjbMKo+/zqtGr0Uq0WFuQHoNj9pz5v3dI4= Received: from MN2PR11MB3821.namprd11.prod.outlook.com (2603:10b6:208:f7::24) by BL3PR11MB5745.namprd11.prod.outlook.com (2603:10b6:208:352::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.17; Wed, 6 Oct 2021 15:45:46 +0000 Received: from MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2]) by MN2PR11MB3821.namprd11.prod.outlook.com ([fe80::304c:39f1:9d95:4ba2%6]) with mapi id 15.20.4566.023; Wed, 6 Oct 2021 15:45:46 +0000 From: "Power, Ciara" To: Akhil Goyal , "dev@dpdk.org" CC: "Zhang, Roy Fan" , "Bronowski, PiotrX" , Thomas Monjalon , "De Lara Guarch, Pablo" , Ray Kinsella Thread-Topic: [EXT] [PATCH v3 01/10] drivers/crypto: introduce IPsec-mb framework Thread-Index: AQHXtU9jtzLDY6OtU0GanQGx1JyQ46vGB7qAgAAeG6A= Date: Wed, 6 Oct 2021 15:45:46 +0000 Message-ID: References: <20210727083832.291687-1-roy.fan.zhang@intel.com> <20210929163035.608387-1-ciara.power@intel.com> <20210929163035.608387-2-ciara.power@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 024728e0-e217-4f99-3e42-08d988e05d17 x-ms-traffictypediagnostic: BL3PR11MB5745: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dzvytZWMRlJ/BRalN4RgBBIFIjQUQXHkkpaIbXb1HTW8Vaseg3I07Z8RZOjGfjLEpjD6AESSYSgO/acqrWjK1Xg2sXN4qrjr6I6kDrsNRJVegCHgJ6KtB0yUGRO7PuCZInHiWVMjoVlHOjwdFxAROEUR+Kr27F0WwbP9guBPrWNggYC/J0NmpZIlsV8w218hYKhYYnW2xUrtwt29FB+b9CM5LLnCHyAhueL+uOfPsAEeXbDtglDNkgUE/2KWROkW2lRJpN/6VZoXoLQpSbxbqDADSQciTwFGVi1sQPGmVnfXfwbrTji9Y8bQcTb02EoBloyuSUBFgNncxQiD+o4MUMCfUOpJwmWXrVnu62rxCToaX9O66NTUNPBoYzlOMDom+VleXycEcbq16q8r8RdOIL7dzDH5S8ulW+X6VJsbzwsEVxZgxt2Z7+CSNYvMgvpx7kzpf/Ar/bnO1+JlB3a4AlJUWsM9awLHOeTKAltmwernfI6+hr8qrSVNxuFBAgtdsuVi2/guH3SaKaaTWTVR/f2AWLwP2z1CXq2YjE6EqUF9v1ELt7N6mpLnNICTxvRwaDTV32M3b+BUujamYZisahM0bSavLnB9V5kJcmwp72Hw6P/opd1Y53+KPi1hFsdVk55goLvuBEzyeq0NzT6+kxWD5onOkJ/nYZEt8F5PL0v5fe+wirgqNA/T6D8r2hHOQnvvg5n9K9UpJFt7H0WFCg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB3821.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(71200400001)(38070700005)(26005)(508600001)(6506007)(2906002)(86362001)(316002)(76116006)(54906003)(186003)(5660300002)(38100700002)(55016002)(8676002)(110136005)(52536014)(66446008)(64756008)(83380400001)(66556008)(66476007)(66946007)(33656002)(4326008)(8936002)(9686003)(7696005)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PveKWC7NyYxMrvP+nu3escvD/ytX1h8qqbL8Wrn4DWqYaZ5k5gwGDvzbpO5W?= =?us-ascii?Q?hhwFZltLRAEDcBEbJTX6P2qx3v/CkeTnC+HiS47rRdUgqoUAyqbhX+IZYMck?= =?us-ascii?Q?trUsFPtY0Sb7y8PXnUODZk6KgCnWpwHtZ0zO9fxT88lXTC5PqeJGqSNvOWID?= =?us-ascii?Q?eLZyOlI0+Z30guk7ysc+440v4yrrlj8AQcFQozpl52vimVFaTvTBFVMc8CLN?= =?us-ascii?Q?jjdLNZiHOQJ0QXMX7fKhz010Esg+ngTT0B8G3z12L584MBDtOqJhZFPKmWCs?= =?us-ascii?Q?YMRnomHrzVydDBZMC0G4B2kTKCs3028YwqJAXIr+GB7ihqgXx08kJ3kiBjJh?= =?us-ascii?Q?0GwhsfIcSehhtRxKLZDJEXFesV/D4u7r5g39W/OtFyHrpXyXvqPIQcXIxYCA?= =?us-ascii?Q?nqqYezvmCU+dphoKsY+XLGfslgnGjgTEzkSOkrBhH+apyaMkt0ks0VL+zP7X?= =?us-ascii?Q?PQQPGHrI3Ttlba3ILZgQaJu9zu8Qa/MxwW9n1ci7/YQ/m9rgvedXmdG000vb?= =?us-ascii?Q?0HSZytb5FotjP8RF4R54gKC3Lld24oLyBC63JapHOnasx+8mn4rzE7zO6yn2?= =?us-ascii?Q?QweK61bDMr9Pus64S/5650GZIzyoOdhAHue58MD4D7XBBg5RW5ZRQRqKmQLI?= =?us-ascii?Q?oUBD5P1cHl7aiGs/KyZV6sa6G5nHQMlQuu8boiEAHPNOBpKJ9c0eta78vwqJ?= =?us-ascii?Q?VOTb8jfxPVXKVQNiiSYQPZIlQem+P+ndovVo5ksHxf8e4wPOq37FnkdpWgDz?= =?us-ascii?Q?MOhA+Q2K07Y0yAxNc6jli7zT59hslb9W1ML8P8vl3LvrYu+CCD5fEukEL8qi?= =?us-ascii?Q?LDfss4rnbWCQ9wLiObOsOqSsze3eKU6Sf80cJQpuslSiRnmcOAhlPPhv/h6g?= =?us-ascii?Q?nOycYtlGgQ8ZiuGAUoE/Ig1LM2DJqKB8yQV+ZuV+gIsO/2He2rmUqEUyMI2U?= =?us-ascii?Q?kZwUzexvxL5WIlsdOCjgINASkL/JtntaL5/d80+/K7t6Yj3ThpWafO2ExEiT?= =?us-ascii?Q?+Hy9085m2O8OU9azcvkRpU0Y7h566Rh0skBToV0/Ud6QhHGkTvjSGKRDnqEh?= =?us-ascii?Q?25nVLZr07mfey87DsMD6X5nd2HqQXey0jq+OGN52v3Jh8NW+fH2WdTGVVilg?= =?us-ascii?Q?Dn1rrGnQztk/xY2HeP361bZsqYGZfzHvQENI7cSeD7IgDCgJcCYQESegrDGX?= =?us-ascii?Q?JRr/uxUfGirCmkrT4VXi9lBfrXF/xuZghFiMa4yM86QXBakceJ40qPxdlDrE?= =?us-ascii?Q?l16/nx+XzB6L05CyOoupDgt45HUGpmje8Ser9Z9UMxLHR76Q4uBmfYkzN4qL?= =?us-ascii?Q?cbE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 024728e0-e217-4f99-3e42-08d988e05d17 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2021 15:45:46.4242 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 25WxzMpGqaNjpVi+Iuz/GN20VkJsJrVm3w1jJ6bNneToOZG+ItbklvkgE3WCJMsGQsUCn/05X2i8Y6ibiDqjlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB5745 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] [PATCH v3 01/10] drivers/crypto: introduce IPsec-mb framework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, >-----Original Message----- >From: Akhil Goyal >Sent: Wednesday 6 October 2021 14:51 >To: Power, Ciara ; dev@dpdk.org >Cc: Zhang, Roy Fan ; Bronowski, PiotrX >; Thomas Monjalon ; De >Lara Guarch, Pablo ; Ray Kinsella > >Subject: RE: [EXT] [PATCH v3 01/10] drivers/crypto: introduce IPsec-mb >framework > >> From: Fan Zhang >> >> This patch introduces the new framework to share common code between >> the SW crypto PMDs that depend on the intel-ipsec-mb library. >> This change helps to reduce future effort on the code maintenance and >> feature updates. >> >> The PMDs that will be added to this framework in subsequent patches are: >> - AESNI MB >> - AESNI GCM >> - KASUMI >> - SNOW3G >> - ZUC >> >> The use of these PMDs will not change, they will still be supported >> for x86, and will use the same EAL args as before. >> >> The minimum required version for the intel-ipsec-mb library is now v1.0. >> >> Signed-off-by: Fan Zhang >> Signed-off-by: Ciara Power >> >> --- >> v3: >> - Updated intel-ipsec-mb macros. >> - Added use of auto init function for IMB_MGR. >> - Added detail to commit log. >> v2: >> - Added qp NULL check in get stats function. >> - Added maintainers file entry. >> - Replaced strlcpy with rte_strlcpy. >> --- >> MAINTAINERS | 4 + >> drivers/crypto/ipsec_mb/meson.build | 27 ++ >> drivers/crypto/ipsec_mb/rte_ipsec_mb_pmd.c | 169 ++++++++++ >> .../crypto/ipsec_mb/rte_ipsec_mb_pmd_ops.c | 291 ++++++++++++++++++ >> .../ipsec_mb/rte_ipsec_mb_pmd_private.h | 275 +++++++++++++++++ >> drivers/crypto/ipsec_mb/version.map | 3 + >> drivers/crypto/meson.build | 1 + >> 7 files changed, 770 insertions(+) >> create mode 100644 drivers/crypto/ipsec_mb/meson.build >> create mode 100644 drivers/crypto/ipsec_mb/rte_ipsec_mb_pmd.c >> create mode 100644 drivers/crypto/ipsec_mb/rte_ipsec_mb_pmd_ops.c >> create mode 100644 drivers/crypto/ipsec_mb/rte_ipsec_mb_pmd_private.h >> create mode 100644 drivers/crypto/ipsec_mb/version.map >> >> diff --git a/MAINTAINERS b/MAINTAINERS index 1e0d303394..f1aaf7d408 >> 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -1065,6 +1065,10 @@ F: drivers/common/qat/ >> F: doc/guides/cryptodevs/qat.rst >> F: doc/guides/cryptodevs/features/qat.ini >> >> +IPsec MB > >Not sure if the name ipsec_mb is appropriate for a crypto PMD which also >support algos which are not specified for IPsec like ZUC/SNOW/KASUMI. >Moreover, this is a crypto PMD and not IPsec PMD. > >> +/** Get device statistics */ >> +void >> +ipsec_mb_pmd_stats_get(struct rte_cryptodev *dev, >> + struct rte_cryptodev_stats *stats) > >I believe 1 instance of the ipsec_mb PMD will support only one kind of >operation(aesni_mb/aesni_gcm/zuc/snow/kasumi). >This cannot be changed during the lifetime of the process. Right? > Yes - please treat the ipsec_mb_pmd.c/pmd_ops.c as the shared code base for= these existing SW crypto PMDs based on intel-ipsec-mb library. There is no= new PMD called ipsec_mb as such. Maybe to make it less misleading we could rename the file names like so: Ipsec_mb_pmd.c -> ipsec_mb_private.c And similar change for ipsec_mb_pmd_ops.c and ipsec_mb_pmd_private.h What do you think? Thanks, Ciara