All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chen, Hongzhan" <hongzhan.chen@intel.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	"xenomai@xenomai.org" <xenomai@xenomai.org>
Subject: RE: [PATCH v3] utils: add kernel config check utility
Date: Tue, 26 Oct 2021 01:14:32 +0000	[thread overview]
Message-ID: <MN2PR11MB4285FACC48571DB0F9AC9693F2849@MN2PR11MB4285.namprd11.prod.outlook.com> (raw)
In-Reply-To: <8143c260-1611-d68a-ae08-705c6a927576@siemens.com>


>
>-----Original Message-----
>From: Jan Kiszka <jan.kiszka@siemens.com> 
>Sent: Friday, October 22, 2021 12:37 AM
>To: Chen, Hongzhan <hongzhan.chen@intel.com>; xenomai@xenomai.org
>Subject: Re: [PATCH v3] utils: add kernel config check utility
>
>On 20.10.21 10:06, Hongzhan Chen wrote:
>> diff --git a/utils/chkkconf/Makefile.am b/utils/chkkconf/Makefile.am
>> new file mode 100644
>> index 000000000..3befee7f1
>> --- /dev/null
>> +++ b/utils/chkkconf/Makefile.am
>> @@ -0,0 +1,20 @@
>> +
>> +data_DATA = kconf-checklist
>> +
>> +CCLD = $(top_srcdir)/scripts/wrap-link.sh $(CC)
>> +
>> +sbin_PROGRAMS = chkkconf
>> +
>> +chkkconf_SOURCES = checkconfig.c
>> +
>> +chkkconf_CPPFLAGS = 		\
>> +	$(XENO_USER_CFLAGS)	\
>> +	-I$(top_srcdir)/include \
>
>Both not needed, see below.
>
>> +	-DTESTDIR=\"$(datadir)\" -D_GNU_SOURCE
>
>Renaming this to "DATADIR", to be consistent.
>
>> +
>> +chkkconf_LDFLAGS = @XENO_AUTOINIT_LDFLAGS@ $(XENO_POSIX_WRAPPERS)
>> +
>
>Unneeded - no Xenomai program. And dropping that actually obsoletes
>application_usage(), get_program_name etc. Sorry, didn't realized before.
>
>> +chkkconf_LDADD =					\
>> +	 @XENO_CORE_LDADD@			\
>> +	 @XENO_USER_LDADD@			\
>> +	-lpthread -lrt
>
>Not needed anymore.
>
>I've applied the patch with those changes (and related ones in the
>source code). Please double check.

Thanks for your modification. I did not realize that they are unneeded for no xenomai program and
that was my fault.

Regards

Hongzhan Chen
>
>Thanks,
>Jan
>
>-- 
>Siemens AG, T RDA IOT
>Corporate Competence Center Embedded Linux

      reply	other threads:[~2021-10-26  1:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20  8:06 [PATCH v3] utils: add kernel config check utility Hongzhan Chen
2021-10-21 16:37 ` Jan Kiszka
2021-10-26  1:14   ` Chen, Hongzhan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB4285FACC48571DB0F9AC9693F2849@MN2PR11MB4285.namprd11.prod.outlook.com \
    --to=hongzhan.chen@intel.com \
    --cc=jan.kiszka@siemens.com \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.