All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tan, Ley Foon <ley.foon.tan@intel.com>
To: u-boot@lists.denx.de
Subject: [PATCH 03/12] i2c: designware_i2c: Include clk.h in the header file
Date: Mon, 23 Dec 2019 08:17:05 +0000	[thread overview]
Message-ID: <MN2PR11MB4509051BB88647501974EC4DCC2E0@MN2PR11MB4509.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20191221161525.27976-4-sjg@chromium.org>



> -----Original Message-----
> From: Simon Glass <sjg@chromium.org>
> Sent: Sunday, December 22, 2019 12:15 AM
> To: U-Boot Mailing List <u-boot@lists.denx.de>
> Cc: Jun Chen <ptchentw@gmail.com>; Heiko Schocher <hs@denx.de>; Tan,
> Ley Foon <ley.foon.tan@intel.com>; Simon Glass <sjg@chromium.org>
> Subject: [PATCH 03/12] i2c: designware_i2c: Include clk.h in the header file
> 
> We use struct clk here so really should include this header file to avoid build
> errors. Also switch the order of clk.h in the C file to match the required code
> style.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Ley Foon Tan <ley.foon.tan@intel.com>
> ---
> 
>  drivers/i2c/designware_i2c.c | 2 +-
>  drivers/i2c/designware_i2c.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/designware_i2c.c b/drivers/i2c/designware_i2c.c
> index b8cdd1c661..138fc72561 100644
> --- a/drivers/i2c/designware_i2c.c
> +++ b/drivers/i2c/designware_i2c.c
> @@ -4,8 +4,8 @@
>   * Vipin Kumar, ST Micoelectronics, vipin.kumar at st.com.
>   */
> 
> -#include <clk.h>
>  #include <common.h>
> +#include <clk.h>
>  #include <dm.h>
>  #include <i2c.h>
>  #include <pci.h>
> diff --git a/drivers/i2c/designware_i2c.h b/drivers/i2c/designware_i2c.h
> index 0eb28191d2..39e62bcf51 100644
> --- a/drivers/i2c/designware_i2c.h
> +++ b/drivers/i2c/designware_i2c.h
> @@ -7,6 +7,7 @@
>  #ifndef __DW_I2C_H_
>  #define __DW_I2C_H_
> 
> +#include <clk.h>
>  #include <reset.h>
> 
>  struct i2c_regs {
> --
> 2.24.1.735.g03f4e72817-goog

  reply	other threads:[~2019-12-23  8:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-21 16:15 [PATCH 00/12] i2c: designware_ic2: Improvements to timing Simon Glass
2019-12-21 16:15 ` [PATCH 01/12] i2c: designware_i2c: Add more registers Simon Glass
2019-12-23  8:15   ` Tan, Ley Foon
2019-12-25 10:20     ` pt
2019-12-21 16:15 ` [PATCH 02/12] i2c: designware_i2c: Don't allow changing IC_CLK Simon Glass
2019-12-21 16:15 ` [PATCH 03/12] i2c: designware_i2c: Include clk.h in the header file Simon Glass
2019-12-23  8:17   ` Tan, Ley Foon [this message]
2019-12-21 16:15 ` [PATCH 04/12] i2c: designware_i2c: Rename 'max' speed to 'high' speed Simon Glass
2019-12-21 16:15 ` [PATCH 05/12] i2c: designware_i2c: Use an enum for selected speed mode Simon Glass
2019-12-21 16:15 ` [PATCH 06/12] i2c: designware_i2c: Use an accurate bus clock instead of MHz Simon Glass
2019-12-21 16:15 ` [PATCH 07/12] i2c: designware_i2c: Bring in the binding file Simon Glass
2019-12-21 16:15 ` [PATCH 08/12] i2c: designware_i2c: Read device-tree properties Simon Glass
2019-12-21 16:15 ` [PATCH 09/12] i2c: designware_i2c: Drop scl_sda_cfg parameter Simon Glass
2019-12-21 16:15 ` [PATCH 10/12] i2c: designware_i2c: Put hold config in a struct Simon Glass
2019-12-21 16:15 ` [PATCH 11/12] i2c: designware_i2c: Rewrite timing calculation Simon Glass
2019-12-21 16:15 ` [PATCH 12/12] i2c: designware_i2c: Add spike supression Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB4509051BB88647501974EC4DCC2E0@MN2PR11MB4509.namprd11.prod.outlook.com \
    --to=ley.foon.tan@intel.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.