From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Tao, Yintian" Subject: =?gb2312?B?tPC4tDogW1BBVENIXSBkcm0vYW1kZ3B1OiBubyBuZWVkIGZiY29uIHVuZGVy?= =?gb2312?Q?_sriov?= Date: Tue, 4 Jun 2019 15:16:16 +0000 Message-ID: References: <1559655785-30379-1-git-send-email-yttao@amd.com>, <1686be7b-ca1c-e43c-3906-e6131e8d25e1@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1218694329==" Return-path: In-Reply-To: <1686be7b-ca1c-e43c-3906-e6131e8d25e1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: zh-CN List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "Koenig, Christian" --===============1218694329== Content-Language: zh-CN Content-Type: multipart/alternative; boundary="_000_MN2PR12MB3039F0DD22910F40A6674546E5150MN2PR12MB3039namp_" --_000_MN2PR12MB3039F0DD22910F40A6674546E5150MN2PR12MB3039namp_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 SGkgIENocmlzdGlhbg0KDQoNCkJ1dCB3aGVuIGFtZGdwdSBkcml2ZXIgaXMgdW5sb2FkaW5nLCBp dCB3aWxsIGNhbGwgdGhpcyBmdW5jdGlvbi4NCg0KDQpBbmQgZHJpdmVyIHVubG9hZGluZyBpcyBh biBsZWdhbCBjYXNlIHVuZGVyIFNSLUlPVi4NCg0KDQpEbyB5b3UgbWVhbiBQQ0llIGRldmljZSBy ZW1vdmFsIGluZGljYXRlcyB0aGUgdW5wbHVnIHRoZSByZWFsIGRldmljZT8NCg0KDQpCZXN0IFJl Z2FyZHMNCg0KWWl0bmlhbiBUYW8NCg0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18N CreivP7IyzogQ2hyaXN0aWFuIEs/bmlnIDxja29lbmlnLmxlaWNodHp1bWVya2VuQGdtYWlsLmNv bT4NCreiy83KsbzkOiAyMDE5xOo21MI0yNUgMjE6NTc6MzcNCsrVvP7IyzogVGFvLCBZaW50aWFu OyBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZw0K1vfM4jogUmU6IFtQQVRDSF0gZHJtL2Ft ZGdwdTogbm8gbmVlZCBmYmNvbiB1bmRlciBzcmlvdg0KDQpBbSAwNC4wNi4xOSB1bSAxNTo0MyBz Y2hyaWViIFlpbnRpYW4gVGFvOg0KPiBVbmRlciBTcmlvdiwgdGhlcmUgaXMgbm8gbmVlZCBvZiB0 aGUgc3VwcG9ydCBmb3IgZmJjb24uDQoNCk5BSywgdGhhdCBlcnJvciBtZXNzYWdlIGlzIG5vdCBy ZWxhdGVkIHRvIGZiY29uIGJ1dCBtZWFucyB0aGF0IFBDSWUNCmRldmljZSByZW1vdmFsIGlzIG5v dCBzdXBwb3J0ZWQuDQoNCkNocmlzdGlhbi4NCg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBZaW50aWFu IFRhbyA8eXR0YW9AYW1kLmNvbT4NCj4gLS0tDQo+ICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X2Rydi5jIHwgMyArKy0NCj4gICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9uKC0pDQo+DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVf ZHJ2LmMNCj4gaW5kZXggMWYzOGQ2Zi4uMjhkMDk1YiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rydi5jDQo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV9kcnYuYw0KPiBAQCAtMTAxMiw3ICsxMDEyLDggQEAgYW1kZ3B1X3Bj aV9yZW1vdmUoc3RydWN0IHBjaV9kZXYgKnBkZXYpDQo+ICAgew0KPiAgICAgICAgc3RydWN0IGRy bV9kZXZpY2UgKmRldiA9IHBjaV9nZXRfZHJ2ZGF0YShwZGV2KTsNCj4NCj4gLSAgICAgRFJNX0VS Uk9SKCJEZXZpY2UgcmVtb3ZhbCBpcyBjdXJyZW50bHkgbm90IHN1cHBvcnRlZCBvdXRzaWRlIG9m IGZiY29uXG4iKTsNCj4gKyAgICAgaWYgKCFhbWRncHVfc3Jpb3ZfdmYoYWRldikpDQo+ICsgICAg ICAgICAgICAgRFJNX0VSUk9SKCJEZXZpY2UgcmVtb3ZhbCBpcyBjdXJyZW50bHkgbm90IHN1cHBv cnRlZCBvdXRzaWRlIG9mIGZiY29uXG4iKTsNCj4gICAgICAgIGRybV9kZXZfdW5wbHVnKGRldik7 DQo+ICAgICAgICBkcm1fZGV2X3B1dChkZXYpOw0KPiAgICAgICAgcGNpX2Rpc2FibGVfZGV2aWNl KHBkZXYpOw0KDQo= --_000_MN2PR12MB3039F0DD22910F40A6674546E5150MN2PR12MB3039namp_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

Hi  Christian


But when amdgpu driver is unloadi= ng, it will call this function.


And driver unloading is an legal = case under SR-IOV.


Do you mean PCIe device removal i= ndicates the unplug the real device?


Best Regards

Yitnian Tao

=B7=A2=BC=FE=C8=CB: Christi= an König <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
=B7=A2=CB=CD=CA=B1=BC=E4: 2019=C4=EA6=D4=C24=C8=D5 21:57:37
=CA=D5=BC=FE=C8=CB: Tao, Yintian; amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
=D6=F7=CC=E2: Re: [PATCH] drm/amdgpu: no need fbcon under sriov
 
Am 04.06.19 um 15:43 schrieb Yintian Tao:
> Under Sriov, there is no need of the support for fbcon.

NAK, that error message is not related to fbcon but means that PCIe
device removal is not supported.

Christian.

>
> Signed-off-by: Yintian Tao <yttao-5C7GfCeVMHo@public.gmane.org>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++- >   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm= /amd/amdgpu/amdgpu_drv.c
> index 1f38d6f..28d095b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1012,7 +1012,8 @@ amdgpu_pci_remove(struct pci_dev *pdev)
>   {
>        struct drm_device *dev =3D p= ci_get_drvdata(pdev);
>  
> -     DRM_ERROR("Device removal is currently = not supported outside of fbcon\n");
> +     if (!amdgpu_sriov_vf(adev))
> +           = ;  DRM_ERROR("Device removal is currently not supported outside o= f fbcon\n");
>        drm_dev_unplug(dev);
>        drm_dev_put(dev);
>        pci_disable_device(pdev);
--_000_MN2PR12MB3039F0DD22910F40A6674546E5150MN2PR12MB3039namp_-- --===============1218694329== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4 --===============1218694329==--