From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Huang, Ray" Date: Thu, 21 Mar 2019 06:52:27 +0000 Subject: RE: [PATCH] drm/amd/powerplay: Fix double unlock bug in smu_sys_set_pp_table() Message-Id: List-Id: References: <20190321062822.GD21489@kadam> In-Reply-To: <20190321062822.GD21489@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , "Deucher, Alexander" , "Wang, Kevin(Yang)" Cc: "Zhou, David(ChunMing)" , "Gui, Jack" , David Airlie , "kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , Daniel Vetter , "Gao, Likun" , "Koenig, Christian" > -----Original Message----- > From: Dan Carpenter [mailto:dan.carpenter@oracle.com] > Sent: Thursday, March 21, 2019 2:28 PM > To: Deucher, Alexander ; Wang, Kevin(Yang) > > Cc: Koenig, Christian ; Zhou, David(ChunMing) > ; David Airlie ; Daniel Vetter > ; Huang, Ray ; Gao, Likun > ; Gui, Jack ; amd- > gfx@lists.freedesktop.org; kernel-janitors@vger.kernel.org > Subject: [PATCH] drm/amd/powerplay: Fix double unlock bug in > smu_sys_set_pp_table() > > We already unlocked a few lines earlier so this code unlocks twice on the > success path. > > Fixes: 5809d7420f97 ("drm/amd/powerplay: implement sysfs of pp_table for > smu11 (v2)") > Signed-off-by: Dan Carpenter Nice catch! Thanks, Dan. Kevin, could you please verify this patch. Reviewed-by: Huang Rui > --- > I'm not sure what this bug looks like at runtime, but it's slightly weird that no > one noticed. This is from static analysis and I haven't tested it myself. > > drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > index 00b7c885772b..7e8c74da6a74 100644 > --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c > @@ -187,6 +187,8 @@ int smu_sys_set_pp_table(struct smu_context *smu, > void *buf, size_t size) > if (ret) > pr_info("smu reset failed, ret = %d\n", ret); > > + return ret; > + > failed: > mutex_unlock(&smu->mutex); > return ret; > -- > 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Huang, Ray" Subject: RE: [PATCH] drm/amd/powerplay: Fix double unlock bug in smu_sys_set_pp_table() Date: Thu, 21 Mar 2019 06:52:27 +0000 Message-ID: References: <20190321062822.GD21489@kadam> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190321062822.GD21489@kadam> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Dan Carpenter , "Deucher, Alexander" , "Wang, Kevin(Yang)" Cc: "Zhou, David(ChunMing)" , "Gui, Jack" , David Airlie , "kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , Daniel Vetter , "Gao, Likun" , "Koenig, Christian" PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IERhbiBDYXJwZW50ZXIgW21haWx0 bzpkYW4uY2FycGVudGVyQG9yYWNsZS5jb21dCj4gU2VudDogVGh1cnNkYXksIE1hcmNoIDIxLCAy MDE5IDI6MjggUE0KPiBUbzogRGV1Y2hlciwgQWxleGFuZGVyIDxBbGV4YW5kZXIuRGV1Y2hlckBh bWQuY29tPjsgV2FuZywgS2V2aW4oWWFuZykKPiA8S2V2aW4xLldhbmdAYW1kLmNvbT4KPiBDYzog S29lbmlnLCBDaHJpc3RpYW4gPENocmlzdGlhbi5Lb2VuaWdAYW1kLmNvbT47IFpob3UsIERhdmlk KENodW5NaW5nKQo+IDxEYXZpZDEuWmhvdUBhbWQuY29tPjsgRGF2aWQgQWlybGllIDxhaXJsaWVk QGxpbnV4LmllPjsgRGFuaWVsIFZldHRlcgo+IDxkYW5pZWxAZmZ3bGwuY2g+OyBIdWFuZywgUmF5 IDxSYXkuSHVhbmdAYW1kLmNvbT47IEdhbywgTGlrdW4KPiA8TGlrdW4uR2FvQGFtZC5jb20+OyBH dWksIEphY2sgPEphY2suR3VpQGFtZC5jb20+OyBhbWQtCj4gZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZzsga2VybmVsLWphbml0b3JzQHZnZXIua2VybmVsLm9yZwo+IFN1YmplY3Q6IFtQQVRDSF0g ZHJtL2FtZC9wb3dlcnBsYXk6IEZpeCBkb3VibGUgdW5sb2NrIGJ1ZyBpbgo+IHNtdV9zeXNfc2V0 X3BwX3RhYmxlKCkKPiAKPiBXZSBhbHJlYWR5IHVubG9ja2VkIGEgZmV3IGxpbmVzIGVhcmxpZXIg c28gdGhpcyBjb2RlIHVubG9ja3MgdHdpY2Ugb24gdGhlCj4gc3VjY2VzcyBwYXRoLgo+IAo+IEZp eGVzOiA1ODA5ZDc0MjBmOTcgKCJkcm0vYW1kL3Bvd2VycGxheTogaW1wbGVtZW50IHN5c2ZzIG9m IHBwX3RhYmxlIGZvcgo+IHNtdTExICh2MikiKQo+IFNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50 ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4KCk5pY2UgY2F0Y2ghICBUaGFua3MsIERhbi4K S2V2aW4sIGNvdWxkIHlvdSBwbGVhc2UgdmVyaWZ5IHRoaXMgcGF0Y2guClJldmlld2VkLWJ5OiBI dWFuZyBSdWkgPHJheS5odWFuZ0BhbWQuY29tPgoKPiAtLS0KPiBJJ20gbm90IHN1cmUgd2hhdCB0 aGlzIGJ1ZyBsb29rcyBsaWtlIGF0IHJ1bnRpbWUsIGJ1dCBpdCdzIHNsaWdodGx5IHdlaXJkIHRo YXQgbm8KPiBvbmUgbm90aWNlZC4gIFRoaXMgaXMgZnJvbSBzdGF0aWMgYW5hbHlzaXMgYW5kIEkg aGF2ZW4ndCB0ZXN0ZWQgaXQgbXlzZWxmLgo+IAo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL3Bvd2Vy cGxheS9hbWRncHVfc211LmMgfCAyICsrCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMo KykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9wb3dlcnBsYXkvYW1kZ3B1 X3NtdS5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vYW1kL3Bvd2VycGxheS9hbWRncHVfc211LmMKPiBp bmRleCAwMGI3Yzg4NTc3MmIuLjdlOGM3NGRhNmE3NCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vYW1kL3Bvd2VycGxheS9hbWRncHVfc211LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v YW1kL3Bvd2VycGxheS9hbWRncHVfc211LmMKPiBAQCAtMTg3LDYgKzE4Nyw4IEBAIGludCBzbXVf c3lzX3NldF9wcF90YWJsZShzdHJ1Y3Qgc211X2NvbnRleHQgKnNtdSwKPiB2b2lkICpidWYsIHNp emVfdCBzaXplKQo+ICAJaWYgKHJldCkKPiAgCQlwcl9pbmZvKCJzbXUgcmVzZXQgZmFpbGVkLCBy ZXQgPSAlZFxuIiwgcmV0KTsKPiAKPiArCXJldHVybiByZXQ7Cj4gKwo+ICBmYWlsZWQ6Cj4gIAlt dXRleF91bmxvY2soJnNtdS0+bXV0ZXgpOwo+ICAJcmV0dXJuIHJldDsKPiAtLQo+IDIuMTcuMQoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4