From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Quan, Evan" Subject: RE: [PATCH] drm/amdgpu: defer cmd/fence/fw buffers destroy on hw_init failure Date: Fri, 22 Mar 2019 09:31:19 +0000 Message-ID: References: <20190318024208.17792-1-evan.quan@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Xu, Feifei" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" VGhpcyBhZmZlY3RzIGh3X2luaXQgb25seS4gSXQncyBub3Qgb24gdGhlIHBhdGggb2YgUzMvcmVz dW1lIGFuZCBncHVfcmVjb3ZlcnkvcmVzdW1lLg0KU28sIHRoZXkgYXJlIG5vdCBhZmZlY3RlZC4N Cg0KDQpSZWdhcmRzLA0KRXZhbg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9t OiBYdSwgRmVpZmVpDQo+IFNlbnQ6IDIwMTnlubQz5pyIMjLml6UgMTY6NTYNCj4gVG86IFF1YW4s IEV2YW4gPEV2YW4uUXVhbkBhbWQuY29tPjsgYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcN Cj4gQ2M6IFF1YW4sIEV2YW4gPEV2YW4uUXVhbkBhbWQuY29tPg0KPiBTdWJqZWN0OiBSRTogW1BB VENIXSBkcm0vYW1kZ3B1OiBkZWZlciBjbWQvZmVuY2UvZncgYnVmZmVycyBkZXN0cm95IG9uDQo+ IGh3X2luaXQgZmFpbHVyZQ0KPiANCj4gIEhhdmUgeW91IHRlc3RlZCBpbiBTMyBhbmQgZ3B1X3Jl Y292ZXJ5Pw0KPiANCj4gSWYgeWVzLiBSZXZpZXdlZC1ieTogRmVpZmVpIFh1IDxGZWlmZWkuWHVA YW1kLmNvbT4NCj4gDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IGFtZC1n ZnggPGFtZC1nZngtYm91bmNlc0BsaXN0cy5mcmVlZGVza3RvcC5vcmc+IE9uIEJlaGFsZiBPZiBF dmFuDQo+IFF1YW4NCj4gU2VudDogTW9uZGF5LCBNYXJjaCAxOCwgMjAxOSAxMDo0MiBBTQ0KPiBU bzogYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcNCj4gQ2M6IFF1YW4sIEV2YW4gPEV2YW4u UXVhbkBhbWQuY29tPg0KPiBTdWJqZWN0OiBbUEFUQ0hdIGRybS9hbWRncHU6IGRlZmVyIGNtZC9m ZW5jZS9mdyBidWZmZXJzIGRlc3Ryb3kgb24NCj4gaHdfaW5pdCBmYWlsdXJlDQo+IA0KPiBBcyB0 aGUgY2xlYW51cCBqb2JzIHBlcmZvcm1lZCBpbiBwcmVfZmluaSBtYXkgc3RpbGwgbmVlZCB0aGVz ZSBidWZmZXJzLiBOVUxMDQo+IHBvaW50ZXIgZGVyZWZlcmVuY2Ugd2lsbCBiZSB0cmlnZ2VyZWQg d2l0aG91dCB0aGVtLg0KPiANCj4gQ2hhbmdlLUlkOiBJMzk4ZWZkNjUyNTg0ZTAyMmRlYmYyMzc5 NTAyMDcxOTlhNGVhNzhmYw0KPiBTaWduZWQtb2ZmLWJ5OiBFdmFuIFF1YW4gPGV2YW4ucXVhbkBh bWQuY29tPg0KPiAtLS0NCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9wc3Au YyB8IDMxICsrKysrKysrKystLS0tLS0tLS0tLS0tLQ0KPiAtDQo+ICAxIGZpbGUgY2hhbmdlZCwg MTIgaW5zZXJ0aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3BzcC5jDQo+IGIvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X3BzcC5jDQo+IGluZGV4IDU4ODhlMjQyMTlkOS4uMjIwNmJiNGIw OTAzIDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcHNw LmMNCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3BzcC5jDQo+IEBA IC04OTAsNTkgKzg5MCw1MiBAQCBzdGF0aWMgaW50IHBzcF9sb2FkX2Z3KHN0cnVjdCBhbWRncHVf ZGV2aWNlDQo+ICphZGV2KQ0KPiAgCQkJCQkmcHNwLT5mZW5jZV9idWZfbWNfYWRkciwNCj4gIAkJ CQkJJnBzcC0+ZmVuY2VfYnVmKTsNCj4gIAlpZiAocmV0KQ0KPiAtCQlnb3RvIGZhaWxlZF9tZW0y Ow0KPiArCQlnb3RvIGZhaWxlZDsNCj4gDQo+ICAJcmV0ID0gYW1kZ3B1X2JvX2NyZWF0ZV9rZXJu ZWwoYWRldiwgUFNQX0NNRF9CVUZGRVJfU0laRSwNCj4gUEFHRV9TSVpFLA0KPiAgCQkJCSAgICAg IEFNREdQVV9HRU1fRE9NQUlOX1ZSQU0sDQo+ICAJCQkJICAgICAgJnBzcC0+Y21kX2J1Zl9ibywg JnBzcC0NCj4gPmNtZF9idWZfbWNfYWRkciwNCj4gIAkJCQkgICAgICAodm9pZCAqKikmcHNwLT5j bWRfYnVmX21lbSk7DQo+ICAJaWYgKHJldCkNCj4gLQkJZ290byBmYWlsZWRfbWVtMTsNCj4gKwkJ Z290byBmYWlsZWQ7DQo+IA0KPiAgCW1lbXNldChwc3AtPmZlbmNlX2J1ZiwgMCwgUFNQX0ZFTkNF X0JVRkZFUl9TSVpFKTsNCj4gDQo+ICAJcmV0ID0gcHNwX3JpbmdfaW5pdChwc3AsIFBTUF9SSU5H X1RZUEVfX0tNKTsNCj4gIAlpZiAocmV0KSB7DQo+ICAJCURSTV9FUlJPUigiUFNQIHJpbmcgaW5p dCBmYWlsZWQhXG4iKTsNCj4gLQkJZ290byBmYWlsZWRfbWVtOw0KPiArCQlnb3RvIGZhaWxlZDsN Cj4gIAl9DQo+IA0KPiAgCXJldCA9IHBzcF90bXJfaW5pdChwc3ApOw0KPiAgCWlmIChyZXQpIHsN Cj4gIAkJRFJNX0VSUk9SKCJQU1AgdG1yIGluaXQgZmFpbGVkIVxuIik7DQo+IC0JCWdvdG8gZmFp bGVkX21lbTsNCj4gKwkJZ290byBmYWlsZWQ7DQo+ICAJfQ0KPiANCj4gIAlyZXQgPSBwc3BfYXNk X2luaXQocHNwKTsNCj4gIAlpZiAocmV0KSB7DQo+ICAJCURSTV9FUlJPUigiUFNQIGFzZCBpbml0 IGZhaWxlZCFcbiIpOw0KPiAtCQlnb3RvIGZhaWxlZF9tZW07DQo+ICsJCWdvdG8gZmFpbGVkOw0K PiAgCX0NCj4gDQo+ICBza2lwX21lbWFsbG9jOg0KPiAgCXJldCA9IHBzcF9od19zdGFydChwc3Ap Ow0KPiAgCWlmIChyZXQpDQo+IC0JCWdvdG8gZmFpbGVkX21lbTsNCj4gKwkJZ290byBmYWlsZWQ7 DQo+IA0KPiAgCXJldCA9IHBzcF9ucF9md19sb2FkKHBzcCk7DQo+ICAJaWYgKHJldCkNCj4gLQkJ Z290byBmYWlsZWRfbWVtOw0KPiArCQlnb3RvIGZhaWxlZDsNCj4gDQo+ICAJcmV0dXJuIDA7DQo+ IA0KPiAtZmFpbGVkX21lbToNCj4gLQlhbWRncHVfYm9fZnJlZV9rZXJuZWwoJnBzcC0+Y21kX2J1 Zl9ibywNCj4gLQkJCSAgICAgICZwc3AtPmNtZF9idWZfbWNfYWRkciwNCj4gLQkJCSAgICAgICh2 b2lkICoqKSZwc3AtPmNtZF9idWZfbWVtKTsNCj4gLWZhaWxlZF9tZW0xOg0KPiAtCWFtZGdwdV9i b19mcmVlX2tlcm5lbCgmcHNwLT5mZW5jZV9idWZfYm8sDQo+IC0JCQkgICAgICAmcHNwLT5mZW5j ZV9idWZfbWNfYWRkciwgJnBzcC0+ZmVuY2VfYnVmKTsNCj4gLWZhaWxlZF9tZW0yOg0KPiAtCWFt ZGdwdV9ib19mcmVlX2tlcm5lbCgmcHNwLT5md19wcmlfYm8sDQo+IC0JCQkgICAgICAmcHNwLT5m d19wcmlfbWNfYWRkciwgJnBzcC0+ZndfcHJpX2J1Zik7DQo+ICBmYWlsZWQ6DQo+IC0Ja2ZyZWUo cHNwLT5jbWQpOw0KPiAtCXBzcC0+Y21kID0gTlVMTDsNCj4gKwkvKg0KPiArCSAqIGFsbCBjbGVh bnVwIGpvYnMgKHhnbWkgdGVybWluYXRlLCByYXMgdGVybWluYXRlLA0KPiArCSAqIHJpbmcgZGVz dHJveSwgY21kL2ZlbmNlL2Z3IGJ1ZmZlcnMgZGVzdG9yeSwNCj4gKwkgKiBwc3AtPmNtZCBkZXN0 b3J5KSBhcmUgZGVsYXllZCB0byBwc3BfaHdfZmluaQ0KPiArCSAqLw0KPiAgCXJldHVybiByZXQ7 DQo+ICB9DQo+IA0KPiAtLQ0KPiAyLjIxLjANCj4gDQo+IF9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fDQo+IGFtZC1nZnggbWFpbGluZyBsaXN0DQo+IGFtZC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnDQo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vYW1kLWdmeA0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9hbWQtZ2Z4