RE: [v4 4/6] dt-bindings: phy: Document the Synopsys MIPI DPHY Rx bindings

From: Luis de Oliveira <Luis.Oliveira@synopsys.com>
To: Rob Herring <robh@kernel.org>,
	Luis Oliveira <Luis.Oliveira@synopsys.com>
Cc: "mchehab@kernel.org" <mchehab@kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
	"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
	"paulmck@linux.ibm.com" <paulmck@linux.ibm.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"kishon@ti.com" <kishon@ti.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Joao.Pinto@synopsys.com" <Joao.Pinto@synopsys.com>
Subject: RE: [v4 4/6] dt-bindings: phy: Document the Synopsys MIPI DPHY Rx bindings
Date: Tue, 9 Jul 2019 16:28:53 +0000	[thread overview]
Message-ID: <MN2PR12MB371024C55C5B48A91EECE7A0CBF10@MN2PR12MB3710.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20190709142000.GA995@bogus>

From: Rob Herring <robh@kernel.org>
Date: Tue, Jul 09, 2019 at 15:20:00

> On Tue, Jun 11, 2019 at 09:20:53PM +0200, Luis Oliveira wrote:
> > Add device-tree bindings documentation for SNPS DesignWare MIPI D-PHY in
> > RX mode.
> > 
> > Signed-off-by: Luis Oliveira <luis.oliveira@synopsys.com>
> > ---
> > Changelog
> > v3-v4
> > - @Laurent I know I told you I could remove the snps,dphy-frequency on V3 but
> >   it is really useful for me here. I removed all other the proprietary
> >   properties except this one. Do you still think it must be removed?
> > - Frequency units @Rob
> 
> Frequency units means append '-khz' to the property name. That also 
> makes the 'frequency' part redundant, so maybe name it more around what 
> the frequency is. The frequency for what?
> 
> Rob
> 

This is the D-PHY high speed frequency configuration that corresponds to 
the high speed data transfer of the bus.
Basically is the transmission speed per lane.
Do you think I can use "link-frequencies" (present in 
video-interfaces.txt) with one frequency?

> > 
> >  .../devicetree/bindings/phy/snps,dw-dphy-rx.txt    | 29 ++++++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/phy/snps,dw-dphy-rx.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/snps,dw-dphy-rx.txt b/Documentation/devicetree/bindings/phy/snps,dw-dphy-rx.txt
> > new file mode 100644
> > index 0000000..50603e6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/snps,dw-dphy-rx.txt
> > @@ -0,0 +1,29 @@
> > +Synopsys DesignWare MIPI Rx D-PHY block details
> > +
> > +Description
> > +-----------
> > +
> > +The Synopsys MIPI D-PHY controller supports MIPI-DPHY in receiver mode.
> > +Please refer to phy-bindings.txt for more information.
> > +
> > +Required properties:
> > +- compatible		: Shall be "snps,dw-dphy-rx".
> > +- #phy-cells		: Must be 1.
> > +- bus-width		: Size of the test interface data bus (8 bits->8 or
> > +			  12bits->12).
> > +- snps,dphy-frequency	: Frequency at which D-PHY should start, configurable.
> > +			  Check Synopsys databook. (-kHz)
> > +- reg			: Test interface register. This correspondes to the
> > +			  physical base address of the controller and size of
> > +			  the device memory mapped registers; Check Synopsys
> > +			  databook.
> > +
> > +Example:
> > +
> > +	mipi_dphy_rx1: dphy@d00003040 {
> > +		compatible = "snps,dw-dphy-rx";
> > +		#phy-cells = <1>;
> > +		bus-width = <12>;
> > +		snps,dphy-frequency = <300000>;
> > +		reg = <0xd0003040 0x20>;
> > +	};
> > -- 
> > 2.7.4
> > 

Thank you Rob,
Luis