From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: ** X-Spam-Status: No, score=2.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,HTTPS_HTTP_MISMATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CF3EC54FD0 for ; Mon, 27 Apr 2020 13:01:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E166D206BF for ; Mon, 27 Apr 2020 13:01:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="gffJgNQB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E166D206BF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 93F116E08A; Mon, 27 Apr 2020 13:01:09 +0000 (UTC) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2073.outbound.protection.outlook.com [40.107.223.73]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5BFE26E08A for ; Mon, 27 Apr 2020 13:01:08 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=njQxslFpBJrx2AXYw4QfJELNP6pch4jd+0DGWKGTbjt0D+y3EnLMJMQCurPrhWXn/yhbXtmA4iHVyy1xrw3kaNYU90bBtl43mNQ6KIPHacrS+H775o48WNzrWNKbgATs05zIqJIpUsmC/PuGtDJjHeVgxPJ4P+78wqAHlPOBqbXxwhJY9g6RivMZ59y4/0/PmPr9c8iItK+WyTbu/yqlbicp1tsoycfrS2m8mIN2TnDWjOClATmbVD1FcAK+xWTOytzY0djIOIEBu/3GZt80FNytC562g/MEPi7RS1Y/bB/W7l0BsbMWoOmR4jlt44nlXKFtgOX4ThFDI/RR6RVTBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G3qL+gpY0ThNCxeg/WktV9hk3Efp24SoMvw7DimQBNA=; b=K62OlvFGVj+MRhac6ctfX4DbXaUOvNwoZDsXptKeHe7ZAUPJz9W5caNctEMEteYJLyATQ9ROFR77WSKkdNKnPxJ9972sxg76Iq+zgKub+FT4VSqSAtnUX+1kwhqJHRm3slpr9/uh1gQPKPpmmJnrl6kMG1M+fP0mwzbSnXVpFxO2roIvXoEt2xvt87/NqJdIV5EhUK+UJKTRalOsz8LvFEBIqZpar7e40oJ930+KJIHGhUbVCWaSXf2mnAbo1lIM5D1FySh22k74SjRNLhVfjIRe9wPDZ4N9W/nP+EjPGiNpuLbNp1SIKhREVyYMXAeoynwuTeTr75LHMJzlPY9meg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G3qL+gpY0ThNCxeg/WktV9hk3Efp24SoMvw7DimQBNA=; b=gffJgNQBtbLYe1S4/m+LaNSIbQI/Lg3zFOCJjDqCvSOhTWdxjvvRnHrGvTvdA4t4m6vaHxuf2v/vtuWaPYWBrTey1tVRBscbvBcfwGjfMT8mUlAmU8lkyuDDc4fQcCphsk2eMF+Sryr34EOE8N9X4ZvJ805FQxl8icxnMlCscV8= Received: from MN2PR12MB4488.namprd12.prod.outlook.com (2603:10b6:208:24e::19) by MN2PR12MB3486.namprd12.prod.outlook.com (2603:10b6:208:c6::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Mon, 27 Apr 2020 13:01:03 +0000 Received: from MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::9dee:2a71:22d6:2941]) by MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::9dee:2a71:22d6:2941%6]) with mapi id 15.20.2937.020; Mon, 27 Apr 2020 13:01:03 +0000 From: "Deucher, Alexander" To: "Koenig, Christian" , =?Windows-1252?Q?Marek_Ol=9A=E1k?= Subject: Re: drm/amdgpu: invalidate L2 before SDMA IBs (on gfx10) Thread-Topic: drm/amdgpu: invalidate L2 before SDMA IBs (on gfx10) Thread-Index: AQHWGt77YbaHnzNcfU2ReZDpujzt5aiJ79oAgACdsoCAAIy/AIAB1wqh Date: Mon, 27 Apr 2020 13:01:03 +0000 Message-ID: References: <71c2f3e9-a734-5887-b5ce-7fa8b011d372@gmail.com> , <659c4b65-764e-85a8-6ac6-0a9daaa6437e@amd.com> In-Reply-To: <659c4b65-764e-85a8-6ac6-0a9daaa6437e@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Enabled=True; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SetDate=2020-04-27T13:01:02.659Z; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Name=Internal Distribution Only; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ContentBits=0; MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Method=Standard; authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Deucher@amd.com; x-originating-ip: [71.219.72.172] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e9dd4049-f1c9-49c1-582e-08d7eaab0a9b x-ms-traffictypediagnostic: MN2PR12MB3486:|MN2PR12MB3486: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0386B406AA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4488.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(4326008)(55016002)(33656002)(5660300002)(110136005)(81156014)(71200400001)(9686003)(8676002)(2906002)(966005)(316002)(86362001)(478600001)(186003)(7696005)(19627405001)(52536014)(66574012)(6506007)(26005)(66946007)(66446008)(76116006)(8936002)(66556008)(64756008)(53546011)(66476007); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yivuQ+yMcM26p/XM9vtv1VvcsXb6IUq50ooXuqIID894VXDIDxBIEVN2jluxtBSiVEfAF48JrO8hEX/ois7b6FBh1b/kag+rhiNzzyWTZOcOL7TwKFMY1gZBVTnpj4IiKCc2fAyp7qfSdGkKUCDW3DRG4ADSorqATXhmLxp5vge+kekjYJPKfTWjqgUgJRXyFBRT7IskwgDXl8RsiT+WpEVqrhJ5lENGTFSxs7nkcCrsDofPDxPlvPxMy/lxCKh0lIauxwoCtu81s71UwVw+LNDdlCdzo0DKxpS/gjxuVPNNGE9rmUkdh0LCBJxnlzRuwvkFy4zkqaeEfq9e0dLmzFMPntsmJ1b7BuOaWMnra4QbMRntg0V3dInRp6P4eDs1oUSl21EZ50KvGqFfFeHS2vNYdbXXvtghFadQm0v+xo3FzC2HF+7C8hTxWdZNQxLWEKavYVRuv8RaOTYi7k1ELMEd5X5woqRDI6EmttZ2o9s= x-ms-exchange-antispam-messagedata: RdKOazIHhMsiRTH/BkIe1uDoN+g94/Z2TYQ1i4jYB+eaiy94x+Anb11LXkAylOjnaUYBdO+sVsAKCXevOEysQ9YN2xZwnrruERHe3nJy/YXHI4j9E8p5q+V5xv5Bnnr51EOQKC4rPU+TWo/+4uDfAfRMtHLz1Zbxgn6zIXgDh7GjFptoZu8kidjEGXEcaHNUYLhbYSeLB3EQRKpxXQaU/f2Fm0soxHWws9HSVazFt1njY0YuGqvvNQpjPEhKuurbzYmXR1YV6HOjPXsT9ML5Fl2XIMzFtT5GIQvtWB0KsR3eJDzPRCNUdD7wpLhCeWpzdltGTWLDpZiwt74JrPhuvOkjaOpgdUBozFNJTtR15qe8ujnoPO+7S+DQaZPTjjuSBLvrbfjmhJxUiIG5TPH/zx1zYJwbZseIksQtjYbzll+xj61zNHJFKjCkIkQmVNvWqlzPBy+A/eyYy6lZiMW+1fAeJRRc1Ud4VTBDdz8ZGS0J++oHURofchnehUHkO7gYDKUAC9uucyfaVYknESK0XU1nIsA1M9wn+TVZOKSXIr0o/pUNzf5vA0BWr0xe8BZyOWqcxn2zRS5QZ5U6ASJk/m+2nuEqcS4A4oseAvn4heIYw8EhKNdxuYWYAXzKz6jygBYp4d6082pCAEb5ahVDVLW2NlatL680slTzFAt3OOHJ8iE8DJT0cZkm9nChZm7/QFuvbN5eu6Bilwz4231+vc07dGpgWG/q1LRwNA+JQDryaiskjNCDFpEXptLUVRBgZvmltyuGlkCADIeBxxTfkdBmzR68vTAO3y3GVLB8/Vk= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9dd4049-f1c9-49c1-582e-08d7eaab0a9b X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2020 13:01:03.3170 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: X2Cq3VWLXFQInw/U7Flq5IgxnfC4sGpGTVpLoXo+5ERg3fmS/NzgJCrywlm6GmhHx7YA+0PB/E9rOvDnnr8PGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3486 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: amd-gfx mailing list Content-Type: multipart/mixed; boundary="===============0242733608==" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" --===============0242733608== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR12MB4488629455EEFE9590402250F7AF0MN2PR12MB4488namp_" --_000_MN2PR12MB4488629455EEFE9590402250F7AF0MN2PR12MB4488namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - Internal Distribution Only] Please split the patch into two, one to update the emit IB sequence, and on= e to bump the minor version. That way we can make sure older kernels get t= he new sequence. Also do we need an sdma fw version check for the new pack= et in the emi IB function? Alex ________________________________ From: amd-gfx on behalf of Christia= n K=F6nig Sent: Sunday, April 26, 2020 4:52 AM To: Marek Ol=9A=E1k Cc: amd-gfx mailing list Subject: Re: drm/amdgpu: invalidate L2 before SDMA IBs (on gfx10) Thought so, we should try to get this get it committed ASAP. And maybe add = a CC: stable tag as well. Patch is Reviewed-by: Christian K=F6nig . Thanks, Christian. Am 26.04.20 um 02:28 schrieb Marek Ol=9A=E1k: Not without a mandatory firmware update. The gcr packet support for IBs was= added into the sdma firmware just two weeks ago. Marek On Sat., Apr. 25, 2020, 11:04 Christian K=F6nig, > wrote: Could we do this in userspace as well? Am 25.04.20 um 10:52 schrieb Marek Ol=9A=E1k: This should fix SDMA hangs on gfx10. Marek _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx --_000_MN2PR12MB4488629455EEFE9590402250F7AF0MN2PR12MB4488namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - Internal Distribution Only]


Please split the patch into two, one to update the emit IB sequence, and on= e to bump the minor version.  That way we can make sure older kernels = get the new sequence.  Also do we need an sdma fw version check for th= e new packet in the emi IB function?

Alex
From: amd-gfx <amd-gfx-b= ounces@lists.freedesktop.org> on behalf of Christian K=F6nig <christi= an.koenig@amd.com>
Sent: Sunday, April 26, 2020 4:52 AM
To: Marek Ol=9A=E1k <maraeo@gmail.com>
Cc: amd-gfx mailing list <amd-gfx@lists.freedesktop.org>
Subject: Re: drm/amdgpu: invalidate L2 before SDMA IBs (on gfx10)
 
Thought so, we should try to get this get = it committed ASAP. And maybe add a CC: stable tag as well.

Patch is Reviewed-by: Christian K=F6nig <christian.koenig@amd.com>.

Thanks,
Christian.

Am 26.04.20 um 02:28 schrieb Marek Ol=9A=E1k:
Not without a mandatory firmware update. The gcr packet s= upport for IBs was added into the sdma firmware just two weeks ago.

Marek

On Sat., Apr. 25, 2020, 11:04 Chris= tian K=F6nig, <ckoen= ig.leichtzumerken@gmail.com> wrote:
Could we do this in userspace as well?

Am 25.04.20 um 10:52 schrieb Marek Ol=9A=E1k:
This should fix SDMA hangs on gfx10.

Marek

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx


--_000_MN2PR12MB4488629455EEFE9590402250F7AF0MN2PR12MB4488namp_-- --===============0242733608== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx --===============0242733608==--