From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE6BC2D0A3 for ; Tue, 3 Nov 2020 14:50:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5927C22453 for ; Tue, 3 Nov 2020 14:50:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="1a5jFyrR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728199AbgKCOu5 (ORCPT ); Tue, 3 Nov 2020 09:50:57 -0500 Received: from mail-mw2nam10on2084.outbound.protection.outlook.com ([40.107.94.84]:56855 "EHLO NAM10-MW2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728147AbgKCOun (ORCPT ); Tue, 3 Nov 2020 09:50:43 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gyw2sc26nWoYQfrVvT6mODot6bEYX+FzK5Gc6bdRWNEt4HXcIsda97zzBoLJaBWUnaj1ZKv9DXrAj/nuiGjrECnI2ZzuQ+hFxZvo5dqGfEHIym7oHE/MSygfyar4FCp0+HQK9wD8YLonZEbGNl3GmGdQmC3EcBzvoABV0guwdVT6Q7u3npFcw/Rk02vu+lET4gOoQlpzlH0DAMFMpwa8ykKLEHrWfoE1WwfNcvN5jCITj4mO6EP/8mpTjxeX805D3iLUkuxd55BL7ME+ZfhbDp6fOA4pFpqhiyiz8Oa/4UadtGrz7H4Nc4tsTMVS3Sgoq99XhbXOLAbq8sz1vlsaxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O4uvewgK15rxuMrJ6b5hS0TGovVVm3EmbA5qHjDNL2Y=; b=e69ZxXrw7WDmU1c+4QTgMwXsl3h2aCriFyKyajda6JkxETh+5RiarsxMuKZSX4eTT5WnBfYqlyshgOdhDXagi13OJkFCHez/HxaAv2mIXIxQ574xCvLh4TectZK0hEqGBfpRWUPbP13ZxiH0skzQHfIQhj2QV6QerNCO3WrpuNmqulMNhV2qK1UHMC/HaCiEN24j7dmvritald1XITHxnjF8k5Dy2DAzY5C9r6aWxEgmiymJZ1bt+M0mPd5WuS5zksScfnkZuQYZY2KEkO1odz+l9ycO/lKQzR3zTH3YoXekeM1D+coCrkg5U/QxYeErIdfm+wNci/6PhsG7kct4ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O4uvewgK15rxuMrJ6b5hS0TGovVVm3EmbA5qHjDNL2Y=; b=1a5jFyrRDMB30mfdNwkgjLuYjixV9Tjkl/WVrLct+xUjUZr4CGVQ4oxJoalaaDESSA8DSaSxAd5+YieVosO9mFjHpQU4nJk7X7VW3FA8gqjhonztYUbdZvl27OTSlN2eCHCYq5kj9mCpiH472+LOUqlH1m/GUHkK3yP/EE4UBLg= Received: from MN2PR12MB4488.namprd12.prod.outlook.com (2603:10b6:208:24e::19) by BL0PR12MB4993.namprd12.prod.outlook.com (2603:10b6:208:17e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 3 Nov 2020 14:50:40 +0000 Received: from MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::99dd:ff77:1ffd:d96a]) by MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::99dd:ff77:1ffd:d96a%3]) with mapi id 15.20.3499.030; Tue, 3 Nov 2020 14:50:40 +0000 From: "Deucher, Alexander" To: Greg KH , "Koenig, Christian" CC: Alex Deucher , Deepak R Varma , David Airlie , LKML , Maling list - DRI developers , Melissa Wen , amd-gfx list , Daniel Vetter , Daniel Vetter Subject: RE: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL Thread-Topic: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL Thread-Index: AQHWsUfYd9t8TfEeK0iKrVuVEXbttKm1PmOAgAAGUYCAALTIAIAAgv9w Date: Tue, 3 Nov 2020 14:50:40 +0000 Message-ID: References: <20201102184147.GA42288@localhost> <20201103065324.GD75930@kroah.com> In-Reply-To: <20201103065324.GD75930@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2020-11-03T14:46:11Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=8cd44351-a885-42e7-b368-00001f4bcac7; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_enabled: true msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_setdate: 2020-11-03T14:50:36Z msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_method: Privileged msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_name: Public_0 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_actionid: 80476161-f11c-4e9d-8282-00000c39e7f3 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_contentbits: 0 authentication-results: linuxfoundation.org; dkim=none (message not signed) header.d=none;linuxfoundation.org; dmarc=none action=none header.from=amd.com; x-originating-ip: [71.219.66.138] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e95c9d52-2773-42d2-3e56-08d88007d523 x-ms-traffictypediagnostic: BL0PR12MB4993: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9KN74nM18VI8CYPXoCYTnPiD/QkhaDTjEuja0sHqrbaVou8+ZERFQ8m+sfEIeHTmZXey5WPdRRmmnXXV8f5BMT0Z9IQPiS0Mks5KQnRLJ2hI0J/61l79wZ8jXM/VpVrMXA9D/Q2TVUkfjCTTMrohcy9N4q6zOIhSNPKw5K6jAJs9WnGhhwYAz9waQJwYHhUUcBPzXPKQ3rN06dh5EvguF7KoybBNQelBZ2ArO/7iJCTWe22rAsoppEVeHptX1T1hJ+2lOuv2mnCoRCGNtNDc95mJKjrl/KC8RlfIsc4RC8UySBgQ+JVCrGM8TRrYLJizbWfsHtCAI8q0dP8nxkuGRw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB4488.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(366004)(346002)(376002)(396003)(66446008)(86362001)(76116006)(66476007)(66946007)(54906003)(316002)(55016002)(5660300002)(8676002)(7416002)(4326008)(71200400001)(52536014)(478600001)(64756008)(110136005)(66556008)(6636002)(6506007)(53546011)(83380400001)(2906002)(9686003)(26005)(66574015)(7696005)(8936002)(33656002)(186003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: LnJpkmRUkQDXXZpPTXyniwj0QjKzH6eBYxNZdBeijiW2bnfYku2xPX9AxeRI4QxyauxWvLIpkBypyoe0ZM8xPe+ixsqxK/CVCIBMLc9eQ8x9VsVTB/aj6IG5/l6GIlXZaJ5RDGwPxcAQLMqq3hJztikiJev/pfEhh1/4X+3PAj/gEmc0nVkv4hhHI2bsNUEEN8P/m24vt3pDXSLFSgkwZ/XgovSbegukEM30fw0iHXN+TVC6Y6iycC8f4BDI26LP5c3wV/tISOKfbK6tRLIzY+VUoI6ygafLnHs9WMnUZeEQpmUkGQEvhBnjokJitMhglX3kCKFaqskYh+Z3QkF2/kblNqAqw7tDWNcV3+BoyMGcDc+fReSHi4tm7OzXhkdxrKAyVK5wV2R2PRuW07Y1HOqh3cEx9pJSA5svR8OXbNpwPaMg4MS/jRfTRdavGJNxS0N/mscMLB+lOIFhRLEECOWknkeYNkV2Xw8t0KP95Ig2dm+u5miYsVC4xwiVxdLx2UBMy/peZNBCoSYl4ElN4FI1TzsX90L+joQ90rnLbiyymRZCqxqpVcXSOc8nlMb9ZqlTEI9UHOXERdbj7n1K2jXorAPaiUG9TFMD1JnMshzNIVqwT5k1QiFyKn7I6XgoLT8XOS9GlPSDLqlx+6j+Ow== Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4488.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e95c9d52-2773-42d2-3e56-08d88007d523 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2020 14:50:40.1520 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UMrQM03bEiWFZr2/NjvUpo3xIKK9wFgmNZ8HtcJGIZEKQ2J0RqJpguLcq/f0bT0DY0DAEGn12g8HvdhEIYCDoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4993 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [AMD Public Use] > -----Original Message----- > From: Greg KH > Sent: Tuesday, November 3, 2020 1:53 AM > To: Koenig, Christian > Cc: Alex Deucher ; Deepak R Varma > ; David Airlie ; LKML kernel@vger.kernel.org>; Maling list - DRI developers devel@lists.freedesktop.org>; Melissa Wen ; > amd-gfx list ; Daniel Vetter > ; Daniel Vetter ; Deucher, > Alexander > Subject: Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 = or > NULL >=20 > On Mon, Nov 02, 2020 at 09:06:21PM +0100, Christian K=F6nig wrote: > > Am 02.11.20 um 20:43 schrieb Alex Deucher: > > > On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma > wrote: > > > > Initializing global variable to 0 or NULL is not necessary and > > > > should be avoided. Issue reported by checkpatch script as: > > > > ERROR: do not initialise globals to 0 (or NULL). > > > I agree that this is technically correct, but a lot of people don't > > > seem to know that so we get a lot of comments about this code for > > > the variables that are not explicitly set. Seems less confusing to > > > initialize them even if it not necessary. I don't have a > > > particularly strong opinion on it however. > > > > Agree with Alex. > > > > Especially for the module parameters we should have a explicit init > > value for documentation purposes, even when it is 0. >=20 > Why is this one tiny driver somehow special compared to the entire rest o= f > the kernel? (hint, it isn't...) >=20 > Please follow the normal coding style rules, there's no reason to ignore = them > unless you like to constantly reject patches like this that get sent to y= ou. >=20 I'll apply the patch, but as a data point, this is the first time I've gott= en a patch to make this change. I get several bug reports or patches every= year to explicitly set values to global variables because users assume the= y are not initialized. So it will always be a trade off as to which patche= s you want to NACK. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3B91C2D0A3 for ; Tue, 3 Nov 2020 14:50:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6928822450 for ; Tue, 3 Nov 2020 14:50:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="1a5jFyrR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6928822450 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 985066EC9E; Tue, 3 Nov 2020 14:50:43 +0000 (UTC) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2056.outbound.protection.outlook.com [40.107.94.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id 608C66EC9E; Tue, 3 Nov 2020 14:50:42 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gyw2sc26nWoYQfrVvT6mODot6bEYX+FzK5Gc6bdRWNEt4HXcIsda97zzBoLJaBWUnaj1ZKv9DXrAj/nuiGjrECnI2ZzuQ+hFxZvo5dqGfEHIym7oHE/MSygfyar4FCp0+HQK9wD8YLonZEbGNl3GmGdQmC3EcBzvoABV0guwdVT6Q7u3npFcw/Rk02vu+lET4gOoQlpzlH0DAMFMpwa8ykKLEHrWfoE1WwfNcvN5jCITj4mO6EP/8mpTjxeX805D3iLUkuxd55BL7ME+ZfhbDp6fOA4pFpqhiyiz8Oa/4UadtGrz7H4Nc4tsTMVS3Sgoq99XhbXOLAbq8sz1vlsaxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O4uvewgK15rxuMrJ6b5hS0TGovVVm3EmbA5qHjDNL2Y=; b=e69ZxXrw7WDmU1c+4QTgMwXsl3h2aCriFyKyajda6JkxETh+5RiarsxMuKZSX4eTT5WnBfYqlyshgOdhDXagi13OJkFCHez/HxaAv2mIXIxQ574xCvLh4TectZK0hEqGBfpRWUPbP13ZxiH0skzQHfIQhj2QV6QerNCO3WrpuNmqulMNhV2qK1UHMC/HaCiEN24j7dmvritald1XITHxnjF8k5Dy2DAzY5C9r6aWxEgmiymJZ1bt+M0mPd5WuS5zksScfnkZuQYZY2KEkO1odz+l9ycO/lKQzR3zTH3YoXekeM1D+coCrkg5U/QxYeErIdfm+wNci/6PhsG7kct4ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O4uvewgK15rxuMrJ6b5hS0TGovVVm3EmbA5qHjDNL2Y=; b=1a5jFyrRDMB30mfdNwkgjLuYjixV9Tjkl/WVrLct+xUjUZr4CGVQ4oxJoalaaDESSA8DSaSxAd5+YieVosO9mFjHpQU4nJk7X7VW3FA8gqjhonztYUbdZvl27OTSlN2eCHCYq5kj9mCpiH472+LOUqlH1m/GUHkK3yP/EE4UBLg= Received: from MN2PR12MB4488.namprd12.prod.outlook.com (2603:10b6:208:24e::19) by BL0PR12MB4993.namprd12.prod.outlook.com (2603:10b6:208:17e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 3 Nov 2020 14:50:40 +0000 Received: from MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::99dd:ff77:1ffd:d96a]) by MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::99dd:ff77:1ffd:d96a%3]) with mapi id 15.20.3499.030; Tue, 3 Nov 2020 14:50:40 +0000 From: "Deucher, Alexander" To: Greg KH , "Koenig, Christian" Subject: RE: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL Thread-Topic: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL Thread-Index: AQHWsUfYd9t8TfEeK0iKrVuVEXbttKm1PmOAgAAGUYCAALTIAIAAgv9w Date: Tue, 3 Nov 2020 14:50:40 +0000 Message-ID: References: <20201102184147.GA42288@localhost> <20201103065324.GD75930@kroah.com> In-Reply-To: <20201103065324.GD75930@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2020-11-03T14:46:11Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=8cd44351-a885-42e7-b368-00001f4bcac7; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_enabled: true msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_setdate: 2020-11-03T14:50:36Z msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_method: Privileged msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_name: Public_0 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_actionid: 80476161-f11c-4e9d-8282-00000c39e7f3 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_contentbits: 0 authentication-results: linuxfoundation.org; dkim=none (message not signed) header.d=none;linuxfoundation.org; dmarc=none action=none header.from=amd.com; x-originating-ip: [71.219.66.138] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e95c9d52-2773-42d2-3e56-08d88007d523 x-ms-traffictypediagnostic: BL0PR12MB4993: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9KN74nM18VI8CYPXoCYTnPiD/QkhaDTjEuja0sHqrbaVou8+ZERFQ8m+sfEIeHTmZXey5WPdRRmmnXXV8f5BMT0Z9IQPiS0Mks5KQnRLJ2hI0J/61l79wZ8jXM/VpVrMXA9D/Q2TVUkfjCTTMrohcy9N4q6zOIhSNPKw5K6jAJs9WnGhhwYAz9waQJwYHhUUcBPzXPKQ3rN06dh5EvguF7KoybBNQelBZ2ArO/7iJCTWe22rAsoppEVeHptX1T1hJ+2lOuv2mnCoRCGNtNDc95mJKjrl/KC8RlfIsc4RC8UySBgQ+JVCrGM8TRrYLJizbWfsHtCAI8q0dP8nxkuGRw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4488.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(346002)(376002)(396003)(66446008)(86362001)(76116006)(66476007)(66946007)(54906003)(316002)(55016002)(5660300002)(8676002)(7416002)(4326008)(71200400001)(52536014)(478600001)(64756008)(110136005)(66556008)(6636002)(6506007)(53546011)(83380400001)(2906002)(9686003)(26005)(66574015)(7696005)(8936002)(33656002)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: LnJpkmRUkQDXXZpPTXyniwj0QjKzH6eBYxNZdBeijiW2bnfYku2xPX9AxeRI4QxyauxWvLIpkBypyoe0ZM8xPe+ixsqxK/CVCIBMLc9eQ8x9VsVTB/aj6IG5/l6GIlXZaJ5RDGwPxcAQLMqq3hJztikiJev/pfEhh1/4X+3PAj/gEmc0nVkv4hhHI2bsNUEEN8P/m24vt3pDXSLFSgkwZ/XgovSbegukEM30fw0iHXN+TVC6Y6iycC8f4BDI26LP5c3wV/tISOKfbK6tRLIzY+VUoI6ygafLnHs9WMnUZeEQpmUkGQEvhBnjokJitMhglX3kCKFaqskYh+Z3QkF2/kblNqAqw7tDWNcV3+BoyMGcDc+fReSHi4tm7OzXhkdxrKAyVK5wV2R2PRuW07Y1HOqh3cEx9pJSA5svR8OXbNpwPaMg4MS/jRfTRdavGJNxS0N/mscMLB+lOIFhRLEECOWknkeYNkV2Xw8t0KP95Ig2dm+u5miYsVC4xwiVxdLx2UBMy/peZNBCoSYl4ElN4FI1TzsX90L+joQ90rnLbiyymRZCqxqpVcXSOc8nlMb9ZqlTEI9UHOXERdbj7n1K2jXorAPaiUG9TFMD1JnMshzNIVqwT5k1QiFyKn7I6XgoLT8XOS9GlPSDLqlx+6j+Ow== MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4488.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e95c9d52-2773-42d2-3e56-08d88007d523 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2020 14:50:40.1520 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UMrQM03bEiWFZr2/NjvUpo3xIKK9wFgmNZ8HtcJGIZEKQ2J0RqJpguLcq/f0bT0DY0DAEGn12g8HvdhEIYCDoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4993 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Deepak R Varma , David Airlie , Daniel Vetter , LKML , Maling list - DRI developers , Melissa Wen , amd-gfx list Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" [AMD Public Use] > -----Original Message----- > From: Greg KH > Sent: Tuesday, November 3, 2020 1:53 AM > To: Koenig, Christian > Cc: Alex Deucher ; Deepak R Varma > ; David Airlie ; LKML kernel@vger.kernel.org>; Maling list - DRI developers devel@lists.freedesktop.org>; Melissa Wen ; > amd-gfx list ; Daniel Vetter > ; Daniel Vetter ; Deucher, > Alexander > Subject: Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 = or > NULL > = > On Mon, Nov 02, 2020 at 09:06:21PM +0100, Christian K=F6nig wrote: > > Am 02.11.20 um 20:43 schrieb Alex Deucher: > > > On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma > wrote: > > > > Initializing global variable to 0 or NULL is not necessary and > > > > should be avoided. Issue reported by checkpatch script as: > > > > ERROR: do not initialise globals to 0 (or NULL). > > > I agree that this is technically correct, but a lot of people don't > > > seem to know that so we get a lot of comments about this code for > > > the variables that are not explicitly set. Seems less confusing to > > > initialize them even if it not necessary. I don't have a > > > particularly strong opinion on it however. > > > > Agree with Alex. > > > > Especially for the module parameters we should have a explicit init > > value for documentation purposes, even when it is 0. > = > Why is this one tiny driver somehow special compared to the entire rest of > the kernel? (hint, it isn't...) > = > Please follow the normal coding style rules, there's no reason to ignore = them > unless you like to constantly reject patches like this that get sent to y= ou. > = I'll apply the patch, but as a data point, this is the first time I've gott= en a patch to make this change. I get several bug reports or patches every= year to explicitly set values to global variables because users assume the= y are not initialized. So it will always be a trade off as to which patche= s you want to NACK. Alex _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6667BC388F7 for ; Tue, 3 Nov 2020 14:50:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 121E022450 for ; Tue, 3 Nov 2020 14:50:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="1a5jFyrR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 121E022450 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E77806ECB6; Tue, 3 Nov 2020 14:50:43 +0000 (UTC) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2056.outbound.protection.outlook.com [40.107.94.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id 608C66EC9E; Tue, 3 Nov 2020 14:50:42 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gyw2sc26nWoYQfrVvT6mODot6bEYX+FzK5Gc6bdRWNEt4HXcIsda97zzBoLJaBWUnaj1ZKv9DXrAj/nuiGjrECnI2ZzuQ+hFxZvo5dqGfEHIym7oHE/MSygfyar4FCp0+HQK9wD8YLonZEbGNl3GmGdQmC3EcBzvoABV0guwdVT6Q7u3npFcw/Rk02vu+lET4gOoQlpzlH0DAMFMpwa8ykKLEHrWfoE1WwfNcvN5jCITj4mO6EP/8mpTjxeX805D3iLUkuxd55BL7ME+ZfhbDp6fOA4pFpqhiyiz8Oa/4UadtGrz7H4Nc4tsTMVS3Sgoq99XhbXOLAbq8sz1vlsaxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O4uvewgK15rxuMrJ6b5hS0TGovVVm3EmbA5qHjDNL2Y=; b=e69ZxXrw7WDmU1c+4QTgMwXsl3h2aCriFyKyajda6JkxETh+5RiarsxMuKZSX4eTT5WnBfYqlyshgOdhDXagi13OJkFCHez/HxaAv2mIXIxQ574xCvLh4TectZK0hEqGBfpRWUPbP13ZxiH0skzQHfIQhj2QV6QerNCO3WrpuNmqulMNhV2qK1UHMC/HaCiEN24j7dmvritald1XITHxnjF8k5Dy2DAzY5C9r6aWxEgmiymJZ1bt+M0mPd5WuS5zksScfnkZuQYZY2KEkO1odz+l9ycO/lKQzR3zTH3YoXekeM1D+coCrkg5U/QxYeErIdfm+wNci/6PhsG7kct4ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O4uvewgK15rxuMrJ6b5hS0TGovVVm3EmbA5qHjDNL2Y=; b=1a5jFyrRDMB30mfdNwkgjLuYjixV9Tjkl/WVrLct+xUjUZr4CGVQ4oxJoalaaDESSA8DSaSxAd5+YieVosO9mFjHpQU4nJk7X7VW3FA8gqjhonztYUbdZvl27OTSlN2eCHCYq5kj9mCpiH472+LOUqlH1m/GUHkK3yP/EE4UBLg= Received: from MN2PR12MB4488.namprd12.prod.outlook.com (2603:10b6:208:24e::19) by BL0PR12MB4993.namprd12.prod.outlook.com (2603:10b6:208:17e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 3 Nov 2020 14:50:40 +0000 Received: from MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::99dd:ff77:1ffd:d96a]) by MN2PR12MB4488.namprd12.prod.outlook.com ([fe80::99dd:ff77:1ffd:d96a%3]) with mapi id 15.20.3499.030; Tue, 3 Nov 2020 14:50:40 +0000 From: "Deucher, Alexander" To: Greg KH , "Koenig, Christian" Subject: RE: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL Thread-Topic: [PATCH] drm/amdgpu: do not initialise global variables to 0 or NULL Thread-Index: AQHWsUfYd9t8TfEeK0iKrVuVEXbttKm1PmOAgAAGUYCAALTIAIAAgv9w Date: Tue, 3 Nov 2020 14:50:40 +0000 Message-ID: References: <20201102184147.GA42288@localhost> <20201103065324.GD75930@kroah.com> In-Reply-To: <20201103065324.GD75930@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2020-11-03T14:46:11Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=8cd44351-a885-42e7-b368-00001f4bcac7; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_enabled: true msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_setdate: 2020-11-03T14:50:36Z msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_method: Privileged msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_name: Public_0 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_actionid: 80476161-f11c-4e9d-8282-00000c39e7f3 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_contentbits: 0 authentication-results: linuxfoundation.org; dkim=none (message not signed) header.d=none;linuxfoundation.org; dmarc=none action=none header.from=amd.com; x-originating-ip: [71.219.66.138] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: e95c9d52-2773-42d2-3e56-08d88007d523 x-ms-traffictypediagnostic: BL0PR12MB4993: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9KN74nM18VI8CYPXoCYTnPiD/QkhaDTjEuja0sHqrbaVou8+ZERFQ8m+sfEIeHTmZXey5WPdRRmmnXXV8f5BMT0Z9IQPiS0Mks5KQnRLJ2hI0J/61l79wZ8jXM/VpVrMXA9D/Q2TVUkfjCTTMrohcy9N4q6zOIhSNPKw5K6jAJs9WnGhhwYAz9waQJwYHhUUcBPzXPKQ3rN06dh5EvguF7KoybBNQelBZ2ArO/7iJCTWe22rAsoppEVeHptX1T1hJ+2lOuv2mnCoRCGNtNDc95mJKjrl/KC8RlfIsc4RC8UySBgQ+JVCrGM8TRrYLJizbWfsHtCAI8q0dP8nxkuGRw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4488.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(346002)(376002)(396003)(66446008)(86362001)(76116006)(66476007)(66946007)(54906003)(316002)(55016002)(5660300002)(8676002)(7416002)(4326008)(71200400001)(52536014)(478600001)(64756008)(110136005)(66556008)(6636002)(6506007)(53546011)(83380400001)(2906002)(9686003)(26005)(66574015)(7696005)(8936002)(33656002)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: LnJpkmRUkQDXXZpPTXyniwj0QjKzH6eBYxNZdBeijiW2bnfYku2xPX9AxeRI4QxyauxWvLIpkBypyoe0ZM8xPe+ixsqxK/CVCIBMLc9eQ8x9VsVTB/aj6IG5/l6GIlXZaJ5RDGwPxcAQLMqq3hJztikiJev/pfEhh1/4X+3PAj/gEmc0nVkv4hhHI2bsNUEEN8P/m24vt3pDXSLFSgkwZ/XgovSbegukEM30fw0iHXN+TVC6Y6iycC8f4BDI26LP5c3wV/tISOKfbK6tRLIzY+VUoI6ygafLnHs9WMnUZeEQpmUkGQEvhBnjokJitMhglX3kCKFaqskYh+Z3QkF2/kblNqAqw7tDWNcV3+BoyMGcDc+fReSHi4tm7OzXhkdxrKAyVK5wV2R2PRuW07Y1HOqh3cEx9pJSA5svR8OXbNpwPaMg4MS/jRfTRdavGJNxS0N/mscMLB+lOIFhRLEECOWknkeYNkV2Xw8t0KP95Ig2dm+u5miYsVC4xwiVxdLx2UBMy/peZNBCoSYl4ElN4FI1TzsX90L+joQ90rnLbiyymRZCqxqpVcXSOc8nlMb9ZqlTEI9UHOXERdbj7n1K2jXorAPaiUG9TFMD1JnMshzNIVqwT5k1QiFyKn7I6XgoLT8XOS9GlPSDLqlx+6j+Ow== MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4488.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e95c9d52-2773-42d2-3e56-08d88007d523 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2020 14:50:40.1520 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UMrQM03bEiWFZr2/NjvUpo3xIKK9wFgmNZ8HtcJGIZEKQ2J0RqJpguLcq/f0bT0DY0DAEGn12g8HvdhEIYCDoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4993 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Deepak R Varma , David Airlie , Daniel Vetter , LKML , Maling list - DRI developers , Melissa Wen , amd-gfx list , Daniel Vetter , Alex Deucher Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" [AMD Public Use] > -----Original Message----- > From: Greg KH > Sent: Tuesday, November 3, 2020 1:53 AM > To: Koenig, Christian > Cc: Alex Deucher ; Deepak R Varma > ; David Airlie ; LKML kernel@vger.kernel.org>; Maling list - DRI developers devel@lists.freedesktop.org>; Melissa Wen ; > amd-gfx list ; Daniel Vetter > ; Daniel Vetter ; Deucher, > Alexander > Subject: Re: [PATCH] drm/amdgpu: do not initialise global variables to 0 = or > NULL > = > On Mon, Nov 02, 2020 at 09:06:21PM +0100, Christian K=F6nig wrote: > > Am 02.11.20 um 20:43 schrieb Alex Deucher: > > > On Mon, Nov 2, 2020 at 1:42 PM Deepak R Varma > wrote: > > > > Initializing global variable to 0 or NULL is not necessary and > > > > should be avoided. Issue reported by checkpatch script as: > > > > ERROR: do not initialise globals to 0 (or NULL). > > > I agree that this is technically correct, but a lot of people don't > > > seem to know that so we get a lot of comments about this code for > > > the variables that are not explicitly set. Seems less confusing to > > > initialize them even if it not necessary. I don't have a > > > particularly strong opinion on it however. > > > > Agree with Alex. > > > > Especially for the module parameters we should have a explicit init > > value for documentation purposes, even when it is 0. > = > Why is this one tiny driver somehow special compared to the entire rest of > the kernel? (hint, it isn't...) > = > Please follow the normal coding style rules, there's no reason to ignore = them > unless you like to constantly reject patches like this that get sent to y= ou. > = I'll apply the patch, but as a data point, this is the first time I've gott= en a patch to make this change. I get several bug reports or patches every= year to explicitly set values to global variables because users assume the= y are not initialized. So it will always be a trade off as to which patche= s you want to NACK. Alex _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx