From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E16F6C433DB for ; Mon, 8 Mar 2021 13:16:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97B88651C3 for ; Mon, 8 Mar 2021 13:16:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97B88651C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE7E06E3CE; Mon, 8 Mar 2021 13:16:23 +0000 (UTC) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-eopbgr760041.outbound.protection.outlook.com [40.107.76.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 69E576E3CE for ; Mon, 8 Mar 2021 13:16:22 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ebDPEoT7h8xNxDxpcog8alFZcnakKw6dPk0AI9PBbEX3wVFL6C0OwR+90tR/qqxtXNP5r48w64+4EfFsnlDEt70rZW5Ty51M9npaGuE5n+K+dVTNvva1plYa9x4c3S08xM2JohcVQeILEc9iJlYZ5hRBtpyUnhoTosoRsMUJrHmxzzuiBUl9qMgep3sCYa7mmGHzPfsYouh39r6E0/P8TCPgdbcP/rZR1LmO6VlOiY6nLvSpWf2/moBlMc4TmEucxRMedCcQP2uSkkPLpedBrWnG2jPZGQhHyiZBTXvEHu7ob16+J/b7qfbkjl1D6VXkv7HIanKjA4Tzw0bJcEMppg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VEcj4C/xOete7jF0ocpMj4aCnHbZxdALcXjU05s6kXs=; b=GFt2BLUW4Nchk0cV3A5y5lIH8r+/rRGK22AImGPHbfYgmSReFqlmnoSanRtCHedDcZYzp9MW3CRqncGOSisndcXFoTCiTFLemyVhYMUKeXCJZCa1rM5SD9eWW9edERGld0saol8X+2PwLnQqcBWah+1+0i8bgQKflqvT6FMBi/6S+EznnlJZnETdn3fB4Ak0bQhb3vgAd3aLmTnwnnGTVaWuBu9NXeFCPjvps4WbfdJLtrmfRS8UBE5wkDTy0+x6LbbQNe6r2dmcRN6WG4+MKM0s+1vSL8kRgHr08AaJVE4js+hyMcwqu90ltdGllVr2gW6FSlU1N7Fjjcv8QfMIdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VEcj4C/xOete7jF0ocpMj4aCnHbZxdALcXjU05s6kXs=; b=qaNzYrGteumgDlNx9NirKbZZMYhWS6Dt2dDcXzK6JQNwvmW4HbMHIgIhxqn7rdY7W0LE/GckZMk6T3zAbQ7vzNdxpwTFGDQJZynQLimGNTskjcemNKDmqC/v3rWaedF2C5f8KPhoc75g4AVuJDiS/zqxE9y5qeVIW4z21muWXyY= Received: from MN2PR12MB4549.namprd12.prod.outlook.com (2603:10b6:208:268::15) by MN2PR12MB4518.namprd12.prod.outlook.com (2603:10b6:208:266::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Mon, 8 Mar 2021 13:16:21 +0000 Received: from MN2PR12MB4549.namprd12.prod.outlook.com ([fe80::c1a6:7b2b:9494:776a]) by MN2PR12MB4549.namprd12.prod.outlook.com ([fe80::c1a6:7b2b:9494:776a%4]) with mapi id 15.20.3890.038; Mon, 8 Mar 2021 13:16:21 +0000 From: "Lazar, Lijo" To: "Lazar, Lijo" , "amd-gfx@lists.freedesktop.org" Subject: RE: [PATCH] drm/amdgpu: Check if FB BAR is enabled for ROM read Thread-Topic: [PATCH] drm/amdgpu: Check if FB BAR is enabled for ROM read Thread-Index: AdcP5nVD09suR7nBQdywlWsyhxQOWwENr39A Date: Mon, 8 Mar 2021 13:16:20 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2021-03-08T13:16:15Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=575272b1-45a7-4751-841a-8ae25924f542; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1 authentication-results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; x-originating-ip: [165.204.159.242] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7e2f46df-22c4-4564-9b7e-08d8e2345da8 x-ms-traffictypediagnostic: MN2PR12MB4518: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1122; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UMdI0ULfPw0N6iaFiP0H5E7Y9e1ix7oze+bwDDUGJobN6/9Meobt6U/UhG0DqIYL5+YwBnW4bYUnPVsUsokoklGzXojC02v2BlIyO4Zd/J2cL7T9QDfrsGpv2WR5qZ3sWIhf+HMcUKUazcn2GNQ/Uqbo2K/Vid4s+VSg4534/JqNJJ5Pn8nRCtVp+UYwl5ypPmcCHqKJ4/ry5JwqAq/c3dpemsEx/8khdZSC1AN9+OhRUYA2OekZRgw5xU2n6fNESNWOk4XIr/wFUfdg1EMcjroDcuqzD89PjOe8GfYwUnLVrJ5XKJTnU8Ypb1vpfCGaE7TL4W+lHMj9iaz3WhUiR5w79+aLUnEuk9BWbHtFLs3OOvCICMliJnw5wuEAlZL8v0z0dy9oaNDR/YpGBUU77a/dzh4NhmczkCoiznDRPhbhNJlNbUP+QQgJT4PzMcyoDCDMilFO3563Z5rkPf0KI0Ycg4RzOctjq+VX/ZCypmW0Y7hJA2lPT0ASEULdeSkoQgSdgzJthQ9Qnht+FMK1lA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4549.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(136003)(346002)(366004)(376002)(2906002)(316002)(8936002)(110136005)(9686003)(86362001)(33656002)(8676002)(76116006)(54906003)(66476007)(55016002)(5660300002)(66556008)(64756008)(4326008)(66446008)(26005)(52536014)(478600001)(186003)(53546011)(6506007)(71200400001)(7696005)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?cyrfhl86wHg0y5ze6GNHawWWMBEV5JYr/YTDrXKlOPIApUqa0qI4StofdOq6?= =?us-ascii?Q?SeUTVTxexssKWh+6wCAk6vfIEetMW7m+dGvYsg+T8vRWl5S0D+s+vcv3jQY0?= =?us-ascii?Q?nfPeMKKUWR8uK8OrnWH5u1VwJflah3pC6pqE8+UA0ccd3yzRLc2XlS+ezGs8?= =?us-ascii?Q?Ps1ZGlAcjqQ93fb8rZkn9/s45mc1WwBdh7aMLZbE4r9VOTY57JTAabg/qgM4?= =?us-ascii?Q?YbWugCuO25vBuVYWoRU/zIViXOjQQ3ERUTxBBUoaleULBEyPvNYLwFmWeeAJ?= =?us-ascii?Q?OHGwmuQIiL5pS3bYpxpt6/vqSZPdiLWrdikQgL7DcwJ5LqmrYiicU+LTeLtm?= =?us-ascii?Q?25xNXwWSsMqqrj1BN4FSG849Tb0AnyjzSyhELtpymLZK/pmI5p0IGU/n8MPA?= =?us-ascii?Q?zKe8iyK7iXA9Ugsp25eTupuSGxtviw/JrM4vARcsMETXp/N2O2+kWsHnQ602?= =?us-ascii?Q?z9zqgOPkaLaLli+lIWAQxs5jHpIEXZZZvuaIdCYsU6wBj396Xh8XGC6eE17q?= =?us-ascii?Q?mrOWTHrbeEud8Mf+u0th89ikHEdDWxVb58sXHBnCSsN2YawJTwFoD+g31CUS?= =?us-ascii?Q?huKoytd66YUG1bTuLH1wsacYgg4KrB9GrOe8ILvR2OEMiKj9rlmIoKUFNnk5?= =?us-ascii?Q?2xj2a8Ll5J7WSo3SrvWhof+KtLnFWy6lbzwJ3kNHRe8giR7gA6Okwcao3CAK?= =?us-ascii?Q?W40udYdmXQJPmibdAe68mIcn2Xsczvd92zR3CfpfRGVMhYVkPlZKYOCCApE1?= =?us-ascii?Q?cCTyQjoXa4YrWMSrvuZy9jEWeMsWcTsuOa9/58Khsc+3LWgSC2NFjsInlWD1?= =?us-ascii?Q?+6FxDfkG0ZuWdeIoaMB4DodvLPxu4Pws9J41OOeCUx7cR52PU41tIyRCUYM8?= =?us-ascii?Q?/2pASNjVJCCsURMJ74ohOsHJG8EERfZriI+OsGYU19aBqGuF9JGX3VnAF57T?= =?us-ascii?Q?XcpJanfgBfjPWhvP4YMjJPHKD44lmcz2rwIkgzlZoEGs/FkbJlTONmZ0e3yr?= =?us-ascii?Q?R1708tGnS5sA/QBhlAV5B0po61jTsYrNr99YqCoxCF4mS3FUhTsXoUDxcn//?= =?us-ascii?Q?WAnwzEV6VPdmfOXWEmh1+ew9XgR3VpB4/JM+mX5ZJHj67FhRWqqBm0tQAsjA?= =?us-ascii?Q?CFK0CmGS57qkqtBH9VtCN1GIlkkajT0+tXy/pgDqsn5SEct2ouOeHyB57MBV?= =?us-ascii?Q?MxmNWUNKM9/4+q4N46uI0rPhOsKKEiP8WahdDbDXD+5Pk2nbcf6O3/cbWJDw?= =?us-ascii?Q?2rJt8GEeRDPP5ZIX6IXT/0yD2WPtweObKgrclFPXG9lvAmngLhraK8eeTP86?= =?us-ascii?Q?GV3XAHE88+0iNfceIuqApJ9D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4549.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e2f46df-22c4-4564-9b7e-08d8e2345da8 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2021 13:16:20.8899 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cFqXmwh+ZHWuIFR3Ow+ole+3Sjh3AyRi4gLt1+HEuewJUADRJDZ6C5lCfVr3BcMz X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4518 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Deucher, Alexander" , "Xu, Feifei" , "Zhang, Hawking" Content-Type: multipart/mixed; boundary="===============1975842871==" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" --===============1975842871== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN2PR12MB45492AABD8B376AE9848601097939MN2PR12MB4549namp_" --_000_MN2PR12MB45492AABD8B376AE9848601097939MN2PR12MB4549namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Public Use] From: amd-gfx On Behalf Of Lazar, L= ijo Sent: Wednesday, March 3, 2021 10:15 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Xu, Feifei ; Zhang, Hawking Subject: [PATCH] drm/amdgpu: Check if FB BAR is enabled for ROM read [AMD Public Use] Some configurations don't have FB BAR enabled. Avoid reading ROM image from FB BAR region in such cases. Signed-off-by: Lijo Lazar > Reviewed-by: Hawking Zhang > Reviewed-by: Feifei Xu > --- drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c b/drivers/gpu/drm/amd= /amdgpu/amdgpu_bios.c index efdf639f6593..f454a6bd0ed6 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c @@ -97,6 +97,10 @@ static bool igp_read_bios_from_vram(struct amdgpu_device= *adev) if (amdgpu_device_need_post(adev)) return false; + /* FB BAR not enabled */ + if (pci_resource_len(adev->pdev, 0) =3D=3D 0) + return false; + adev->bios =3D NULL; vram_base =3D pci_resource_start(adev->pdev, 0); bios =3D ioremap_wc(vram_base, size); -- 2.29.2 --_000_MN2PR12MB45492AABD8B376AE9848601097939MN2PR12MB4549namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Publ= ic Use]

 

<Ping>

 

From: amd-gfx <amd-gfx-bounces@lists.freed= esktop.org> On Behalf Of Lazar, Lijo
Sent: Wednesday, March 3, 2021 10:15 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Xu, Feifei= <Feifei.Xu@amd.com>; Zhang, Hawking <Hawking.Zhang@amd.com> Subject: [PATCH] drm/amdgpu: Check if FB BAR is enabled for ROM read=

 

[AMD Publ= ic Use]

 

Some configurations don't have FB BAR enabled. Avoid= reading ROM image

from FB BAR region in such cases.

 

Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>

Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>

Reviewed-by: Feifei Xu <Feifei.Xu@amd.com>

---

drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 4 ++++

1 file changed, 4 insertions(+)

 

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.= c b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c

index efdf639f6593..f454a6bd0ed6 100644

--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c<= /o:p>

+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c<= /o:p>

@@ -97,6 +97,10 @@ static bool igp_read_bios_from_vr= am(struct amdgpu_device *adev)

        &nbs= p;       if (amdgpu_device_need_post(adev))

        &nbs= p;            &= nbsp;  return false;

 

+       /* FB BAR not = enabled */

+       if (pci_resour= ce_len(adev->pdev, 0) =3D=3D 0)

+        &nb= sp;      return false;

+

        adev->= bios =3D NULL;

        vram_base= =3D pci_resource_start(adev->pdev, 0);

        bios =3D = ioremap_wc(vram_base, size);

--

2.29.2

--_000_MN2PR12MB45492AABD8B376AE9848601097939MN2PR12MB4549namp_-- --===============1975842871== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx --===============1975842871==--