From: Sudarsana Reddy Kalluru <skalluru@marvell.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>,
Ariel Elior <aelior@marvell.com>,
GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"it+linux-netdev@molgen.mpg.de" <it+linux-netdev@molgen.mpg.de>
Subject: RE: bnx2x: Latest firmware requirement breaks no regression policy
Date: Wed, 19 Feb 2020 08:49:33 +0000 [thread overview]
Message-ID: <MN2PR18MB2528C681601B34D05100DF89D3100@MN2PR18MB2528.namprd18.prod.outlook.com> (raw)
In-Reply-To: <ffbcf99c-8274-eca1-5166-efc0828ca05b@molgen.mpg.de>
Hi Paul,
The firmware file referred below (i.e., storm FW) should be present on the host (i.e., /lib/firmware/bnx2x/ path), not the device. Driver must require this version of the FW to initialize the device, and hence provide the network functionality. Also, the driver is not backward compatible with older FW versions.
So it's not possible to handle the below error scenario in the driver,
> bnx2x 0000:41:00.0: Direct firmware load for bnx2x/bnx2x-e1h-7.13.11.0.fw failed with error -2
> bnx2x: [bnx2x_init_firmware:13557(net02)]Can't load firmware file bnx2x/bnx2x-e1h-7.13.11.0.fw
At the most, we can validate the existence of FW file on the host during the kernel build or installation.
FW image name from driver sources:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:
#define FW_FILE_NAME_E1 "bnx2x/bnx2x-e1-" FW_FILE_VERSION ".fw"
#define FW_FILE_NAME_E1H "bnx2x/bnx2x-e1h-" FW_FILE_VERSION ".fw"
#define FW_FILE_NAME_E2 "bnx2x/bnx2x-e2-" FW_FILE_VERSION ".fw"
FW image path on the host:
/lib/firmware/bnx2x/bnx2x-e1h-7.13.11.0.fw
Thanks,
Sudarsana
> -----Original Message-----
> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org> On
> Behalf Of Paul Menzel
> Sent: Monday, February 17, 2020 6:48 PM
> To: Ariel Elior <aelior@marvell.com>; Sudarsana Reddy Kalluru
> <skalluru@marvell.com>; GR-everest-linux-l2 <GR-everest-linux-
> l2@marvell.com>
> Cc: netdev@vger.kernel.org; LKML <linux-kernel@vger.kernel.org>; it+linux-
> netdev@molgen.mpg.de
> Subject: bnx2x: Latest firmware requirement breaks no regression policy
>
> Dear Linux folks,
>
>
> Updating a server from 4.19.x to 5.4.x, the network device
>
> Ethernet controller [0200]: Broadcom Inc. and subsidiaries NetXtreme II
> BCM57711 10-Gigabit PCIe [14e4:164f]
>
> failed to initialize due to missing firmware.
>
> bnx2x 0000:41:00.0: Direct firmware load for bnx2x/bnx2x-e1h-7.13.11.0.fw
> failed with error -2
> bnx2x: [bnx2x_init_firmware:13557(net02)]Can't load firmware file
> bnx2x/bnx2x-e1h-7.13.11.0.fw
> bnx2x: [bnx2x_func_hw_init:6002(net02)]Error loading firmware
> bnx2x: [bnx2x_nic_load:2730(net02)]HW init failed, aborting
>
> That is undesired, because without network access one has to have
> direct system access to find out what is wrong.
>
> Could you please change the policy to only print a big warning,
> if the latest firmware is not available, and an update suggestion?
>
>
> Kind regards,
>
> Paul
next prev parent reply other threads:[~2020-02-19 8:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 13:18 bnx2x: Latest firmware requirement breaks no regression policy Paul Menzel
2020-02-19 8:49 ` Sudarsana Reddy Kalluru [this message]
2020-02-19 12:43 ` Paul Menzel
2020-02-20 9:17 ` [EXT] " Sudarsana Reddy Kalluru
2020-02-20 15:40 ` Ariel Elior
2020-02-21 0:37 ` Jakub Kicinski
2020-02-24 17:34 ` Ariel Elior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR18MB2528C681601B34D05100DF89D3100@MN2PR18MB2528.namprd18.prod.outlook.com \
--to=skalluru@marvell.com \
--cc=GR-everest-linux-l2@marvell.com \
--cc=aelior@marvell.com \
--cc=it+linux-netdev@molgen.mpg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.