All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Kalderon <mkalderon@marvell.com>
To: Potnuri Bharat Teja <bharat@chelsio.com>,
	"jgg@ziepe.ca" <jgg@ziepe.ca>,
	"dledford@redhat.com" <dledford@redhat.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"nirranjan@chelsio.com" <nirranjan@chelsio.com>
Subject: RE: [PATCH for-next] iw_cxgb3: remove iw_cxgb3 module from kernel.
Date: Thu, 10 Oct 2019 14:26:37 +0000	[thread overview]
Message-ID: <MN2PR18MB318268F5426A2FFD5AB6F014A1940@MN2PR18MB3182.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20190930074252.20133-1-bharat@chelsio.com>

> From: linux-rdma-owner@vger.kernel.org <linux-rdma-
> owner@vger.kernel.org> On Behalf Of Potnuri Bharat Teja
> 
> remove iw_cxgb3 module from kernel as the corresponding HW Chelsio T3
> has
> reached EOL.
> 
> Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
> ---
>  include/uapi/rdma/rdma_user_ioctl_cmds.h      |    1 -
> 
> diff --git a/include/uapi/rdma/rdma_user_ioctl_cmds.h
> b/include/uapi/rdma/rdma_user_ioctl_cmds.h
> index b8bb285f6b2a..b2680051047a 100644
> --- a/include/uapi/rdma/rdma_user_ioctl_cmds.h
> +++ b/include/uapi/rdma/rdma_user_ioctl_cmds.h
> @@ -88,7 +88,6 @@ enum rdma_driver_id {
>  	RDMA_DRIVER_UNKNOWN,
>  	RDMA_DRIVER_MLX5,
>  	RDMA_DRIVER_MLX4,
> -	RDMA_DRIVER_CXGB3,
>  	RDMA_DRIVER_CXGB4,
>  	RDMA_DRIVER_MTHCA,
>  	RDMA_DRIVER_BNXT_RE,

This can't simply be removed, it breaks the drivers defined after this abi with rdma-core which uses a different driver_id
Removing this from rdma-core as well isn't sufficient due to backward / forward computability
Perhaps modify this with RDMA_DRIVER_RESERVED ? 

Thanks,
Michal


> --
> 2.18.0.232.gb7bd9486b055


  parent reply	other threads:[~2019-10-10 14:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-30  7:42 [PATCH for-next] iw_cxgb3: remove iw_cxgb3 module from kernel Potnuri Bharat Teja
2019-10-04 18:11 ` Jason Gunthorpe
2019-10-17  6:41   ` Adit Ranadive
2019-10-17  8:29     ` Potnuri Bharat Teja
2019-10-18 20:47     ` Jason Gunthorpe
2019-10-18 20:49       ` Doug Ledford
2019-10-10 14:26 ` Michal Kalderon [this message]
2019-10-16 17:47 ` Don Dutile
2019-10-17  6:06   ` Leon Romanovsky
2019-10-18 20:46   ` Jason Gunthorpe
2019-10-18 20:51     ` Doug Ledford
2019-10-18 22:50       ` Don Dutile

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR18MB318268F5426A2FFD5AB6F014A1940@MN2PR18MB3182.namprd18.prod.outlook.com \
    --to=mkalderon@marvell.com \
    --cc=bharat@chelsio.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    --cc=nirranjan@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.