RE: [PATCH v7 rdma-next 0/7] RDMA/qedr: Use the doorbell overflow recovery mechanism for RDMA

[Michal Kalderon <mkalderon@marvell.com>]

[-- Attachment #1: Type: text/plain, Size: 1587 bytes --]

Thanks Gal, 

I think I found the problem for the issue below, attached a patch that should be applied on top of the series. 
Please let me know if this fixed the issues you are seeing. 
In qedr we work with only single pages, and this issue will only occur with multiple pages. 

Thanks,
Michal

> -----Original Message-----
> From: Gal Pressman <galpress@amazon.com>
> Sent: Wednesday, August 21, 2019 1:15 PM
> To: Michal Kalderon <mkalderon@marvell.com>
> Cc: jgg@ziepe.ca; dledford@redhat.com; Ariel Elior <aelior@marvell.com>;
> bmt@zurich.ibm.com; sleybo@amazon.com; leon@kernel.org; linux-
> rdma@vger.kernel.org
> Subject: Re: [PATCH v7 rdma-next 0/7] RDMA/qedr: Use the doorbell
> overflow recovery mechanism for RDMA
> 
> On 21/08/2019 11:03, Michal Kalderon wrote:
> > Hi Gal,
> >
> > Thanks for the quick testing and feedback!
> >
> > Can you share some more information on the scenario you're running ?
> 
> It happens on most of our automated tests.
> I reproduce it manually by running ib_send_{bw,lat} over SRD.
> 
> > Does this happen each time or intermittently ?
> 
> Happens on most of the runs.
> 
> > Can you send me your .config ?
> 
> Attached.
> 
> > are you running agains rdma-next tree ?
> 
> Yes, commit 77905379e9b2 ("RDMA/hns: Remove unuseful member") with
> this series applied on top.
> 
> > Can  you reproduce with enabling ib_core module dynamic debug on ?
> 
> Attached a log of ib_send_bw running with ib_core and ib_uverbs dynamic
> debug enabled.
> 
> Let me know if there's anything else I can do.

[-- Attachment #2: 0001-Fix-bad-page-state-output-when-run-with-efa-driver.patch --]
[-- Type: application/octet-stream, Size: 940 bytes --]

From 3a05938eab4cccecce58a38618e9623c4251a1bd Mon Sep 17 00:00:00 2001
From: Michal Kalderon <michal.kalderon@marvell.com>
Date: Wed, 21 Aug 2019 13:26:43 +0300
Subject: [PATCH] Fix bad page state output when run with efa driver

---
 drivers/infiniband/core/ib_core_uverbs.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/core/ib_core_uverbs.c b/drivers/infiniband/core/ib_core_uverbs.c
index cce20172cd71..30b36b7c330c 100644
--- a/drivers/infiniband/core/ib_core_uverbs.c
+++ b/drivers/infiniband/core/ib_core_uverbs.c
@@ -222,9 +222,10 @@ void rdma_user_mmap_entry_free(struct kref *kref)
 			  entry->obj, rdma_user_mmap_get_key(entry),
 			  entry->address, entry->length, npages);
 
-		if (ucontext->device->ops.mmap_free)
-			ucontext->device->ops.mmap_free(entry);
 	}
+	if (ucontext->device->ops.mmap_free)
+		ucontext->device->ops.mmap_free(entry);
+
 	kfree(entry);
 }
 
-- 
2.14.5