From: "VAUTRIN Emmanuel (Canal Plus Prestataire)" <Emmanuel.VAUTRIN@cpexterne.org> To: Daniel Wagner <email@example.com> Cc: "firstname.lastname@example.org" <email@example.com> Subject: RE: [PATCH] build: Fix compiler maybe-uninitialized warnings Date: Mon, 13 Sep 2021 07:45:19 +0000 [thread overview] Message-ID: <MRZP264MB1544BB065A7FADD9BC38F69693D99@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM> (raw) In-Reply-To: <firstname.lastname@example.org> Hello Daniel, > > - provision_service_wifi(config, service, network, > > - ssid, ssid_len); > > + provision_service_wifi(config, service, network); > Could you split this into cleanup patch with a commit message? In fact, all my modifications are fixes of maybe-uninitialized warnings. In this case, ssid is not initialized. I thought title was explicit enough, what can I had in my comment? > > + char *dom = NULL; > Same here (maybe including the compiler warning). Do you really want to split patches even if they correspond to the same activity (maybe-uninitialized warnings)? > For the tools/* fixes this is okay. Not really important stuff :) Indeed, just compilation stuff, I don't think it could have any impact at usage, but it fixes the -Wall -Werror compilation. Best Regards, Emmanuel
next prev parent reply other threads:[~2021-09-13 7:45 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-13 7:17 VAUTRIN Emmanuel (Canal Plus Prestataire) 2021-09-13 7:27 ` Daniel Wagner 2021-09-13 7:45 ` VAUTRIN Emmanuel (Canal Plus Prestataire) [this message] 2021-09-20 7:22 ` Daniel Wagner 2021-09-20 8:15 ` VAUTRIN Emmanuel (Canal Plus Prestataire) 2021-10-18 7:26 ` Daniel Wagner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=MRZP264MB1544BB065A7FADD9BC38F69693D99@MRZP264MB1544.FRAP264.PROD.OUTLOOK.COM \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='RE: [PATCH] build: Fix compiler maybe-uninitialized warnings' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.