All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matan Azrad <matan@nvidia.com>
To: Jack Min <jackmin@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>,
	Slava Ovsiienko <viacheslavo@nvidia.com>,
	Jack Min <jackmin@nvidia.com>, Ori Kam <orika@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix redundant flow after RSS expansion
Date: Thu, 8 Apr 2021 09:23:15 +0000	[thread overview]
Message-ID: <MW2PR12MB2492AB250831769DD9F71142DF749@MW2PR12MB2492.namprd12.prod.outlook.com> (raw)
In-Reply-To: <d081a6fa197cfd508778f2ff0cc9665241a09f3e.1617111457.git.jackmin@nvidia.com>



From: Xiaoyu Min
> When RSS expand, if there is no expansion happened but completion happened
> because user only input next protocol field instead of item i.e, ether type ==
> 0x8100 instead of VLAN, an extra flow is created with missing item in order to
> filter traffic strictly.
> 
> However, after [1] and [2] the rte_flow_item_eth itself is enough to filter out
> VLAN traffic, the VLAN item is not needed.
> 
> This redundant flow will cause faiure in some scenarios on group 0 due to they
> are the same FTE.
> 
> Fixes: fc2dd8dd492f ("ethdev: fix expand RSS flows")
> Cc: stable@dpdk.org
> 
> [1]:
> commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and VLAN
> items")
> 
> [2]:
> commit 86b59a1af671 ("net/mlx5: support VLAN matching fields")
> 
> Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>

  reply	other threads:[~2021-04-08  9:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30 13:40 [dpdk-dev] [PATCH] net/mlx5: fix redundant flow after RSS expansion Xiaoyu Min
2021-04-08  9:23 ` Matan Azrad [this message]
2021-04-11  9:04 ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW2PR12MB2492AB250831769DD9F71142DF749@MW2PR12MB2492.namprd12.prod.outlook.com \
    --to=matan@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=jackmin@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=shahafs@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.