From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04706C433ED for ; Wed, 12 May 2021 05:43:50 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 6D5D1610EA for ; Wed, 12 May 2021 05:43:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6D5D1610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 712D34003F; Wed, 12 May 2021 07:43:48 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 0008B4003E for ; Wed, 12 May 2021 07:43:46 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14C5eL7h017165; Tue, 11 May 2021 22:43:45 -0700 Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam08lp2045.outbound.protection.outlook.com [104.47.74.45]) by mx0a-0016f401.pphosted.com with ESMTP id 38fw8yagjq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 May 2021 22:43:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z35C3IWfnFqbgQZRyepHmZMLAxhShS49Q05DcRjAkJcuAbhXLLueseMA36sQgseyWRRooQo8+1KkdyMWbZffCFve6XgbC9Q+to97xeFiOhD4Syqpy64LKUbFs54AXpHyGMrPdb/iw0y/MEqtdVVbiO85m5qC+RwRd7BYP2BlpDiz13IAyI6wStoHtcS/yqogeB4lqnYw60LoBinibPmDEa2OzpFiABtSysttv4PWt3RR+4UHEfbRiOH6tEonFQNab/PP+na6FAnOmvqUlt51TtSjKk/wk6yKU6mDyyzVtpeHB4AMURqDcEeW61RxZDFesEkOXOCW/BDKCAc8grdfzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uBxxn5kKXrnpRLqzdl+CcdYIoNUJr+DgP9moJnAmRrg=; b=SnGfApmnH/5bfPs210N06ohJFNA+YYRQJoKlnD+5DTpOlQiEqpzcJ2PHA6eKJvP7aFaw5QcBm4kt5QBdhgAeMtkpGb4SXHkcjlgTEwT6HP8oNtWbEuPAEI1GgqA4o9KfFqlx5FtkBetPs47x0u8rJYW3rN6CX5vG160raBAJ64O3/nK/gSPMXPk6LDpU7sCwaaVCZm+VZVMv0OnAx5AFmeLs/W/CKgbrvuSRSRgDzpYRhU9ePntK59u84Q8fxZdiUGBGhC4hohCbVVRFJHnoCe2XiZDamIjB9+USC3RB5v3VDszzT1Rf0FB0HS0h+ryjpqAKXSwuVlNAgNedEH8OGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uBxxn5kKXrnpRLqzdl+CcdYIoNUJr+DgP9moJnAmRrg=; b=lK42bDJFTqKWbVzuQdiGyhEgrGAzG41mx+rqvtPDg+oA575lUl2jxmfrnWEYWf4J7yvSBVdwkFb9h2TYu3GSNSWlL02RIjSLnSHJKpUHOF63qI3EXmEaW9sfvzbqFDdKr7AI3rseqefH2tgDoJTW7bA5bYRvyany0zM8ZIPtrvA= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by MWHPR18MB0973.namprd18.prod.outlook.com (2603:10b6:300:9f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Wed, 12 May 2021 05:43:42 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4129.025; Wed, 12 May 2021 05:43:42 +0000 From: Akhil Goyal To: Matan Azrad , "dev@dpdk.org" CC: Suanming Mou , NBU-Contact-Thomas Monjalon , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD Thread-Index: AQHXQSnFSYNEr5fXDUSAriS5cqzCearZVWyQgAF3JoCAABqFwIAAVPwAgANWiwCAAMtRAIAAAkXQ Date: Wed, 12 May 2021 05:43:42 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-2-matan@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [171.48.51.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9c5f66e3-67c8-4785-e4dd-08d91508e6ae x-ms-traffictypediagnostic: MWHPR18MB0973: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NLEUmHn7TMsus4YEAIRdyQHSy9UniwQ5PbcIlKB9A+GrvxuYLizXz+r0v3/frFqn4dr7w8gbOMQus2P1MOxyyVwAPcPsO0wHGG6fR+OQmb6tJxK5p49UnVfFvFBFTqCc0cvKhx3fU+23hK2sAr8Z2CiR0CGyZu6AQwynTNd7D8Mftr/v4UOIo7zbn9zWFfslnKpQdCCkQqaJoJf2D3auFrMLgXh2K5FlbAduDvWgWzHwdcn9wfutuM89wJCvnAhGpjYogA4dIpzmoXLwDMRqqnZqx2NNIrJYpzO93BgctybGULzN/v0Z2BX4rrti2KJsfdgyE36q++aKaNrh5vDUcHkyL0ldwDk5Lw0NU/i6sQcwmt86u8yoOyGHk8CK3bgZxc7IbSowyiIvsVHMkbxHJJe5fo145fvNzDg7WCBm501FczGqEuAYLFQOxmko+89Gzhr5kmWCHwhOwtx/gN1rBuleMEus68/Jt9rC2hf3z425uqCqsQ/QeMgeWxg7b71F+PCvehzDMTfoY5lr0jdBA53Yy5KdwmcwzMBo4oEiEir1CX8Na8uGL+C/hTeMlYyIMZaZAOuoDNDf6hUAs/ZXGSi089ztTdyfNghSGeoD4T8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(366004)(346002)(39860400002)(38100700002)(76116006)(122000001)(4326008)(2906002)(66446008)(9686003)(33656002)(55016002)(66946007)(71200400001)(64756008)(26005)(66556008)(8676002)(316002)(66476007)(186003)(5660300002)(6506007)(4744005)(83380400001)(86362001)(478600001)(7696005)(54906003)(52536014)(8936002)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?o2P3hpRfvM1WoR2GbAVvp+gbflvldk43197jr82PponB+EnKbi6Ru+5JQk9R?= =?us-ascii?Q?7OXSQ1CieWGNQ9sYJMPYbLsYOz4SF0jQtFOA8QL2R4sIyh0I31VnfFCsAUZS?= =?us-ascii?Q?e9On3iHxWSks2rvDBWGIyc38NykeOG0pEG41uGOrc+0LQRm6fywu6uxGlEtY?= =?us-ascii?Q?EPZxCjrL6JoXlvETWNyfcZotkZAEYnCY8zhtGGsSLYqrMqA5lPhTQllz06S/?= =?us-ascii?Q?SXCUaOsT1eT41GRE4rUFXlFnrHs3kekY+VU0N3sZUOkQDgfonNiX41Y8eRWk?= =?us-ascii?Q?ZjC992heLi5wkVvY2kXjumn4ahTyLTTSwh7nMJBwy0u/+n8d//OJmSBtDCM/?= =?us-ascii?Q?RpPtepbULeQWsJvz+5qACXOwVNm49FvAZhGL1+9IfQCxaI/9Hyk2mFdH98Vz?= =?us-ascii?Q?qTi/8N85lXnjzs8qXTyu0WBctsUpzWRp1E2dD+SQtn1pp5+tewlS+tQiAbGu?= =?us-ascii?Q?KP0UAP0XAQnB7PfGcHN6nOkLWHtae/x0pg2dFJNTJYBBRtj1SXhPvsNT47fu?= =?us-ascii?Q?tCQusyuxpKTJlph+VlinOn80hIFqJvSN434VJVOuVpJuNOK6ojmwW/toMeLW?= =?us-ascii?Q?sD2nY3l7+d0QYdf+yDzCjhK5Dwc9bslA0dq8PRN2Z5ChW8z4h/s1egg8LNwa?= =?us-ascii?Q?3WcG3I4ZBbHNKrpx5f2MBy99lNx51eMQkhyqOE3v7jwMYfeaoE/Bjvbf3TQo?= =?us-ascii?Q?yIdAsJlfV+NAAytZUvS+4LjgTtsv/dBtiZv6mVrSvcjLWjJNpx5//FE1nNzM?= =?us-ascii?Q?xYSbhjzNwQ2SPVuyPY8JZIyYqgdrpNw2yH+/bX1HNWgDO8uw3/bDJeBM1uak?= =?us-ascii?Q?WFmfokf6DUd3Y5Aiq23AmvWznOZgWpPgnDVA/i89nkw85NHch7d4VXB7Oo+F?= =?us-ascii?Q?YjhtW91KVMfhOwGsOZAFxEHNaygBoDs1pj56P5zNSxugvQceGR3If94TZ28M?= =?us-ascii?Q?e4UR+mvwlIzkz/MHVcSqDcMgUtcjmj9b6BX1c1uLdUIJQbCu3mPD889wXZfG?= =?us-ascii?Q?x8txJiZblFV9D1U1hH4KgJHkBy1w1y/l0lHTCXf0s96Dz9aSKWJWvUA+PjNM?= =?us-ascii?Q?0SFr0PNlL+EaY+3CUsG7jstMzKnlFXHL2a0MF1B9QEe3hxJ5G45IHCg/nzNF?= =?us-ascii?Q?HNZnkL/HorqwXqyPQTIYWsMk3zvAwnA/PMa9cJMB/dZm3+vzj3fUAh2pnYAM?= =?us-ascii?Q?EMFtGh8Z2XvUqv82pMkT1h4K6SUTJrR4YTT5Ld4dktkMA4WlFq/uHPphiu9+?= =?us-ascii?Q?dXnvPZcTILdycgLREU25qxCJcXjQ50g7/dy/YMcDdBABHFBy8BBc+PhceIpo?= =?us-ascii?Q?vxk=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c5f66e3-67c8-4785-e4dd-08d91508e6ae X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2021 05:43:42.1910 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KgYrgVOvQhrzuWacXsFRHbFojmxLjFIGnyO+7inCC4OA3T/fgf8MKyXIZqkdAGIploQlCKYNid4q1n3Zni49KQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB0973 X-Proofpoint-GUID: K_A4R836kn01b8v3WDpGZC513Qg1dpG6 X-Proofpoint-ORIG-GUID: K_A4R836kn01b8v3WDpGZC513Qg1dpG6 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-12_01:2021-05-11, 2021-05-12 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 01/15] drivers: introduce mlx5 crypto PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Akhil Goyal > > > > > > > +fmt_name =3D 'mlx5_crypto' > > > > > > > +deps +=3D ['common_mlx5', 'eal', 'cryptodev'] > > > > > > > > > > > > I don't see a reason for eal dependency. Do you really need it? > > > > > > > > > > See RTE_LOG_REGISTER. > > > > > > > > Compilation works fine even after removing this dependency. > > > > I believe it is internally managed in cryptodev. > > > > > > Yes, but it is better to add the libs we use directly. > > > > > Please remove eal so that it is consistent with other PMDs >=20 > I don't understand why you don't give a claim to explain why not to add l= ibs > the PMD accesses directly. If that is the case, why not add all the other libs as well - mbuf, mempool= , pci etc? Why only eal? >=20 > One day when other dependency will remove the direct dependency, it may > be problematic. >=20 > Because I see you strongly insist on it and this is tiny I will remove.