From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, PDS_BAD_THREAD_QP_64,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A9A0C433ED for ; Sat, 8 May 2021 12:44:43 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id EC82661466 for ; Sat, 8 May 2021 12:44:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC82661466 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC8FD40140; Sat, 8 May 2021 14:44:41 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 6B1254013F for ; Sat, 8 May 2021 14:44:40 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 148CU4XT012689; Sat, 8 May 2021 05:44:39 -0700 Received: from nam02-cy1-obe.outbound.protection.outlook.com (mail-cys01nam02lp2053.outbound.protection.outlook.com [104.47.37.53]) by mx0b-0016f401.pphosted.com with ESMTP id 38dt5rg2jj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 08 May 2021 05:44:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EkUqmf+NpNM9OU7cFKKlV4JfJozhIh4jKRIoVgy1zia4lHunI0KoTnhIPL+WnkN7+LD30cDjjDTDx3R7QV+bL5R+OMOJxcuaUVBMPpF4LkEl7zwWxrWkTlr1HDHdtVaYYQK55eL0rMj94xcS8VR4QhIbl7vuB9I1mOLfpBwQq+Cw0+TxYzHvLKvF8v5QAfesTUVNAgyIapHcEVm/KTB3x945tUqeZ3jhNr0hkDW+UemRkN1h7WHVvnWeuAdcrmMmnepYRXWAnauURR1h0FfM/w1FSx/uVteePRs1TZUh3y7bsUHfGi1eg2qHVgMUDJDB/O6UAGlk/hL7jkSjiV5euw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rE2Dq1AkcQcuGaUY0/ahsT/TpLQOFpJRHkrihFAAtFA=; b=GBCiMB8jGl2RuLDBNhzKICbKC/eZsV4m7oz0YHANTEFaaTswWbGeTSZlwmjWq/8en+MsRMANRX55B6B340jDkyfkTKSNrdh5cAxJmprQbZ84rluSiLBfuojD60zORSrDkw18BUwpvoor++7EnQMTp5T7VLjGy41c7xENXtyKXJLUMpdP4rL6m3D1NGqMtcbS0fwj+gUCf3e1+IoG8ngKv13JkM1+q0JPC9QJlOvDinqW6RTE9k6ghEY1AiM3Ea6LLF4INuKizIL+hpRjINIRQtsgcPRdwZEuaccykNmraPeuFNTCu9ZM8mMU0ZBEHqVRKxTWWqitBAiloGbiTdSQyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rE2Dq1AkcQcuGaUY0/ahsT/TpLQOFpJRHkrihFAAtFA=; b=Om+H/q+ftLtiE0xgRTg0dD2Y9fsvB8eYBHCYxcamgF8h4osKnd5lFgUpsICVn8ONn7+wsObLu6dJDTwyzmS1tisUp2/MRMpm43zkoMayyZuZQS9vSFLKa0XrUiU9lJUMgL8BNzMkgYIjdE9t2R+8jX78dC1aVuyXls0rLRW5L8c= Received: from MW2PR18MB2284.namprd18.prod.outlook.com (2603:10b6:907:10::16) by CO6PR18MB3892.namprd18.prod.outlook.com (2603:10b6:5:351::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Sat, 8 May 2021 12:44:36 +0000 Received: from MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f]) by MW2PR18MB2284.namprd18.prod.outlook.com ([fe80::3168:cb00:6607:743f%7]) with mapi id 15.20.4108.030; Sat, 8 May 2021 12:44:36 +0000 From: Akhil Goyal To: Matan Azrad , "dev@dpdk.org" CC: "suanmingm@nvidia.com" , Thomas Monjalon , Shiri Kuzin Thread-Topic: [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations Thread-Index: AQHXQSnJ4KJlusD3MUiFAPGamVq8bKrZjGyg Date: Sat, 8 May 2021 12:44:36 +0000 Message-ID: References: <20210429154712.2820159-1-matan@nvidia.com> <20210504210857.3398397-1-matan@nvidia.com> <20210504210857.3398397-4-matan@nvidia.com> In-Reply-To: <20210504210857.3398397-4-matan@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [171.48.51.1] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 626be30d-0725-44b4-0a6e-08d9121f09aa x-ms-traffictypediagnostic: CO6PR18MB3892: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 07nV3jMIfG8+ZmszeJu8oc/eAnoY7M35kkbJ7YqHsKCZwf//wvK+7ZdMNm9qC4Jrs68UBkrtwKhfIdGdKYZPIMVW4ITit0mlTxYOGhIOzvKLwK55GUus1F1x0BipSkecyzdBBfFDd94t4fYI/SHj0xBShl2aMzoq+h11YBqJfDVSms05u/gFskKGHSuMciUhz4amj3VuCBH5unkFlyF3ssQDyzzlYge+ljIdAFFjs0zyDxjtlihFgS/TuDzfaiNYGDiF4Fzv2CMctD2esAOwAu+XJp4OmZA8+FzY69ypUyWssENJ/w4N49hzxHiZ9LOl6G4+Ysyd5fvJiJqp1Ngexi7ti0tgT5xF4J2lpnrLjkptq1sdfBExiFO37ku0BvnmIKGbcbO5W2zflY9ov2D7Ldpv8OLZ/v/Y97r/QBsKNDgn14JnYzYumVbewTCWsIODmwBOmYmwcZNfjHeUVbrPK0g4YyUSXTinDaZK1VoXxR9vM583+jWJI7pLrtPa8aYgTn/r0/UtZdZNgZwtYbPr75SfaT1XCf9DiYciQmIfD1i5L4o0cf4qWcrHuX4uxVWvDuVbjqCqgeard65/9/zSZAm7jUBqS2ZzWIykNYs/064= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW2PR18MB2284.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(39850400004)(136003)(376002)(366004)(8936002)(8676002)(71200400001)(26005)(2906002)(33656002)(110136005)(54906003)(186003)(66476007)(66446008)(66556008)(478600001)(7696005)(316002)(4326008)(66946007)(6506007)(52536014)(5660300002)(4744005)(122000001)(86362001)(38100700002)(76116006)(55016002)(64756008)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?IlmgFTm7Kf5q6VRZpCJExxY0Zf+/kAj3FR57smjN8hCRWcOidrf/iG6qHoe3?= =?us-ascii?Q?9N4A2nv/txRgctlr+yhkmGmWvxFbCoULeKnmQlbtzsmkL1HDmC/pCZ2jiuem?= =?us-ascii?Q?/F9p37IXqCyKvlqincLy00IU6hMXZMXNCM67puGeRX/5kms/lJFjKuoLE6LX?= =?us-ascii?Q?+sDPyaVgf1nAbAovlLcNmUG5OxHAueDkO3YXb6HUyAYAPQzp6c4WsISC2aNa?= =?us-ascii?Q?zRP5SYmgK6jGNiWyc23UUsMo8KhMnBngXcAqpxaG2B05MO87BGKXs//LIqMd?= =?us-ascii?Q?kQYUUpASM9F6vFgukz66G65dBeDULmXiPFGaXP3/deBmyT4ph284LL/+Pweo?= =?us-ascii?Q?TgYwXG1WNICzUXDECvqXx1vdjsuJNrtOU4jxqcgWb0SrZNezZWqFDLfso/Xz?= =?us-ascii?Q?iYwf0UA9kLrj54qGeHuCbg8i9WSgrVvjWIyLLDzhekRCQ1ogoaVu8IRxCKkT?= =?us-ascii?Q?j/u4kKyGkSsOq1mUA7l8YfeyoM3sTHXzAjcW8a26GecxmWe8wKeDn9i7GW5+?= =?us-ascii?Q?mfbrfm0ZFAz6LkVWS5yxkOFT1tbkr3yT8wCRVABNVJtgrzVVtJnv7nPiB8W+?= =?us-ascii?Q?SF8Mut7kBxYee23A1l+ayvan+fpne0Yw6oDCglTqrgQ2B4IVvSMTXXmpX6Xr?= =?us-ascii?Q?tDY1uWRa23K4Ulw0JYTMurQ+oFXcEniDa7MHrLdXJhdIjRoe4bp2hCH9eyLG?= =?us-ascii?Q?roCOnMVp7qhvsU4gryVqpZ7usBxyigKAac7iTbD3it3YBsQ+Ndewwe8XJiz9?= =?us-ascii?Q?UvZTtL2xiJa+xhHZFBOIUlLIWzulj73sJ2mXxBaRJjd9KIXxrO4G0NWX1Bpq?= =?us-ascii?Q?Udn9z9p5PJz85/D/PRgawCJmsefOkFZfMGFoqqlj6q3ltmwpKduwaRgR+A9O?= =?us-ascii?Q?C+iwUEH7wwIJG25Pns5gphYvRs6rWlr+crsBoB0O/YpXUcY4bi7AGh3GkDe0?= =?us-ascii?Q?EVKg5cmYBi21PFdBZALrm59wpW7rNfjcOSa2WX4xpRu6vx+uUoB0mWIhDV/z?= =?us-ascii?Q?WXdgxPsC7Vnu5F5UFulo1C3WzHaYNJsQCv1SI5XKlgBYMQLzzW+uILWENNgt?= =?us-ascii?Q?AhyhYLvNDtFCvd4Dzgh71WP4qDWT2ZzvoWNn+Pr2jBtY4RaFzlFYq6bzDUf3?= =?us-ascii?Q?tHt/XKOH7TelCr+tJ1fUgItlizccR9DJrKtDxZf9TkTXnkqHPYqF+CJckftH?= =?us-ascii?Q?YrP43SJ35zXw9/Au3s8hSQCio2HU5uIoHR0oncqIIdAV1El+QQh7zsYVfY34?= =?us-ascii?Q?bSgdtoRACrWQhycBbW6be4QaEMCQGtdlUSBSzl924S/qM6XlY1C0l3RlQiPw?= =?us-ascii?Q?heA=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW2PR18MB2284.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 626be30d-0725-44b4-0a6e-08d9121f09aa X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2021 12:44:36.3451 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Pw7pOB3K+RjYX5u27UfBnOkzN07eYYzOpK5Kce0Ih/TrTo7C4M821dn+IrkRPrcRW6CfGy1Cwvu+9pEa9NJKrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB3892 X-Proofpoint-ORIG-GUID: hgfaaBX5nt32W4Oq32-Ya9cKxK2jWVbF X-Proofpoint-GUID: hgfaaBX5nt32W4Oq32-Ya9cKxK2jWVbF X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-08_06:2021-05-06, 2021-05-08 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v3 03/15] crypto/mlx5: support session operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > + > +static void > +mlx5_crypto_sym_session_clear(struct rte_cryptodev *dev, > + struct rte_cryptodev_sym_session *sess) > +{ > + struct mlx5_crypto_priv *priv =3D dev->data->dev_private; > + struct mlx5_crypto_session *sess_private_data =3D > + get_sym_session_private_data(sess, dev->driver_id); > + > + if (unlikely(sess_private_data =3D=3D NULL)) { > + DRV_LOG(ERR, "Failed to get session %p private data.", > + sess_private_data); > + return; > + } > + mlx5_crypto_dek_destroy(priv, sess_private_data->dek); > + DRV_LOG(DEBUG, "Session %p was cleared.", sess_private_data); > +} Memory leakage, mempool is not freed. IMO, this driver is not properly tested with the unit test app. Please add a note in the documentation that it is tested with autotest.