RE: [net-next v3 13/15] iecm: Add ethtool

["Brady, Alan" <alan.brady@intel.com>]

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Friday, June 26, 2020 11:57 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Cc: davem@davemloft.net; Michael, Alice <alice.michael@intel.com>;
> netdev@vger.kernel.org; nhorman@redhat.com; sassmann@redhat.com;
> Brady, Alan <alan.brady@intel.com>; Burra, Phani R <phani.r.burra@intel.com>;
> Hay, Joshua A <joshua.a.hay@intel.com>; Chittim, Madhu
> <madhu.chittim@intel.com>; Linga, Pavan Kumar
> <pavan.kumar.linga@intel.com>; Skidmore, Donald C
> <donald.c.skidmore@intel.com>; Brandeburg, Jesse
> <jesse.brandeburg@intel.com>; Samudrala, Sridhar
> <sridhar.samudrala@intel.com>
> Subject: Re: [net-next v3 13/15] iecm: Add ethtool
> 
> On Thu, 25 Jun 2020 19:07:35 -0700 Jeff Kirsher wrote:
> > @@ -978,7 +1059,20 @@ static int iecm_open(struct net_device *netdev)
> >   */
> >  static int iecm_change_mtu(struct net_device *netdev, int new_mtu)  {
> > -	/* stub */
> > +	struct iecm_vport *vport =  iecm_netdev_to_vport(netdev);
> > +
> > +	if (new_mtu < netdev->min_mtu) {
> > +		netdev_err(netdev, "new MTU invalid. min_mtu is %d\n",
> > +			   netdev->min_mtu);
> > +		return -EINVAL;
> > +	} else if (new_mtu > netdev->max_mtu) {
> > +		netdev_err(netdev, "new MTU invalid. max_mtu is %d\n",
> > +			   netdev->max_mtu);
> > +		return -EINVAL;
> > +	}
> 
> Core already checks this. Please remove all checks which core already does.
> 
> > +	netdev->mtu = new_mtu;
> > +
> > +	return iecm_initiate_soft_reset(vport, __IECM_SR_MTU_CHANGE);
> >  }

Will fix, thanks

Alan