All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kammela, Gayatri" <gayatri.kammela@intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Platform Driver <platform-driver-x86@vger.kernel.org>,
	Mark Gross <mgross@linux.intel.com>,
	Hans de Goede <hdegoede@redhat.com>,
	"Rajneesh Bhardwaj" <irenic.rajneesh@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	You-Sheng Yang <vicamo.yang@canonical.com>,
	"Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
	"Box, David E" <david.e.box@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"Mashiah, Tamar" <tamar.mashiah@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rajat Jain <rajatja@google.com>
Subject: RE: [PATCH v2 1/5] platform/x86/intel: intel_pmc_core: Move intel_pmc_core* files to pmc subfolder
Date: Fri, 9 Jul 2021 17:39:42 +0000	[thread overview]
Message-ID: <MW3PR11MB4523D6E8BFEA0D4626E390ADF2189@MW3PR11MB4523.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAHp75VdFpJBEWBJMJexK3muvWt+EEqMMyVtxMvm9sSXhkysaww@mail.gmail.com>

> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Thursday, July 8, 2021 12:56 AM
> To: Kammela, Gayatri <gayatri.kammela@intel.com>
> Cc: Platform Driver <platform-driver-x86@vger.kernel.org>; Mark Gross
> <mgross@linux.intel.com>; Hans de Goede <hdegoede@redhat.com>;
> Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>; Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>; You-Sheng Yang
> <vicamo.yang@canonical.com>; Pandruvada, Srinivas
> <srinivas.pandruvada@intel.com>; Box, David E <david.e.box@intel.com>;
> Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Mashiah, Tamar
> <tamar.mashiah@intel.com>; Greg Kroah-Hartman
> <gregkh@linuxfoundation.org>; Rajat Jain <rajatja@google.com>
> Subject: Re: [PATCH v2 1/5] platform/x86/intel: intel_pmc_core: Move
> intel_pmc_core* files to pmc subfolder
> 
> On Thu, Jul 8, 2021 at 5:10 AM Gayatri Kammela
> <gayatri.kammela@intel.com> wrote:
> >
> > As part of collecting Intel x86 specific drivers in their own folder,
> > move intel_pmc_core* files to its own subfolder there.
> 
> I'm fine with this, it is also possible I think to drop intel_pmc_ prefix from the
> file names (core.c, core.h, pltdrv.c). In any case it may be done later on.
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Thanks Andy! I will send v3 without intel_pmc_ prefix from the file names
> 
> > Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
> > Cc: David Box <david.e.box@intel.com>
> > Cc: You-Sheng Yang <vicamo.yang@canonical.com>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Signed-off-by: Gayatri Kammela <gayatri.kammela@intel.com>
> > ---
> >  drivers/platform/x86/Kconfig                  | 21 ------------------
> >  drivers/platform/x86/Makefile                 |  1 -
> >  drivers/platform/x86/intel/Kconfig            |  1 +
> >  drivers/platform/x86/intel/Makefile           |  1 +
> >  drivers/platform/x86/intel/pmc/Kconfig        | 22 +++++++++++++++++++
> >  drivers/platform/x86/intel/pmc/Makefile       |  5 +++++
> >  .../x86/{ => intel/pmc}/intel_pmc_core.c      |  0
> >  .../x86/{ => intel/pmc}/intel_pmc_core.h      |  0
> >  .../{ => intel/pmc}/intel_pmc_core_pltdrv.c   |  0
> >  9 files changed, 29 insertions(+), 22 deletions(-)  create mode
> > 100644 drivers/platform/x86/intel/pmc/Kconfig
> >  create mode 100644 drivers/platform/x86/intel/pmc/Makefile
> >  rename drivers/platform/x86/{ => intel/pmc}/intel_pmc_core.c (100%)
> > rename drivers/platform/x86/{ => intel/pmc}/intel_pmc_core.h (100%)
> > rename drivers/platform/x86/{ => intel/pmc}/intel_pmc_core_pltdrv.c
> > (100%)
> >
> > diff --git a/drivers/platform/x86/Kconfig
> > b/drivers/platform/x86/Kconfig index 7d385c3b2239..cae72922f448
> 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1184,27 +1184,6 @@ config INTEL_MRFLD_PWRBTN
> >           To compile this driver as a module, choose M here: the module
> >           will be called intel_mrfld_pwrbtn.
> >
> > -config INTEL_PMC_CORE
> > -       tristate "Intel PMC Core driver"
> > -       depends on PCI
> > -       depends on ACPI
> > -       help
> > -         The Intel Platform Controller Hub for Intel Core SoCs provides access
> > -         to Power Management Controller registers via various interfaces. This
> > -         driver can utilize debugging capabilities and supported features as
> > -         exposed by the Power Management Controller. It also may perform
> some
> > -         tasks in the PMC in order to enable transition into the SLPS0 state.
> > -         It should be selected on all Intel platforms supported by the driver.
> > -
> > -         Supported features:
> > -               - SLP_S0_RESIDENCY counter
> > -               - PCH IP Power Gating status
> > -               - LTR Ignore / LTR Show
> > -               - MPHY/PLL gating status (Sunrisepoint PCH only)
> > -               - SLPS0 Debug registers (Cannonlake/Icelake PCH)
> > -               - Low Power Mode registers (Tigerlake and beyond)
> > -               - PMC quirks as needed to enable SLPS0/S0ix
> > -
> >  config INTEL_PMT_CLASS
> >         tristate
> >         help
> > diff --git a/drivers/platform/x86/Makefile
> > b/drivers/platform/x86/Makefile index 7ee369aab10d..43d36f8c36f1
> > 100644
> > --- a/drivers/platform/x86/Makefile
> > +++ b/drivers/platform/x86/Makefile
> > @@ -128,7 +128,6 @@ obj-$(CONFIG_INTEL_UNCORE_FREQ_CONTROL)
> += intel-uncore-frequency.o
> >  obj-$(CONFIG_INTEL_BXTWC_PMIC_TMU)     += intel_bxtwc_tmu.o
> >  obj-$(CONFIG_INTEL_CHTDC_TI_PWRBTN)    += intel_chtdc_ti_pwrbtn.o
> >  obj-$(CONFIG_INTEL_MRFLD_PWRBTN)       += intel_mrfld_pwrbtn.o
> > -obj-$(CONFIG_INTEL_PMC_CORE)           += intel_pmc_core.o
> intel_pmc_core_pltdrv.o
> >  obj-$(CONFIG_INTEL_PMT_CLASS)          += intel_pmt_class.o
> >  obj-$(CONFIG_INTEL_PMT_TELEMETRY)      += intel_pmt_telemetry.o
> >  obj-$(CONFIG_INTEL_PMT_CRASHLOG)       += intel_pmt_crashlog.o
> > diff --git a/drivers/platform/x86/intel/Kconfig
> > b/drivers/platform/x86/intel/Kconfig
> > index f2eef337eb98..8ca021785f67 100644
> > --- a/drivers/platform/x86/intel/Kconfig
> > +++ b/drivers/platform/x86/intel/Kconfig
> > @@ -18,5 +18,6 @@ if X86_PLATFORM_DRIVERS_INTEL
> >
> >  source "drivers/platform/x86/intel/int33fe/Kconfig"
> >  source "drivers/platform/x86/intel/int3472/Kconfig"
> > +source "drivers/platform/x86/intel/pmc/Kconfig"
> >
> >  endif # X86_PLATFORM_DRIVERS_INTEL
> > diff --git a/drivers/platform/x86/intel/Makefile
> > b/drivers/platform/x86/intel/Makefile
> > index 0653055942d5..49962f4dfdec 100644
> > --- a/drivers/platform/x86/intel/Makefile
> > +++ b/drivers/platform/x86/intel/Makefile
> > @@ -6,3 +6,4 @@
> >
> >  obj-$(CONFIG_INTEL_CHT_INT33FE)                += int33fe/
> >  obj-$(CONFIG_INTEL_SKL_INT3472)                += int3472/
> > +obj-$(CONFIG_INTEL_PMC_CORE)           += pmc/
> > diff --git a/drivers/platform/x86/intel/pmc/Kconfig
> > b/drivers/platform/x86/intel/pmc/Kconfig
> > new file mode 100644
> > index 000000000000..b4c955a35674
> > --- /dev/null
> > +++ b/drivers/platform/x86/intel/pmc/Kconfig
> > @@ -0,0 +1,22 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +
> > +config INTEL_PMC_CORE
> > +       tristate "Intel PMC Core driver"
> > +       depends on PCI
> > +       depends on ACPI
> > +       help
> > +         The Intel Platform Controller Hub for Intel Core SoCs provides access
> > +         to Power Management Controller registers via various interfaces.
> This
> > +         driver can utilize debugging capabilities and supported features as
> > +         exposed by the Power Management Controller. It also may perform
> some
> > +         tasks in the PMC in order to enable transition into the SLPS0 state.
> > +         It should be selected on all Intel platforms supported by the driver.
> > +
> > +         Supported features:
> > +               - SLP_S0_RESIDENCY counter
> > +               - PCH IP Power Gating status
> > +               - LTR Ignore / LTR Show
> > +               - MPHY/PLL gating status (Sunrisepoint PCH only)
> > +               - SLPS0 Debug registers (Cannonlake/Icelake PCH)
> > +               - Low Power Mode registers (Tigerlake and beyond)
> > +               - PMC quirks as needed to enable SLPS0/S0ix
> > diff --git a/drivers/platform/x86/intel/pmc/Makefile
> > b/drivers/platform/x86/intel/pmc/Makefile
> > new file mode 100644
> > index 000000000000..633a7598d6d6
> > --- /dev/null
> > +++ b/drivers/platform/x86/intel/pmc/Makefile
> > @@ -0,0 +1,5 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +#
> > +
> > +obj-$(CONFIG_INTEL_PMC_CORE)   += intel_pmc_core.o
> > +obj-$(CONFIG_INTEL_PMC_CORE)   += intel_pmc_core_pltdrv.o
> > diff --git a/drivers/platform/x86/intel_pmc_core.c
> > b/drivers/platform/x86/intel/pmc/intel_pmc_core.c
> > similarity index 100%
> > rename from drivers/platform/x86/intel_pmc_core.c
> > rename to drivers/platform/x86/intel/pmc/intel_pmc_core.c
> > diff --git a/drivers/platform/x86/intel_pmc_core.h
> > b/drivers/platform/x86/intel/pmc/intel_pmc_core.h
> > similarity index 100%
> > rename from drivers/platform/x86/intel_pmc_core.h
> > rename to drivers/platform/x86/intel/pmc/intel_pmc_core.h
> > diff --git a/drivers/platform/x86/intel_pmc_core_pltdrv.c
> > b/drivers/platform/x86/intel/pmc/intel_pmc_core_pltdrv.c
> > similarity index 100%
> > rename from drivers/platform/x86/intel_pmc_core_pltdrv.c
> > rename to drivers/platform/x86/intel/pmc/intel_pmc_core_pltdrv.c
> > --
> > 2.25.1
> >
> 
> 
> --
> With Best Regards,
> Andy Shevchenko

  reply	other threads:[~2021-07-09 17:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08  2:07 [PATCH v2 0/5] Add Alder Lake PCH-S support to PMC core driver Gayatri Kammela
2021-07-08  2:07 ` [PATCH v2 1/5] platform/x86/intel: intel_pmc_core: Move intel_pmc_core* files to pmc subfolder Gayatri Kammela
2021-07-08  7:56   ` Andy Shevchenko
2021-07-09 17:39     ` Kammela, Gayatri [this message]
2021-07-08  2:07 ` [PATCH v2 2/5] platform/x86/intel: intel_pmc_core: Add Alderlake support to pmc_core driver Gayatri Kammela
2021-07-08  2:07 ` [PATCH v2 3/5] platform/x86/intel: intel_pmc_core: Add Latency Tolerance Reporting (LTR) support to Alder Lake Gayatri Kammela
2021-07-08  2:07 ` [PATCH v2 4/5] platform/x86/intel: intel_pmc_core: Add Alder Lake low power mode support for pmc_core Gayatri Kammela
2021-07-08  2:07 ` [PATCH v2 5/5] platform/x86/intel: intel_pmc_core: Add GBE Package C10 fix for Alder Lake PCH Gayatri Kammela
2021-07-08 17:32 ` [PATCH v2 0/5] Add Alder Lake PCH-S support to PMC core driver Rajneesh Bhardwaj
2021-07-09 17:40   ` Kammela, Gayatri
2021-07-09 18:30     ` Limonciello, Mario
2021-07-09 23:01       ` Kammela, Gayatri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW3PR11MB4523D6E8BFEA0D4626E390ADF2189@MW3PR11MB4523.namprd11.prod.outlook.com \
    --to=gayatri.kammela@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=david.e.box@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=irenic.rajneesh@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgross@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rajatja@google.com \
    --cc=srinivas.pandruvada@intel.com \
    --cc=tamar.mashiah@intel.com \
    --cc=vicamo.yang@canonical.com \
    --subject='RE: [PATCH v2 1/5] platform/x86/intel: intel_pmc_core: Move intel_pmc_core* files to pmc subfolder' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.