From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA1FAC433FE for ; Wed, 19 Oct 2022 23:21:52 +0000 (UTC) Received: from localhost ([::1]:52984 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1olINj-0008RN-95 for qemu-devel@archiver.kernel.org; Wed, 19 Oct 2022 19:21:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olIJn-0007Pp-7C for qemu-devel@nongnu.org; Wed, 19 Oct 2022 19:17:47 -0400 Received: from mail-bn8nam11on20601.outbound.protection.outlook.com ([2a01:111:f400:7eae::601]:56896 helo=NAM11-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olIJc-0003Yb-Vp for qemu-devel@nongnu.org; Wed, 19 Oct 2022 19:17:41 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LBxDirxmDG4gKiq0WWvE3/4tM7PDw7emonIHCjGHPwXy7uIvq4nTd2bmMhKHxAndiBwO6QXGLrRcmEPDYyFj13AWT/A5kLOoMglmx+iyF0pwwljbN4B4nJ2YpqgJrn9pKh6F85+G9XECZgDkxB+K+fA36t7RGsi1MKzDS4Hspw10krQUNNTE1pY0PC5P0k+talFI+TzuD68KTEPtC3xIWVMaleduM2QChEVHAE4o45xMES76tR21EEHhyXa7ouzaitxEPQq4wV+MCzLVesbccUSX4BSHpn02OCdko9a1uJZDZL3j1KulIPjwmlZjJWLNS1WlbfDMeQAGX5ErVm/Tng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cge5Yb2CzSD5Bu0WVHIFKjdDadxJS6eZRxLuDht1xKU=; b=iJqACC5pZUEgL3+sngHYNKvoUL5B0OZqbQdMiggKbWyq045yKZJ7kYYO1GUvjVFFhbY+58z1HzyzMD5q/M2wBkhVJZaMEud8m0SXXxf5dKBbAgVc/ZnMS4uv4AQvBQPBpF72zwrxgjnmy4D4j25AfyJyvIFF/54NsiI+WbVi7HocJe7pKDpv35pLZs1/ApLitpuVQ3q3u0XFTIHrATziyAmRkGTq29ktHMbSumXA29uIy+xARiAVOXnMrRNwQuPsWQbuVY6P3ETzxlYHsrUoGjKDIKDScg59dJhb0xAdb3Q5VDEdoz+0xZyg6A1OK6fQeR30cBLrkFjKXNLohGetmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cge5Yb2CzSD5Bu0WVHIFKjdDadxJS6eZRxLuDht1xKU=; b=DvDJfnkSMpqFxIzM9EZnjkQxW7H615G5tIIvoBY/cekTC53YWSYtHsEX9hawxadJSu4+GRuQ1HSGhsfJeJG8Pyv3zeMCRShd5k0mP9ooK39XmUMads/1x5IiVwWGboMmHEO9lsVGGunf2DcJTniA61rbwhcOZDHSIKBcki7OF9E= Received: from MW3PR12MB4409.namprd12.prod.outlook.com (2603:10b6:303:2d::23) by BY5PR12MB4226.namprd12.prod.outlook.com (2603:10b6:a03:203::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Wed, 19 Oct 2022 23:12:30 +0000 Received: from MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::45b:5f00:6991:c7e]) by MW3PR12MB4409.namprd12.prod.outlook.com ([fe80::45b:5f00:6991:c7e%3]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 23:12:30 +0000 From: "Garhwal, Vikram" To: Paul Durrant , "qemu-devel@nongnu.org" CC: "Stabellini, Stefano" , Stefano Stabellini , Anthony Perard , "Michael S. Tsirkin" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "open list:X86 Xen CPUs" Subject: Re: [PATCH v1 06/12] xen-hvm: move common functions to hw/xen/xen-hvm-common.c Thread-Topic: [PATCH v1 06/12] xen-hvm: move common functions to hw/xen/xen-hvm-common.c Thread-Index: AQHY4FQ0tVypMawM1ke4uV2W+2m2Q64V66+AgAB0FBU= Date: Wed, 19 Oct 2022 23:12:30 +0000 Message-ID: References: <20221015050750.4185-1-vikram.garhwal@amd.com> <20221015050750.4185-7-vikram.garhwal@amd.com> <7b8e645c-90c7-a4ff-4405-51df6df2e508@xen.org> In-Reply-To: <7b8e645c-90c7-a4ff-4405-51df6df2e508@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW3PR12MB4409:EE_|BY5PR12MB4226:EE_ x-ms-office365-filtering-correlation-id: 23df9e2d-1ba9-4906-e536-08dab2276581 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pN5e24PcLSQ1cCvv38jyTr9A+zOgTE06H8eTvo7xUPz6Eb2U6TPH7glts8dQihw6dh411TJdErO9WwN62n38liv6zcLgHVBNVownh9opqEstGywg939mNYIxYMSQEK5YQN6dpTJySZJzYvWfyunS2R9M5rzPX6sz6lUzB9dPqJWjJ5BXVSO7uSxH0gF2shfLFFAV1S20OY4OdAo7ivlD4vUxYJYZp2SQHfy1sOfKgX/a/06GsaBQWeEmvKkXzat9liZiR+vNx/8EVoJeC86Ba63XPuaW4kTEU9RyqXyeg7cnppg02MdT+7w6OWbD2qdTZSC5Ddr2OKWznYf3WXAHEWopNN60FTykkEzToKAuPTfaI2iuE9zEWKlXSfjcjadGivck7tmC3GejRCS0pAIdI1ohWKIfA7wMMV14+WCLy5DocBPTuk9o9ZIm/euRmQj+3yp2ofaK81CELyjuPcDFtk/j0UvdXbXckQTlHcjMlAT9xGlvErJH8i27l0pAxkyrJ7krKdTbKcL5pPWuhPN34sGlXXjXrz2/T+Vqa/Sx/sDasJel4DvTqy7ySeEHzNSLgbO3pE3QtXjlYtoDxMzHnQM4ekh4W+K63Kj3WBa0hbhTIC37kCth9Nj5RRyBTmigQCj2xSOFEQy9pRqIoplAtALWP9x5wsI0w/pQEpUOPFPH8AMISRUNuY1HnNIzjWLb3rT6dnKT/MiITEel7VdFcrbbYAgRYTDkZFVBZXT/01XB84EXiO6J9x2++g+lUkTHCb0JTU4hrNV+1vKpGbGfwA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW3PR12MB4409.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(366004)(376002)(39860400002)(396003)(346002)(451199015)(41300700001)(186003)(26005)(478600001)(64756008)(38070700005)(86362001)(2906002)(6506007)(53546011)(8936002)(33656002)(52536014)(9686003)(5660300002)(4326008)(7416002)(54906003)(38100700002)(7696005)(91956017)(110136005)(122000001)(316002)(76116006)(55016003)(71200400001)(8676002)(66446008)(66556008)(66476007)(83380400001)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7+NCEbcC+tFqf3LmBoXY8ba0iAf7md7PnaQ5vbJxfvT/UWwCICC+mEEGnC29?= =?us-ascii?Q?yV7HyH0oB5VOuXxApqOyC30wAuEMz2xnNWrPk8aAYjBJ/9wH7pohDwtyZ9Eq?= =?us-ascii?Q?n1c5IqQYPCBGQOFqxgAtJldGQR2MfYd+cgIbD5J2VYBxYVC+jYDwDJMiowhB?= =?us-ascii?Q?gaxMz7RLvawNbNikc1Q6F3h5aFR73g4xavl4cnLCnoATeQjQHTOvFg0O/Ug/?= =?us-ascii?Q?Wr+/3Y6s7RIj9Rcvd3oAK8vIEu9YTIxDxtZfpnoAT/jbySYO7OZtUVasZo4N?= =?us-ascii?Q?GNbM83UAeY0u2wyfl0UDpHY7pBTxXxxa3RxbkEX/lsKzQYMicVqoIK5ikccB?= =?us-ascii?Q?w8Lpe0/zeEoiHiE/3X478njUBP1b6q/DZeaqr6PztQ00rTDUQCRLTn+WSOkW?= =?us-ascii?Q?32wxTchWCDCI09KfdUEIvC+1Psm8qgm34l/I2OGKqqgHIKjH9aGJ+/l90QUA?= =?us-ascii?Q?1JNJpZZLqbi17fyZ3u9kTt4xAPajXTiMSsxFhQTkrk8spvtztTO5WEPp9oqU?= =?us-ascii?Q?dfY0X/vobj8QuKHqnU8JUg32wh9Qgy+WPXWJYBwlh+DmyeTvUHwmjn73EDUA?= =?us-ascii?Q?g6vlvK2tI/fFzUAuufC/dC/5gLnREThm1YMXSQu8H8PkQP9Q2ndhEiQfw5ZC?= =?us-ascii?Q?uRiODjlFPHwUWTFFNm/oNTH752qin2y8Agb1mUCPB8SWHwiCDWEfB3Qsr/Sg?= =?us-ascii?Q?gzne0gO90kmjKzGVzOX4SbCg/yDu+cYdNHxAX7RdcI/CwWRqWhIEBNzIU6J7?= =?us-ascii?Q?fVLrBW6EDPznfkR0JFbrN5h0yHBrafRB1z8ORAClvmGFicMlQJ6EyPaxkXDh?= =?us-ascii?Q?UUmtoTWbCdyYNEUBIGjQxUvAx8L9jPzuCgCAlGfHq71UdOrNWM0S2HtTOoyt?= =?us-ascii?Q?U9F3kS/yAVTXECHI5pwOiL0spq2+/Pfsql77z7lIGVVAJNiEgwGq8WXGr+bC?= =?us-ascii?Q?U7zocUBqRO2bpuy1j4y7GoDMMlQ517Px0C7DAu1RkCMPlIwE+8JFn7Tm/JKV?= =?us-ascii?Q?5m4NzDcHy8EaadsevzXJle4kUUZuBAIO38tyvYYLEMaOco6HYuqijA7m0N4E?= =?us-ascii?Q?qgCGQpkVKbFThjxq8EfJxFouIWbAfStjgN/lJiY66g1sc0nj6H9SwPpw9GGA?= =?us-ascii?Q?QLij892ronN+R5pQ0Jne+BlPJUAp/bOZywqNw3wLk0QXmlLIKQH/ZEe8AZu2?= =?us-ascii?Q?HqlrhH4IQUv9npY8FZZAnr/wXxEwY4ZQESwCsZL2D9Z0vcN64+Lxy7No3DnR?= =?us-ascii?Q?upXIP9g+6Sso7hkPvBdrNP27cwePAWicQxzRCnoxTG838tQiNuZPVXTDUDoi?= =?us-ascii?Q?UPDLKtaZICAMZa9BQ8xJXg9LndeYI+nrHQQcOZiJEd+9CoeCIGGRYebEdPah?= =?us-ascii?Q?q9jgvX4X3NVWe2UDHStilfSUjG4WUtHhZLXVGYCUMU6ihHvqT5NUhVqWDsav?= =?us-ascii?Q?SCb4fxHpLt7ovoEYE2EdKk8A9Hc3MMhP8Elsx6WOszMCbwDzRvpdTLAkWJiq?= =?us-ascii?Q?ov3mYNXTurlGl3mpf6foibGS4nxbJfKbYVFLIgnwSDoSv1liTH7az27vFFTc?= =?us-ascii?Q?PNCne5Z0UKT7ZS5Zkp4K051BqTAd2J7hVr/xWtoZustkqBIwR2I6ADUoa7hp?= =?us-ascii?Q?Ng=3D=3D?= Content-Type: multipart/alternative; boundary="_000_MW3PR12MB4409CDD81742B163D0DD11769F2B9MW3PR12MB4409namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4409.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23df9e2d-1ba9-4906-e536-08dab2276581 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2022 23:12:30.2354 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8wLlyxRIG/7emrOSKcnd6OOAgQ79Ob1EdVKjAQVkEie357t2PX0klx7q76kfoWpfXvihaukOvP6E4vcSWVm1Hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4226 Received-SPF: softfail client-ip=2a01:111:f400:7eae::601; envelope-from=vikram.garhwal@amd.com; helo=NAM11-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --_000_MW3PR12MB4409CDD81742B163D0DD11769F2B9MW3PR12MB4409namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Paul & Julien for reviewing. I will update this in v2. Regards, Vikram From: Paul Durrant Date: Wednesday, October 19, 2022 at 9:16 AM To: Garhwal, Vikram , qemu-devel@nongnu.org Cc: Stabellini, Stefano , Stefano Stabellini , Anthony Perard , Michael= S. Tsirkin , Marcel Apfelbaum = , Paolo Bonzini , Richard Henderson , Eduardo Habkost , open list:X86 Xen CPUs= Subject: Re: [PATCH v1 06/12] xen-hvm: move common functions to hw/xen/xen-= hvm-common.c On 15/10/2022 06:07, Vikram Garhwal wrote: [snip] > + qemu_add_vm_change_state_handler(xen_hvm_change_state_handler, state= ); > + > + state->memory_listener =3D xen_memory_listener; > + memory_listener_register(&state->memory_listener, &address_space_mem= ory); > + > + state->io_listener =3D xen_io_listener; > + memory_listener_register(&state->io_listener, &address_space_io); > + > + state->device_listener =3D xen_device_listener; > + QLIST_INIT(&state->dev_list); > + device_listener_register(&state->device_listener); > + As Julien said, these do not belong here. These are the (current and legacy) PV backend setup functions; they most certainly have nothing to do with device emulation. Paul --_000_MW3PR12MB4409CDD81742B163D0DD11769F2B9MW3PR12MB4409namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Thanks Paul & J= ulien for reviewing. I will update this in v2.

 

Regards,=

Vikram

 

From: Paul Durrant <xadimgnik@gmail.com>=
Date: Wednesday, October 19, 2022 at 9:16 AM
To: Garhwal, Vikram <vikram.garhwal@amd.com>, qemu-devel@nongn= u.org <qemu-devel@nongnu.org>
Cc: Stabellini, Stefano <stefano.stabellini@amd.com>, Stefano = Stabellini <sstabellini@kernel.org>, Anthony Perard <anthony.perar= d@citrix.com>, Michael S. Tsirkin <mst@redhat.com>, Marcel Apfelba= um <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.co= m>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost &l= t;eduardo@habkost.net>, open list:X86 Xen CPUs <xen-devel@lists.xenpr= oject.org>
Subject: Re: [PATCH v1 06/12] xen-hvm: move common functions to hw/x= en/xen-hvm-common.c

On 15/10/2022 06:07, Vikram Garhwal wrote:=
[snip]
> +    qemu_add_vm_change_state_handler(xen_hvm_change_st= ate_handler, state);
> +
> +    state->memory_listener =3D xen_memory_listener;=
> +    memory_listener_register(&state->memory_lis= tener, &address_space_memory);
> +
> +    state->io_listener =3D xen_io_listener;
> +    memory_listener_register(&state->io_listene= r, &address_space_io);
> +
> +    state->device_listener =3D xen_device_listener;=
> +    QLIST_INIT(&state->dev_list);
> +    device_listener_register(&state->device_lis= tener);
> +

As Julien said, these do not belong here. These are the (current and
legacy) PV backend setup functions; they most certainly have nothing to do with device emulation.

   Paul

--_000_MW3PR12MB4409CDD81742B163D0DD11769F2B9MW3PR12MB4409namp_--