From: "Xiao, Jack" <Jack.Xiao@amd.com>
To: "Zhang, Yifan" <Yifan1.Zhang@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>
Subject: Re: [PATCH] drm/amdgpu: remove redundant enable_mes/enable_mes_kiq setting
Date: Tue, 14 Jun 2022 02:39:17 +0000 [thread overview]
Message-ID: <MW3PR12MB44583B29E6733DE47EC41B71EFAA9@MW3PR12MB4458.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20220612043143.2755859-1-yifan1.zhang@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1670 bytes --]
[AMD Official Use Only - General]
Reviewed-by: Jack Xiao <Jack.Xiao@amd.com>
Regards,
Jack
________________________________
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Yifan Zhang <yifan1.zhang@amd.com>
Sent: Sunday, 12 June 2022 12:31
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Zhang, Yifan <Yifan1.Zhang@amd.com>
Subject: [PATCH] drm/amdgpu: remove redundant enable_mes/enable_mes_kiq setting
enable_mes and enable_mes_kiq are set in both device init and
MES IP init. Leave the ones in MES IP init, since it is
a more accurate way to judge from GC IP version.
Signed-off-by: Yifan Zhang <yifan1.zhang@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 68a53528089f..2b92281dd0c1 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -3614,14 +3614,6 @@ int amdgpu_device_init(struct amdgpu_device *adev,
if (amdgpu_mcbp)
DRM_INFO("MCBP is enabled\n");
- if (adev->asic_type >= CHIP_NAVI10) {
- if (amdgpu_mes || amdgpu_mes_kiq)
- adev->enable_mes = true;
-
- if (amdgpu_mes_kiq)
- adev->enable_mes_kiq = true;
- }
-
/*
* Reset domain needs to be present early, before XGMI hive discovered
* (if any) and intitialized to use reset sem and in_gpu reset flag
--
2.35.1
[-- Attachment #2: Type: text/html, Size: 3831 bytes --]
prev parent reply other threads:[~2022-06-14 2:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-12 4:31 [PATCH] drm/amdgpu: remove redundant enable_mes/enable_mes_kiq setting Yifan Zhang
2022-06-13 13:23 ` Deucher, Alexander
2022-06-14 2:39 ` Xiao, Jack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW3PR12MB44583B29E6733DE47EC41B71EFAA9@MW3PR12MB4458.namprd12.prod.outlook.com \
--to=jack.xiao@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Yifan1.Zhang@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.