All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sankeerth Billakanti (QUIC)" <quic_sbillaka@quicinc.com>
To: Douglas Anderson <dianders@chromium.org>,
	"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
	Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	"dmitry.baryshkov@linaro.org" <dmitry.baryshkov@linaro.org>,
	Rob Clark <robdclark@chromium.org>
Cc: "Abhinav Kumar (QUIC)" <quic_abhinavk@quicinc.com>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	Stephen Boyd <swboyd@chromium.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"freedreno@lists.freedesktop.org"
	<freedreno@lists.freedesktop.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	"Sankeerth Billakanti (QUIC)" <quic_sbillaka@quicinc.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"Kalyan Thota (QUIC)" <quic_kalyant@quicinc.com>,
	"Kuogee Hsieh (QUIC)" <quic_khsieh@quicinc.com>,
	Andy Gross <agross@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy
Date: Thu, 5 May 2022 18:47:43 +0000	[thread overview]
Message-ID: <MW4PR02MB7186F7F6D6D174B03FDF32CEE1C29@MW4PR02MB7186.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20220425140619.2.Iae013f0ff4599294189f3a6e91376fad137bbabf@changeid>

>We're supposed to list the supplies in the dt bindings but there are none in
>the eDP PHY bindings.
>
>Looking at the driver in Linux, I can see that there seem to be two relevant
>supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings.
>
>NOTE: from looking at the Qualcomm datasheet for sc7280, it's not
>immediately clear how to figure out how to fill in these supplies. The only two
>eDP related supplies are simply described as "power for eDP 0.9V circuits" and
>"power for eDP 1.2V circuits". From guessing and from comparing how a
>similar PHY is hooked up on other similar Qualcomm boards, I'll make the
>educated guess that the 1.2V supply goes to "vdda-phy" and the 0.9V supply
>goes to "vdda-pll" and I'll use that in the example here.
>
>Signed-off-by: Douglas Anderson <dianders@chromium.org>
>---
>
> Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
>b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
>index a5850ff529f8..cf9e9b8011cb 100644
>--- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
>+++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
>@@ -41,6 +41,9 @@ properties:
>   "#phy-cells":
>     const: 0
>
>+  vdda-phy-supply: true
>+  vdda-pll-supply: true
>+
> required:
>   - compatible
>   - reg
>@@ -65,5 +68,8 @@ examples:
>
>       #clock-cells = <1>;
>       #phy-cells = <0>;
>+
>+      vdda-phy-supply = <&vdd_a_edp_0_1p2>;
>+      vdda-pll-supply = <&vdd_a_edp_0_0p9>;
>     };
> ...
>--
>2.36.0.rc2.479.g8af0fa9b8e-goog

Reviewed-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>

WARNING: multiple messages have this Message-ID (diff)
From: "Sankeerth Billakanti (QUIC)" <quic_sbillaka@quicinc.com>
To: Douglas Anderson <dianders@chromium.org>,
	"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
	Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	"dmitry.baryshkov@linaro.org" <dmitry.baryshkov@linaro.org>,
	Rob Clark <robdclark@chromium.org>
Cc: "Kalyan Thota \(QUIC\)" <quic_kalyant@quicinc.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Sankeerth Billakanti \(QUIC\)" <quic_sbillaka@quicinc.com>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"Kuogee Hsieh \(QUIC\)" <quic_khsieh@quicinc.com>,
	"Abhinav Kumar \(QUIC\)" <quic_abhinavk@quicinc.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Andy Gross <agross@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	Stephen Boyd <swboyd@chromium.org>,
	"freedreno@lists.freedesktop.org"
	<freedreno@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy
Date: Thu, 5 May 2022 18:47:43 +0000	[thread overview]
Message-ID: <MW4PR02MB7186F7F6D6D174B03FDF32CEE1C29@MW4PR02MB7186.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20220425140619.2.Iae013f0ff4599294189f3a6e91376fad137bbabf@changeid>

>We're supposed to list the supplies in the dt bindings but there are none in
>the eDP PHY bindings.
>
>Looking at the driver in Linux, I can see that there seem to be two relevant
>supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings.
>
>NOTE: from looking at the Qualcomm datasheet for sc7280, it's not
>immediately clear how to figure out how to fill in these supplies. The only two
>eDP related supplies are simply described as "power for eDP 0.9V circuits" and
>"power for eDP 1.2V circuits". From guessing and from comparing how a
>similar PHY is hooked up on other similar Qualcomm boards, I'll make the
>educated guess that the 1.2V supply goes to "vdda-phy" and the 0.9V supply
>goes to "vdda-pll" and I'll use that in the example here.
>
>Signed-off-by: Douglas Anderson <dianders@chromium.org>
>---
>
> Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
>b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
>index a5850ff529f8..cf9e9b8011cb 100644
>--- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
>+++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
>@@ -41,6 +41,9 @@ properties:
>   "#phy-cells":
>     const: 0
>
>+  vdda-phy-supply: true
>+  vdda-pll-supply: true
>+
> required:
>   - compatible
>   - reg
>@@ -65,5 +68,8 @@ examples:
>
>       #clock-cells = <1>;
>       #phy-cells = <0>;
>+
>+      vdda-phy-supply = <&vdd_a_edp_0_1p2>;
>+      vdda-pll-supply = <&vdd_a_edp_0_0p9>;
>     };
> ...
>--
>2.36.0.rc2.479.g8af0fa9b8e-goog

Reviewed-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>

WARNING: multiple messages have this Message-ID (diff)
From: "Sankeerth Billakanti (QUIC)" <quic_sbillaka@quicinc.com>
To: Douglas Anderson <dianders@chromium.org>,
	"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
	Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	"dmitry.baryshkov@linaro.org" <dmitry.baryshkov@linaro.org>,
	Rob Clark <robdclark@chromium.org>
Cc: "Abhinav Kumar (QUIC)" <quic_abhinavk@quicinc.com>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	Stephen Boyd <swboyd@chromium.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"freedreno@lists.freedesktop.org"
	<freedreno@lists.freedesktop.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	"Sankeerth Billakanti (QUIC)" <quic_sbillaka@quicinc.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"Kalyan Thota (QUIC)" <quic_kalyant@quicinc.com>,
	"Kuogee Hsieh (QUIC)" <quic_khsieh@quicinc.com>,
	Andy Gross <agross@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy
Date: Thu, 5 May 2022 18:47:43 +0000	[thread overview]
Message-ID: <MW4PR02MB7186F7F6D6D174B03FDF32CEE1C29@MW4PR02MB7186.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20220425140619.2.Iae013f0ff4599294189f3a6e91376fad137bbabf@changeid>

>We're supposed to list the supplies in the dt bindings but there are none in
>the eDP PHY bindings.
>
>Looking at the driver in Linux, I can see that there seem to be two relevant
>supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings.
>
>NOTE: from looking at the Qualcomm datasheet for sc7280, it's not
>immediately clear how to figure out how to fill in these supplies. The only two
>eDP related supplies are simply described as "power for eDP 0.9V circuits" and
>"power for eDP 1.2V circuits". From guessing and from comparing how a
>similar PHY is hooked up on other similar Qualcomm boards, I'll make the
>educated guess that the 1.2V supply goes to "vdda-phy" and the 0.9V supply
>goes to "vdda-pll" and I'll use that in the example here.
>
>Signed-off-by: Douglas Anderson <dianders@chromium.org>
>---
>
> Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
>b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
>index a5850ff529f8..cf9e9b8011cb 100644
>--- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
>+++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
>@@ -41,6 +41,9 @@ properties:
>   "#phy-cells":
>     const: 0
>
>+  vdda-phy-supply: true
>+  vdda-pll-supply: true
>+
> required:
>   - compatible
>   - reg
>@@ -65,5 +68,8 @@ examples:
>
>       #clock-cells = <1>;
>       #phy-cells = <0>;
>+
>+      vdda-phy-supply = <&vdd_a_edp_0_1p2>;
>+      vdda-pll-supply = <&vdd_a_edp_0_0p9>;
>     };
> ...
>--
>2.36.0.rc2.479.g8af0fa9b8e-goog

Reviewed-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com>

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2022-05-05 18:48 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 21:06 [PATCH 0/2] dt-bindings: List supplies needed for sc7280 eDP Douglas Anderson
2022-04-25 21:06 ` Douglas Anderson
2022-04-25 21:06 ` Douglas Anderson
2022-04-25 21:06 ` [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings Douglas Anderson
2022-04-25 21:06   ` Douglas Anderson
2022-04-25 21:06   ` Douglas Anderson
2022-04-25 21:14   ` Stephen Boyd
2022-04-25 21:14     ` Stephen Boyd
2022-04-25 21:14     ` Stephen Boyd
2022-04-25 21:18     ` Doug Anderson
2022-04-25 21:18       ` Doug Anderson
2022-04-25 21:18       ` Doug Anderson
2022-05-05 18:02       ` Sankeerth Billakanti
2022-05-05 18:02         ` Sankeerth Billakanti
2022-05-05 18:02         ` Sankeerth Billakanti
2022-05-05 18:18         ` Stephen Boyd
2022-05-05 18:18           ` Stephen Boyd
2022-05-05 18:18           ` Stephen Boyd
2022-05-05 18:47           ` Sankeerth Billakanti (QUIC)
2022-05-05 18:47             ` Sankeerth Billakanti (QUIC)
2022-05-05 18:47             ` Sankeerth Billakanti (QUIC)
2022-05-05 19:06             ` Stephen Boyd
2022-05-05 19:06               ` Stephen Boyd
2022-05-05 19:06               ` Stephen Boyd
2022-05-06 13:36               ` Sankeerth Billakanti (QUIC)
2022-05-06 13:36                 ` Sankeerth Billakanti (QUIC)
2022-05-06 13:36                 ` Sankeerth Billakanti (QUIC)
2022-05-11 18:21                 ` Doug Anderson
2022-05-11 18:21                   ` Doug Anderson
2022-05-11 18:21                   ` Doug Anderson
2022-04-25 21:06 ` [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy Douglas Anderson
2022-04-25 21:06   ` Douglas Anderson
2022-04-25 21:06   ` Douglas Anderson
2022-05-05 18:47   ` Sankeerth Billakanti (QUIC) [this message]
2022-05-05 18:47     ` Sankeerth Billakanti (QUIC)
2022-05-05 18:47     ` Sankeerth Billakanti (QUIC)
2022-06-16 15:35   ` Doug Anderson
2022-06-16 15:35     ` Doug Anderson
2022-06-16 15:35     ` Doug Anderson
2022-06-17  0:10     ` Vinod Koul
2022-06-17  0:10       ` Vinod Koul
2022-06-17  0:10       ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR02MB7186F7F6D6D174B03FDF32CEE1C29@MW4PR02MB7186.namprd02.prod.outlook.com \
    --to=quic_sbillaka@quicinc.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=kishon@ti.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_kalyant@quicinc.com \
    --cc=quic_khsieh@quicinc.com \
    --cc=robdclark@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.