From: "Kolacinski, Karol" <karol.kolacinski@intel.com>
To: Paolo Abeni <pabeni@redhat.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"edumazet@google.com" <edumazet@google.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
"G, GurucharanX" <gurucharanx.g@intel.com>
Subject: Re: [PATCH net-next 2/3] ice: add i2c write command
Date: Mon, 23 May 2022 17:02:55 +0000 [thread overview]
Message-ID: <MW4PR11MB5800F540CCD489F150B5178186D49@MW4PR11MB5800.namprd11.prod.outlook.com> (raw)
In-Reply-To: <a4438af4d2a45b137172ed24f4ca362f8e4bf143.camel@redhat.com>
> On Thu, 19 May 2022 15:40 +0200 Paolo Abeni wrote:
> > + for (i = 0; i < data_size; i++) {
> > + cmd->i2c_data[i] = *data;
> > + data++;
> > + }
> Why not:
> memcpy(cmd->i2c_data, data, data_size);
>
> ?
>
> Thanks!
>
> Paolo
Nice catch, thanks!
Karol
next prev parent reply other threads:[~2022-05-23 17:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 21:19 [PATCH net-next 0/3][pull request] 100GbE Intel Wired LAN Driver Updates 2022-05-17 Tony Nguyen
2022-05-17 21:19 ` [PATCH net-next 1/3] ice: remove u16 arithmetic in ice_gnss Tony Nguyen
2022-05-17 21:19 ` [PATCH net-next 2/3] ice: add i2c write command Tony Nguyen
2022-05-19 13:40 ` Paolo Abeni
2022-05-23 17:02 ` Kolacinski, Karol [this message]
2022-05-17 21:19 ` [PATCH net-next 3/3] ice: add write functionality for GNSS TTY Tony Nguyen
2022-05-19 4:57 ` Jakub Kicinski
2022-05-23 16:56 ` Kolacinski, Karol
2022-05-23 17:58 ` Jakub Kicinski
2022-06-23 13:39 ` Kolacinski, Karol
2022-06-23 16:07 ` Jakub Kicinski
2022-05-19 13:45 ` Paolo Abeni
2022-05-23 16:58 ` Kolacinski, Karol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB5800F540CCD489F150B5178186D49@MW4PR11MB5800.namprd11.prod.outlook.com \
--to=karol.kolacinski@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gurucharanx.g@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.