From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ECACC433EF for ; Wed, 29 Jun 2022 08:07:25 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CDDF0400D7; Wed, 29 Jun 2022 10:07:24 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 074A040042 for ; Wed, 29 Jun 2022 10:07:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656490043; x=1688026043; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=NIRgTtX+hlKgBv3Ej+4Sg+ppdudWcs8kvINUzx5d5z0=; b=NH3/OLYf/zY0E3XTsafIUAZzK/XQ2nINhMSpaV0sRQOtv4VUlfcIV9ee KyO1ZsEVneeU/os8ngg4vAL/TSdkwDO0oiZ1DB871mHr7rgNmapCKbBG/ lYoqapehCa93nU8qf1x1w/UfoXBy2vD/6hMJkZHHvb4wBAfDqoDrBmvdF sK3AzkTPAqnjRInLdM3IlIH9pRbW+eQA8Jz8ZVDAHQ3FAM5HWfjJ1KCjz 6lPNseFc3l5j5CVc6phJxXaMzhf+NF1JfelTw8JUuIdsenH4SAciLmqAr m4+g+zsUYGxRkNd/2c2HZmvVtkxBPK8Dk5OFTybR6HzM3mJ6D1Xj+06La Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10392"; a="262366581" X-IronPort-AV: E=Sophos;i="5.92,230,1650956400"; d="scan'208";a="262366581" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2022 01:07:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,230,1650956400"; d="scan'208";a="917506445" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga005.fm.intel.com with ESMTP; 29 Jun 2022 01:07:21 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 29 Jun 2022 01:07:20 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 29 Jun 2022 01:07:20 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.44) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 29 Jun 2022 01:07:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HSRQP0dJ8Rq3OistPxYx0YedNHZqj4tZp7nz5FfYuprSz51iJlQ5m0brYMSBbWFbLNXH8kvHsD4RHAcBtlSCTAYwqmKXTicpqaIx8kxxso+DVfL3vgS/fAQ1eU6Cf1RoTAAPX0iqG1BKlwltjB6tvUdw0O3owyiYWaGi+UixELJ03Z70JaMX6LR6TCRR9FSPtr9VVJXhSrCuZ8qNHESsYmoH6mYD9DoCwLx+fUjGd1lQRSL2MIDkRLL8W2fRHkVFRtX9cIaUQ4Udw7Oe5HTAI/BO1YIZl+7V47sxRkclJRripqrFBAqRGcTZByRjs0PvXmF++RhabaH7pmHrTIeGnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t68KtvXRt4q1ErN8Ua6/fittoYI9ZZc/g7zfKwb+SrI=; b=AqU3xtbBz+udwc3xb8f0sl2ZpQznAqnhZyYsI21AYFjcxE+DEMmPZzQDGvMFiz01zgAuxJOnNA/CEG9S+6Y1EhDwCRXSOG3FHbZTbyeGN8rCUEnw6YtteW6x/7C5GB6LEjt/kjoyi1DOgZcDJYoXnST5BW9A/wHVMNC14sLxtJwCKzzhDh7lg40nZXWdnTX8rSCnsCqexmjxK8BFdX7esUofwK0TMqLOMLVEPVhb2I+0GkFz71CYOi2pRaio72znuoAdY7Nr+VlgPdHvNfqFQIpb0yKfZdjNkvHs4X0ye3gJ/u74V6tAhIZF9PcqbCM/iI3DHUInb0+zCQ1ia2yw6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by SN6PR11MB2926.namprd11.prod.outlook.com (2603:10b6:805:ce::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Wed, 29 Jun 2022 08:07:18 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::6537:6de6:7337:1b87]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::6537:6de6:7337:1b87%6]) with mapi id 15.20.5353.016; Wed, 29 Jun 2022 08:07:18 +0000 From: "Zhang, Roy Fan" To: Gowrishankar Muthukrishnan , "dev@dpdk.org" CC: "Dooley, Brian" , Anoob Joseph , Archana Muniganti , Jerin Jacob , "david.marchand@redhat.com" Subject: RE: [PATCH v2] examples/fips_validation: add parsing for xts Thread-Topic: [PATCH v2] examples/fips_validation: add parsing for xts Thread-Index: AQHYivDYPybznGwZhEGqC3IE70R/Ta1mAhUg Date: Wed, 29 Jun 2022 08:07:18 +0000 Message-ID: References: <41b2b4d16799a311ea63536b3009052c0cf99d75.1656402995.git.gmuthukrishn@marvell.com> In-Reply-To: Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b9e12fb3-5655-4cbb-2fe7-08da59a66300 x-ms-traffictypediagnostic: SN6PR11MB2926:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wIXkjjbslGM5g8/odq5r2VKYyOrOUgdulC4IcKNTbX1+z97ENqa2BFQDaRERRxqMRoFi5vfrjEtGvdikrffBxg681fQbKeZWpPRJLGwAJVOeOh+GagOuepovehtnkmHAHJEfVo2ZOqJJz1ZwjB4qgye7AmM2NihdPoeudFM0yqM7G/BJwuUBZiP0cY3G+1Qfbxs25ZyNLb8Eja9yz2AY0GpfW6dGzKwycdadCx2YbNRWUThDhb26RlQX8Z+mlH3d79Aq+OTHYzgO/JpXIHqvOS4uiUcL/4WLEcuQrp51yifoq8pVlV1dKZWwd0PdGMpmOEUTPE1t7xJyzjXWDHYl18ZEtY8CQRs2ohYRLajdF47lV/5Mduja/c7qaF73Odk5785fvladYpGhsdP8uL0QdYNICyefzADB/C7TTTOSC+HS7thdZors6sZqy+Q1IvSj4P33amcnElEa9hecvxG0U2HVRFE8zHAQPGu1Di4Ksaq01viyo62w+jwYYuyb0hC0RSI9MZRm7Mif8/pGi/i2B18kuWlAOM+oyOFM/eeoB1HRIBkPJjFknpcAeUanQIg8gi4dtbq8gLZ5GXXHbwC3vZGGkLl2fN7/nMRrzjRC1OjOpWHyuv9TjST56QlOcwopZL61hfVTTHA2RjFFE1+D4qzdRcYsODHxeOevwqa48Iw5jgcP3CGvpY1ZSbAmS3c3osSR92aYafhAxUHfdYjkID2TZcueY9VwQB2uqissavDXiiCwpZo9pBIKf+2PPMHV6vTxSa3zq32N5Alo/nNvygPRsPNX5LcSNJtrRuayntc= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(376002)(396003)(366004)(39860400002)(346002)(38070700005)(122000001)(186003)(66446008)(38100700002)(54906003)(55016003)(76116006)(316002)(66556008)(66946007)(83380400001)(110136005)(8676002)(64756008)(71200400001)(66476007)(4326008)(33656002)(41300700001)(53546011)(26005)(7696005)(8936002)(52536014)(478600001)(6506007)(82960400001)(2906002)(5660300002)(9686003)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?rCf6JZvZL0nkYxqnCUtyHP5eVrfgUeCEByrLlNEK3jXxIAEbcvHkMRKi?= =?Windows-1252?Q?rUyDRjisctYBEWGs3sSWLpcAoivanHWVsUudGrYnwKyJNkgm1KE+0Yiv?= =?Windows-1252?Q?G2IxJ/Cmwh2kO+ciCeTujlYHbVjBhSqjjxz3waMN///+XLOJ1hZa4PbJ?= =?Windows-1252?Q?AsGhVZZdco0VA7VvN0HvtfYjUPN4li4OTYimpXnhYRymBBeIq2xn/Gns?= =?Windows-1252?Q?DAAhcLYktPxgmo3K12wzS/LgfDpgRSw1Cw6F3zzrpToVEXKmaGF93LFQ?= =?Windows-1252?Q?0gEywo2/i5SoqRUOt5NcuogbT+Eul0gCgf5xyi3QWJdc8nxaEq/1GH1p?= =?Windows-1252?Q?3GzjKCeMuZ6UbloqN/wGXQ4ycuyyszq3GbAmA23ZoFyl1gE1WC4v8tut?= =?Windows-1252?Q?QWM7i8po/ziqwuUB8BmBrvsCLzzU3nKQKTwUKICwuet9nHKu4ssMOGE8?= =?Windows-1252?Q?VhohKMkfrbVuag8F29L/vvuRXFmk819rJv2LqfDoA035k2+ztmMmBYON?= =?Windows-1252?Q?O3YibkGPfijYi2fHQA1CtmIfEJOH8P5b3ml3WUtfaNBwXM6LtV9f5P1d?= =?Windows-1252?Q?ftpzxXh82xOQYf2cHDh9WTSZztoTbUUXsSa8dmE85yn8jMIWDR7dS8sE?= =?Windows-1252?Q?FZFCUbJT5J1F9FwbSHkbSdHJ3GNWfWUrDWrrnIzILKLWLsKnCaTyJ8WZ?= =?Windows-1252?Q?aO6FEitnat5HjB/WpGYyIA2U3Q3mVmqQmuEUycbyQzQw9DyBEb5yWcnd?= =?Windows-1252?Q?tIR25OP8DzE3B6yvvG71uzLpPEADPwFCW1C10S24q78h8nYLvOPViNOt?= =?Windows-1252?Q?XzzkR3wRGPN/7qCXwgKn/JVJmCeqT9cD55yVFx+skDrqODtl4OnJUt/Q?= =?Windows-1252?Q?qn3jiYEnl6cmyc+mBO3+F4uKiwK4SHmt24j+aMMfI0tpor52Ea9fYYYA?= =?Windows-1252?Q?QGy9mRAfV68xbB7SjF/hF7HHgZcPCntzJK6N39CnNcIlL+XwgWpuK5MN?= =?Windows-1252?Q?YhrxvpljdE7MJuDfJ1buLPA5T7D9mfbh/LDR/htgEajZta+ZC6B2stmj?= =?Windows-1252?Q?vb9eT6+WSOiXQ86Z9gdUS06DfW38bwB7qBMvZL0lTC9yaALgLVJxGjLi?= =?Windows-1252?Q?ovvmdLYMxPD4jF13A9Gf897XjlS7/BYPud+JbaT6InRnlfbxU/4wSxQA?= =?Windows-1252?Q?oiPHIOZv6elyU6QWg+MeeimH7+qb5eNVT7pp93c4MaGp/nbr2W7tsumK?= =?Windows-1252?Q?nYxCRzCSAzqYRM8T1ZAKEJqPfKqpYk6igbionDx8p6uMRMQPQJqIeBmw?= =?Windows-1252?Q?t3BCSPCUf6U9kVCp/M6VjPq0dd18MRPzWUvsuqxy2KZENRHfp4FBLyG2?= =?Windows-1252?Q?5n+087ytRAk7OxTbpoaRxk5eUKdXTKPqx5NW3+lvhT/SCN09YcMhizhE?= =?Windows-1252?Q?wY1PTZlr0j61eZWVTQJ6v8ffkpQy0S9iq1Du3Clo1KklplhVrrZ+vwuA?= =?Windows-1252?Q?j5jXITWAeYEMA9R5wKZvd11RtpAs/MdDrtnWNsnsEZwAFkv7qVv2V/1B?= =?Windows-1252?Q?OOCYVfRNG9nTafXS6EpmM2qwtIF4ehxhKXHZyVD6j1sZ+dkuym2oBrAE?= =?Windows-1252?Q?F/IxR58xvj17IFFzNslXE3CGUZ/X3f3+NGuKBdYpT/XeNh7dWkk69jVe?= =?Windows-1252?Q?wbDwsW7//sH/CUpIPs6hR0lbRZf/n6ZW?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9e12fb3-5655-4cbb-2fe7-08da59a66300 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2022 08:07:18.6433 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JroSckdrWJF7dWmqmPu02R5qtpCpSXMR7TX/qnHpnXG6LmTSkqY9Zf2KD1QwfSRgw5oRMEhNBct0I7ZF26iSeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2926 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Gowrishankar Muthukrishnan > Sent: Tuesday, June 28, 2022 2:12 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Dooley, Brian > ; Anoob Joseph ; Archana > Muniganti ; Jerin Jacob ; > Gowrishankar Muthukrishnan > Subject: [PATCH v2] examples/fips_validation: add parsing for xts >=20 > Added function to parse algorithm for AES XTS test. >=20 > Signed-off-by: Gowrishankar Muthukrishnan > --- > v2: > - build failure fixed if no jansson lib available. > --- > examples/fips_validation/fips_validation.c | 4 +- > examples/fips_validation/fips_validation.h | 16 +- > .../fips_validation/fips_validation_xts.c | 141 ++++++++++++++++++ > examples/fips_validation/main.c | 5 + > 4 files changed, 164 insertions(+), 2 deletions(-) >=20 > diff --git a/examples/fips_validation/fips_validation.c > b/examples/fips_validation/fips_validation.c > index 324abccb14..f181363ef7 100644 > --- a/examples/fips_validation/fips_validation.c > +++ b/examples/fips_validation/fips_validation.c > @@ -463,7 +463,9 @@ fips_test_parse_one_json_vector_set(void) > else if (strstr(algo_str, "CMAC")) > info.algo =3D FIPS_TEST_ALGO_AES_CMAC; > else if (strstr(algo_str, "AES-CBC")) As David suggested - this looks to be a fix - I believe he is right. I will let Akhil to decide. > - info.algo =3D FIPS_TEST_ALGO_AES; > + info.algo =3D FIPS_TEST_ALGO_AES_CBC; > + else if (strstr(algo_str, "AES-XTS")) > + info.algo =3D FIPS_TEST_ALGO_AES_XTS; > else > return -EINVAL; >=20 Other than that, Acked-by: Fan Zhang