From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C727C433F5 for ; Thu, 10 Feb 2022 16:39:03 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8A5FB41144; Thu, 10 Feb 2022 17:39:02 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 4584D41141 for ; Thu, 10 Feb 2022 17:39:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644511140; x=1676047140; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=aUNOzSobTjJ9JUXceEHehjf8bbee4b+BdXMNr6x0n3c=; b=Job7x4CQC8XPrrS/CQ7OvdbqrJ5ytDLf9hivybyiL3+WG1HPWcxLXE2D hbY6xcBiR3FWxhPv1im7LyV7qPew7XBkzPVZSNzDJ8qzLd3vyTJe94Vz0 vGd+AzBMgt79khVmZ5AiPbI7NPrMsgjwaPvry8agMfhIsPhDCEaHOCdzd i0HCmVe0yxLf3xEQDBH807HT/LjqlK+ODF/KHYRxvEY8hz0PoRpxCBrlU b0M5H/sF7yQxu3tDPRtVCPDW8qBdgN1AcWpIoJoLCa+iPE8P9Lvsj542j 74QO5L97T6PqkrqfWX0Ke8YIJSozwWXIHjJgOZo7llvprc4240ygS8QYt w==; X-IronPort-AV: E=McAfee;i="6200,9189,10254"; a="312818202" X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="312818202" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 08:38:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,359,1635231600"; d="scan'208";a="633725267" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga004.jf.intel.com with ESMTP; 10 Feb 2022 08:38:59 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 08:38:59 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 08:38:59 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 08:38:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i5d0OAUMCI6G4Kjr1HV/A+u7Z7FjUpMTyP2RPoQWuc2CjLhH2S6Cn/sZDJQ1Uc/q3b47xL8cIPQZhUrV+LiGFUMYPJvV5avW/We0uVuWFIzSDdtXeBypiM9MHPcs922TlpfWAxOsJvJArnOQggLMtrC9zeRIhAmD8l95z4H/SSxIGscqq5wyLmi8jq2xCMQftjc6YfSjr84o9vliLSbF1dFKUx1h87CO9OSQVtumU9WFVBlZut6wwyMKw1Tak8XPa29AmbPlePR+hYeJYA2CG9uWGE6yW8JG1bRoq8LxxeUmQCjrM/Xgjv/zAdvhpSTy9U8ynWYGk/Ih5kSQTx3KAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aUNOzSobTjJ9JUXceEHehjf8bbee4b+BdXMNr6x0n3c=; b=DRyoO/8d+UTuZE5EB3K7V9598mvSDin5+dkYqfl8XdTnltUV8HyU07YkGsp8Ezx5zEz8bGH115yb74Pb0lFLxbqvVf2SvM+W3FL0WOVzdtDbgNzo/8xs/vkjrgC6Ex23Y2psuHNnFWItWBj+zDLLIExrlb2jVJTVhnOhvnkMsWCp/2xAZDmcMxzIPLTGjqZ2Rx/oWqkks/UcGe76xt4Yi5EK8utaAv64eMvKmqRQ8UfSnPF5Wd1At36KcOflFR1QBVYzMJCErClGTUQRxaOLQ6xWjOS7yL3xvJJcxGbLoO1X8A2+Ec64ECp3XPizScliApS6mikvXwj0G2Jv/nbZgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MW5PR11MB5809.namprd11.prod.outlook.com (2603:10b6:303:197::6) by PH7PR11MB5793.namprd11.prod.outlook.com (2603:10b6:510:13a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.12; Thu, 10 Feb 2022 16:38:57 +0000 Received: from MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::a599:b969:5072:71cb]) by MW5PR11MB5809.namprd11.prod.outlook.com ([fe80::a599:b969:5072:71cb%4]) with mapi id 15.20.4951.019; Thu, 10 Feb 2022 16:38:56 +0000 From: "Zhang, Roy Fan" To: Akhil Goyal , "Kusztal, ArkadiuszX" , "dev@dpdk.org" CC: Ramkumar Balu Subject: RE: [EXT] [PATCH v2 4/4] crypto: reorganize endianness comments, add crypto uint Thread-Topic: [EXT] [PATCH v2 4/4] crypto: reorganize endianness comments, add crypto uint Thread-Index: AQHYHBbwHue6tb5HC0qrJjcWfYOWGqyMloIAgABqMaA= Date: Thu, 10 Feb 2022 16:38:56 +0000 Message-ID: References: <20220207113555.8431-1-arkadiuszx.kusztal@intel.com> <20220207113555.8431-5-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: zh-Hans-HK, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.200.16 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d2dd4be0-5b27-4703-babf-08d9ecb3d525 x-ms-traffictypediagnostic: PH7PR11MB5793:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Z9Kh3Q4/bp1oRdg5eBRbM7O6zrzKX5AZtnkcnc0+JVZpKWL0b13COA5+rLKQxkbxBgdx54oTaqF+7c8cXY7fA6Uj8eChRc6/9psk2vaTdGodu+i1x0C4BQZo348y+kDN1wALDATduIb+LQ0DXDaluBe6Mt24DIx2Q/c/dWV7sAJOgvoekzaYnYyZRotOMSBX8iXNokgKy2ClsAuBxLWQ//wOws/VcEWfqucLmuRQ3EfGtOY1p/mkjmyhFfG0qNc3A6rZZGcpRrcp0kh6EPAADI2/9FnnnlhZDReD1MD4FhkYjcdDJom2tUW2ci0aMSdeu8v8NPZRMXEx+Aj0GJbQskxaGWqAKCrjrv5wclLmZeSDUYITn7seDklYeLr1qmTaitCPBZZmGdLmkCsGEDNejYzgRWYj759H6DfV/FHw5XkV/09jPGgcLIWVoqbT+kJyZlc2SPVLZFmobQSBaLO6hJKsul9uTpRcN+qao7pjlNu+dqJbs0sPrSIA59d76ofNzpNOldOUkGGwzQqFgncQZo2u8vv+cS04jCB5gS9ELTqUmhXaqA1MKZTPjIX0YORFLcrJ9m0d/Ljn/xw6l7mF4MOLVVDoVELwPiZO3SSqbJ0fwVNP7SwvDT09ZgnDHMixMvsJU9g2iyKyfpE+EfBSLUnnwvho54i0sP2WerafNLIJzA2O68QTWIN7uOE/q0msriyjJnVJbfPu5pxrnAyIPkL6KYpnNVLr3lNVHjbZlakR3WjJ/MjZrJuFcEymkDdHTpBMeyBQDBhmjUmfGcz48iRxXPKs9Wm0RAkYMuhDuVwXI7xaLTFxF16EteOlz2cO x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW5PR11MB5809.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(83380400001)(508600001)(966005)(71200400001)(5660300002)(55016003)(33656002)(2906002)(76116006)(186003)(64756008)(66446008)(66476007)(66946007)(8676002)(110136005)(8936002)(52536014)(26005)(66556008)(4326008)(316002)(9686003)(122000001)(82960400001)(38070700005)(38100700002)(86362001)(7696005)(6506007)(53546011)(533714002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?4yl4QwGIIczCyr9TngLcPkw51m8WFL710+wgEnTBiqfKaSXLpAbCRvM8?= =?Windows-1252?Q?STn0SOxMnhZQs7NkpuXqijii2BMy3ZxTuHWPpdMGjjJxpDw0jSG2QIHx?= =?Windows-1252?Q?AH4O5je94BJKjY5x2wp6tftFl/OhOGhke6lonAoofZdI66UdcKaUHS6u?= =?Windows-1252?Q?wE4WZKJBBNqboHMpuATNXRFtFtVoRV0xEaW4qQrKy5U6EKvFrrFxbCV1?= =?Windows-1252?Q?rS+VWRl62piBgqN9TqwbgULR5Fv1r+jM/cSBxXY2qMTBhCNDn82bm+ic?= =?Windows-1252?Q?UlcL2M3aoZoLOYjyvVgTYx9F/rri/Ze8AKfDYW1dO3iisxOPtT7vqbjB?= =?Windows-1252?Q?cRCIplvHLdsU6DV6dp8oJKnRNlm7hNEvXjs2nHFjKtS+z+/ytcKKzYhE?= =?Windows-1252?Q?cK2YdNqkFRhCL4iNr82Rc0BIG16My49OWIvPqSBzHC8QMP2Jdr78ur4B?= =?Windows-1252?Q?yfPU4wdWIfIiKhelx2SDjcQuTofP/AP2DRs2mAMLbONy3Hl9Umnpsl+q?= =?Windows-1252?Q?VwaFIJ3H4FwjSIjC51IrZdsKLjWYydBW4MxG3iB2JYqCdCEbD1MSVQjx?= =?Windows-1252?Q?Rw1zS2iO7TwAmr8sYV2jJrcAVZmJoYHu45c6oXRXonm8dXhE24oYmF8/?= =?Windows-1252?Q?4Es5WpB7PgtpJ6IYb607dtJ7dLIp4krk6cv4DMklQV8CEcFGVHCP5VUc?= =?Windows-1252?Q?TD1xUJv9YYWm2XPnW9E3/RBHr13NtEE3eMHZSy21z6AJwqtZKjLaLCqm?= =?Windows-1252?Q?DPWy6FRfjWolqTw9EuksPz3G+a/mMrOGZHN7PeRyVEtde5Ki6306yqsf?= =?Windows-1252?Q?KEd3PGyUmogyPeSzI52DvOwUyRmYTmirMhHc7DVXHKGJWqJb5G+08NQD?= =?Windows-1252?Q?tNwjmWEMZoxBVY1l5U7nMdAe2R5HPEaAm6PPi6o1e89+UfgO/Qg1tngD?= =?Windows-1252?Q?x5V4EnEls1jKSP6MmZxSVH5+HRkLfXv9uzLv9taIj4wk3YVQBK1IhQU8?= =?Windows-1252?Q?5IiaFwBMSB3jySjljRp5YeQIAkxA9Qt+pcwNq2nGpilNtQJBhQdzCoY9?= =?Windows-1252?Q?9TSwLKCLwgI85hCmFARMG7fYu9KzWMQ8t1OwWZ23I5Rebmv1BzMmm1Nu?= =?Windows-1252?Q?1xFcHX+sDpHwLCI6ltaLdqL3e86WpgMWIUzwBmIr1eCMfBMH6HubtSNH?= =?Windows-1252?Q?WOtWigzs3qhKz+ikvhcTFYtDVTawm+dTgfgzYNsRMvWW1smZMmTqZ5yy?= =?Windows-1252?Q?OzH8bVFx7I5ll4EEt63TnGrZ93rl8idVJxX8V8O/RBxNqoQb2pJZaQGX?= =?Windows-1252?Q?NNagGitSHIr/b7Bge0nkKh5jnaqDlen3m1ASOEPNxmLcht3YT7Uz7Lth?= =?Windows-1252?Q?UvyPS2izQPWa+Jibr86aHigr7xQdWFwdXzX2GBgxCmqE5Obwb4n/gKKx?= =?Windows-1252?Q?gcYczeBw19HowFfAkjLo6ObzA5ziz/sn+ym4ROpQjqPIPfl85qhvsbN7?= =?Windows-1252?Q?kmZEZZXizE1T3fX+7yAYLvPlpDjRvzVf4rQEXi8I9XwO2tvP4CqA3FB9?= =?Windows-1252?Q?9W+1cwM4GsyYUn9DDjfxUnYgAwZ9zX4MCt/vwQh7jtDKtbSQ7mgRW0la?= =?Windows-1252?Q?jgKbtQRJjANJznNWFXp/F0E7gX/4A4xHI/G2McL1AFNjdqFVNkU4tipb?= =?Windows-1252?Q?EaJeczdF//OjZMzNwI0zzgweBX1UB254fBoTxeh1gc9C2tfX86hhfY6J?= =?Windows-1252?Q?hvCX7xS3ftYdn/OaD5k=3D?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5809.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2dd4be0-5b27-4703-babf-08d9ecb3d525 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2022 16:38:56.7863 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pGtTE+NM065OGNPeLFUiG+ycle28wn8yGc42e5FSEjOL14eL/gXk1U1ErjEZEiGmfEu9JDposossOdDDF6YHRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5793 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil, I assume everything in asym crypto is under experimental tag at the moment = right? The goal is to have them updated and fixed before DPDK 22.11 so the experim= ental tag can be removed. Regards, Fan > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, February 10, 2022 10:17 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan ; Ramkumar Balu > > Subject: RE: [EXT] [PATCH v2 4/4] crypto: reorganize endianness comments, > add crypto uint >=20 > > This patch adds crypto uint typedef so adding comment > > about byte-order becomes unnecessary. > > > > It makes API comments more tidy, and more consistent > > with other asymmetric crypto APIs. > > > > Additionally it reorganizes code that enums, externs > > and forward declarations are moved to the top of the > > header file making code more readable. > > > > It removes also comments like co-prime constraint > > from mod inv as it is natural mathematical constraint, > > not PMD constraint. > > > > Signed-off-by: Arek Kusztal > > --- > CI is reporting abi issues in this set. Can you check? > http://mails.dpdk.org/archives/test-report/2022-February/257403.html